Change #264614

Comments

unittests: cleanups
- make sure all UNITTEST prototypes mark in which unit test they are used,
  with "@unittest" markup

- make sure all UNITTEST functions do not use Curl_ prefix, as that is a
  prefix we use for global private functions and these functions are static
  and therefore not global and the prefix is wrong

- drop UNITTEST for functions not used in unit tests

- make the extract-unit-protos script highlight the above issues if found

- extract-unit-protos now also outputs the unit test number for all the
  generated protos in lib/unitprotos.h to aid readers. It also adds the source
  file and line number where the proto originates from.

- extract-unit-protos now exits with a non-zero value if any of the above
  warnings are triggered

- cf-dns: Curl_cf_dns_result => static cf_dns_result
- hostip: Curl_ipv6works => static ipv6works
- url: remove Curl_setup_conn() - not used anymore
- connect: Curl_timeleft_now_ms => UNITTEST timeleft_now_ms

Closes #21330

Changed files

• lib/cf-dns.c
• lib/cf-dns.h
• lib/cf-ip-happy.c
• lib/cfilters.c
• lib/connect.c
• lib/connect.h
• lib/dnscache.c
• lib/doh.c
• lib/dynhds.c
• lib/ftp.c
• lib/hostip.c
• lib/hostip.h
• lib/http_aws_sigv4.c
• lib/llist.c
• lib/multi.c
• lib/noproxy.c
• lib/progress.c
• lib/uint-bset.c
• lib/uint-hash.c
• lib/uint-spbset.c
• lib/uint-table.c
• lib/url.c
• lib/url.h
• lib/urlapi.c
• lib/vtls/x509asn1.c
• scripts/extract-unit-protos
• tests/unit/unit1300.c
• tests/unit/unit1303.c
• tests/unit/unit1608.c
• tests/unit/unit1614.c
• tests/unit/unit1653.c
• tests/unit/unit2600.c
• tests/unit/unit2602.c
• tests/unit/unit3211.c
• tests/unit/unit3212.c
• tests/unit/unit3213.c