Change #264226

Comments

swscale/x86/ops: use plain `ret` instruction
The original intent here was probably to make the ops code agnostic to
which operation is actually last in the list, but the existence of a
divergence between CONTINUE and FINISH already implies that we hard-code
the assumption that the final operation is a write op.

So we can just massively simplify this with a call/ret pair instead of
awkwardly exporting and then jumping back to the return label. This actually
collapses FINISH down into just a plain RET, since the op kernels already
don't set up any extra stack frame.

Signed-off-by: Niklas Haas <git@haasn.dev>

Changed files

• libswscale/x86/ops.c
• libswscale/x86/ops_common.asm
• libswscale/x86/ops_int.asm