Change #261228

Comments

rdmasniff: clean up some resource freeing issues.
Add a routine rdmasniff_free_resoources() to free up all resources
pointed to by the struct pcap_rdmasniff structure for an open device.
Use it both when closing a pcap_t and when cleaning up after a failed
attempt to activate a pcap_t.

Free those routines in the order specified in issue #1532.

Don't save the struct ibv_device * found in pcap_create(); we free up
the  ibv_device array allocated by ibv_get_device_list() when we return
from rdmasniff_create(), and that invalidates the entries in that array.
See the ibv_get_device_list() documentation, and issue #1300.

Fixes #1532.

Fixes #1300.

Improve checking for ibv_ error returns and messages for those errors.

Improve handling of the port number - don't fetch or check it in the
create routine, so that an invalid port number doesn't prevent the
underlying device from being recognized as a valid RDMA device, but do
fetch and check it in the activate routine, so we can report the error
to the user.

Changed files

• CHANGES
• pcap-rdmasniff.c