Change #257212

Comments

build: tidy up and simplify `setmode()` detection and use
- move macro to `curl_setup.h` (from curlx), and rename.
  It's required by src, test servers, libtests. Also used by unit/tunit,
  (which is fixable but this patch doesn't touch it.)
- special-case it for Windows/Cygwin/MS-DOS.
- build: drop `setmode()`/`_setmode()` detection.
  This also avoids detecting the different `setmode()` on BSDs,
  and a lot of complexity and overhead.
- use `CURL_O_BINARY`.

Follow-up to 250d613763dfc29f73010696ee7948f19d07dba9 #15787
Follow-up to 5e70566094463b8463d4dc1bec9b66763a761c76 #15169

Closes #20539

Changed files

• CMake/unix-cache.cmake
• CMake/win32-cache.cmake
• CMakeLists.txt
• acinclude.m4
• configure.ac
• lib/Makefile.inc
• lib/config-win32.h
• lib/curl_config-cmake.h.in
• lib/curl_setup.h
• lib/curlx/binmode.h
• lib/curlx/curlx.h
• src/Makefile.inc
• src/tool_formparse.c
• src/tool_getparam.c
• src/tool_operate.c
• tests/libtest/first.c
• tests/server/mqttd.c
• tests/server/sockfilt.c
• tests/server/socksd.c