Change #257128

Comments

DAG: Require dag_pciinfo() to succeed in dag_findalldevs().
Eliminate a potential NULL dereference discovered by SeungJu Cheon (see
GH #1611).

It does not seem impossible that dag_pciinfo() can fail after dag_open()
succeeded.  It didn't fail in my tests, but it is wrong to rely on that
in dag_stream_long_description() since my commit 467c5e9 and in
dag_findalldevs() since my commit 0cac013.  Thus do the same as is done
in dag_activate_tx() and treat NULL as a hard failure.

Now that the pointer to dag_card_inf_t is never NULL, lose the NULL
coalescing props in dag_stream_long_description().  While at it, use
PCAP_ISUPPER() to validate the card revision.

Changed files

• pcap-dag.c