Change #252797

Comments

Modernize coding style: Reduce scope of local variables.
* HACKING (Coding Style): New section, copied from gnulib/HACKING.
* gettext-runtime/src/envsubst.c: Reduce scope of local variables.
* gettext-runtime/src/escapes.h: Likewise.
* gettext-runtime/src/gettext.c: Likewise.
* gettext-runtime/src/ngettext.c: Likewise.
* gettext-runtime/src/printf-command.c: Likewise.
* gettext-runtime/src/printf_gettext.c: Likewise.
* gettext-runtime/src/printf_ngettext.c: Likewise.
* gnulib-local/lib/addext.c: Likewise.
* gnulib-local/lib/backupfile.c: Likewise.
* gnulib-local/lib/gettext.h: Likewise.
* gnulib-local/lib/markup.c: Likewise.
* gnulib-local/lib/xerror.c: Likewise.
* libtextstyle/gnulib-local/lib/file-ostream.oo.c: Likewise.
* libtextstyle/gnulib-local/lib/html-ostream.oo.c: Likewise.
* libtextstyle/gnulib-local/lib/html-styled-ostream.oo.c: Likewise.
* libtextstyle/gnulib-local/lib/iconv-ostream.oo.c: Likewise.
* libtextstyle/gnulib-local/lib/memory-ostream.oo.c: Likewise.
* libtextstyle/gnulib-local/lib/noop-styled-ostream.oo.c: Likewise.
* libtextstyle/gnulib-local/lib/ostream.oo.c: Likewise.
* libtextstyle/gnulib-local/lib/term-ostream.oo.c: Likewise.
* libtextstyle/gnulib-local/lib/term-styled-ostream.oo.c: Likewise.
* libtextstyle/lib/color.c: Likewise.
* libtextstyle/lib/misc.c: Likewise.
* gettext-tools/src/cldr-plural-exp.c: Likewise.
* gettext-tools/src/cldr-plurals.c: Likewise.
* gettext-tools/src/file-list.c: Likewise.
* gettext-tools/src/filter-quote.c: Likewise.
* gettext-tools/src/format-awk.c: Likewise.
* gettext-tools/src/format-boost.c: Likewise.
* gettext-tools/src/format-c++-brace.c: Likewise.
* gettext-tools/src/format-c.c: Likewise.
* gettext-tools/src/format-c-parse.h: Likewise.
* gettext-tools/src/format-csharp.c: Likewise.
* gettext-tools/src/format-d.c: Likewise.
* gettext-tools/src/format-elisp.c: Likewise.
* gettext-tools/src/format-gcc-internal.c: Likewise.
* gettext-tools/src/format-gfc-internal.c: Likewise.
* gettext-tools/src/format-go.c: Likewise.
* gettext-tools/src/format-java-printf.c: Likewise.
* gettext-tools/src/format-java.c: Likewise.
* gettext-tools/src/format-javascript.c: Likewise.
* gettext-tools/src/format-kde-kuit.c: Likewise.
* gettext-tools/src/format-kde.c: Likewise.
* gettext-tools/src/format-librep.c: Likewise.
* gettext-tools/src/format-lisp.c: Likewise.
* gettext-tools/src/format-lua.c: Likewise.
* gettext-tools/src/format-modula2.c: Likewise.
* gettext-tools/src/format-ocaml.c: Likewise.
* gettext-tools/src/format-pascal.c: Likewise.
* gettext-tools/src/format-perl-brace.c: Likewise.
* gettext-tools/src/format-perl.c: Likewise.
* gettext-tools/src/format-php.c: Likewise.
* gettext-tools/src/format-python-brace.c: Likewise.
* gettext-tools/src/format-python.c: Likewise.
* gettext-tools/src/format-qt-plural.c: Likewise.
* gettext-tools/src/format-qt.c: Likewise.
* gettext-tools/src/format-ruby.c: Likewise.
* gettext-tools/src/format-rust.c: Likewise.
* gettext-tools/src/format-scheme.c: Likewise.
* gettext-tools/src/format-sh-printf.c: Likewise.
* gettext-tools/src/format-sh.c: Likewise.
* gettext-tools/src/format-smalltalk.c: Likewise.
* gettext-tools/src/format-tcl.c: Likewise.
* gettext-tools/src/format.c: Likewise.
* gettext-tools/src/hostname.c: Likewise.
* gettext-tools/src/if-error.c: Likewise.
* gettext-tools/src/its.c: Likewise.
* gettext-tools/src/locating-rules.c: Likewise.
* gettext-tools/src/message.c: Likewise.
* gettext-tools/src/msgattrib.c: Likewise.
* gettext-tools/src/msgcat.c: Likewise.
* gettext-tools/src/msgcmp.c: Likewise.
* gettext-tools/src/msgcomm.c: Likewise.
* gettext-tools/src/msgconv.c: Likewise.
* gettext-tools/src/msgen.c: Likewise.
* gettext-tools/src/msgexec.c: Likewise.
* gettext-tools/src/msgfilter.c: Likewise.
* gettext-tools/src/msgfmt.c: Likewise.
* gettext-tools/src/msggrep.c: Likewise.
* gettext-tools/src/msginit.c: Likewise.
* gettext-tools/src/msgl-ascii.c: Likewise.
* gettext-tools/src/msgl-cat.c: Likewise.
* gettext-tools/src/msgl-charset.c: Likewise.
* gettext-tools/src/msgl-check.c: Likewise.
* gettext-tools/src/msgl-english.c: Likewise.
* gettext-tools/src/msgl-equal.c: Likewise.
* gettext-tools/src/msgl-fsearch.c: Likewise.
* gettext-tools/src/msgl-header.c: Likewise.
* gettext-tools/src/msgl-iconv.c: Likewise.
* gettext-tools/src/msgl-merge.c: Likewise.
* gettext-tools/src/msgl-ofn.c: Likewise.
* gettext-tools/src/msgmerge.c: Likewise.
* gettext-tools/src/msgunfmt.c: Likewise.
* gettext-tools/src/msguniq.c: Likewise.
* gettext-tools/src/open-catalog.c: Likewise.
* gettext-tools/src/plural-count.c: Likewise.
* gettext-tools/src/po-charset.c: Likewise.
* gettext-tools/src/po-time.c: Likewise.
* gettext-tools/src/read-catalog.c: Likewise.
* gettext-tools/src/read-catalog-abstract.c: Likewise.
* gettext-tools/src/read-catalog-file.c: Likewise.
* gettext-tools/src/read-catalog-special.c: Likewise.
* gettext-tools/src/read-csharp.c: Likewise.
* gettext-tools/src/read-desktop.c: Likewise.
* gettext-tools/src/read-java.c: Likewise.
* gettext-tools/src/read-mo.c: Likewise.
* gettext-tools/src/read-po-lex.c: Likewise.
* gettext-tools/src/read-properties.c: Likewise.
* gettext-tools/src/read-resources.c: Likewise.
* gettext-tools/src/read-stringtable.c: Likewise.
* gettext-tools/src/read-tcl.c: Likewise.
* gettext-tools/src/recode-sr-latin.c: Likewise.
* gettext-tools/src/search-path.c: Likewise.
* gettext-tools/src/str-list.c: Likewise.
* gettext-tools/src/urlget.c: Likewise.
* gettext-tools/src/write-catalog.c: Likewise.
* gettext-tools/src/write-csharp.c: Likewise.
* gettext-tools/src/write-desktop.c: Likewise.
* gettext-tools/src/write-java.c: Likewise.
* gettext-tools/src/write-mo.c: Likewise.
* gettext-tools/src/write-po.c: Likewise.
* gettext-tools/src/write-properties.c: Likewise.
* gettext-tools/src/write-qt.c: Likewise.
* gettext-tools/src/write-resources.c: Likewise.
* gettext-tools/src/write-stringtable.c: Likewise.
* gettext-tools/src/write-tcl.c: Likewise.
* gettext-tools/src/write-xml.c: Likewise.
* gettext-tools/src/x-awk.c: Likewise.
* gettext-tools/src/x-c.c: Likewise.
* gettext-tools/src/x-csharp.c: Likewise.
* gettext-tools/src/x-d.c: Likewise.
* gettext-tools/src/x-desktop.c: Likewise.
* gettext-tools/src/x-elisp.c: Likewise.
* gettext-tools/src/x-go.c: Likewise.
* gettext-tools/src/x-java.c: Likewise.
* gettext-tools/src/x-javascript.c: Likewise.
* gettext-tools/src/x-librep.c: Likewise.
* gettext-tools/src/x-lisp.c: Likewise.
* gettext-tools/src/x-lua.c: Likewise.
* gettext-tools/src/x-modula2.c: Likewise.
* gettext-tools/src/x-ocaml.c: Likewise.
* gettext-tools/src/x-perl.c: Likewise.
* gettext-tools/src/x-php.c: Likewise.
* gettext-tools/src/x-po.c: Likewise.
* gettext-tools/src/x-python.c: Likewise.
* gettext-tools/src/x-rst.c: Likewise.
* gettext-tools/src/x-ruby.c: Likewise.
* gettext-tools/src/x-rust.c: Likewise.
* gettext-tools/src/x-scheme.c: Likewise.
* gettext-tools/src/x-sh.c: Likewise.
* gettext-tools/src/x-smalltalk.c: Likewise.
* gettext-tools/src/x-tcl.c: Likewise.
* gettext-tools/src/x-typescript-impl.h: Likewise.
* gettext-tools/src/x-vala.c: Likewise.
* gettext-tools/src/x-ycp.c: Likewise.
* gettext-tools/src/xerror-handler.c: Likewise.
* gettext-tools/src/xg-arglist-callshape.c: Likewise.
* gettext-tools/src/xg-arglist-context.c: Likewise.
* gettext-tools/src/xg-arglist-parser.c: Likewise.
* gettext-tools/src/xg-check.c: Likewise.
* gettext-tools/src/xg-encoding.c: Likewise.
* gettext-tools/src/xg-message.c: Likewise.
* gettext-tools/src/xg-mixed-string.c: Likewise.
* gettext-tools/src/xgettext.c: Likewise.

Changed files

• HACKING
• gettext-runtime/src/envsubst.c
• gettext-runtime/src/escapes.h
• gettext-runtime/src/gettext.c
• gettext-runtime/src/ngettext.c
• gettext-runtime/src/printf-command.c
• gettext-runtime/src/printf_gettext.c
• gettext-runtime/src/printf_ngettext.c
• gettext-tools/src/cldr-plural-exp.c
• gettext-tools/src/cldr-plurals.c
• gettext-tools/src/file-list.c
• gettext-tools/src/filter-quote.c
• gettext-tools/src/format-awk.c
• gettext-tools/src/format-boost.c
• gettext-tools/src/format-c++-brace.c
• gettext-tools/src/format-c-parse.h
• gettext-tools/src/format-c.c
• gettext-tools/src/format-csharp.c
• gettext-tools/src/format-d.c
• gettext-tools/src/format-elisp.c
• gettext-tools/src/format-gcc-internal.c
• gettext-tools/src/format-gfc-internal.c
• gettext-tools/src/format-go.c
• gettext-tools/src/format-java-printf.c
• gettext-tools/src/format-java.c
• gettext-tools/src/format-javascript.c
• gettext-tools/src/format-kde-kuit.c
• gettext-tools/src/format-kde.c
• gettext-tools/src/format-librep.c
• gettext-tools/src/format-lisp.c
• gettext-tools/src/format-lua.c
• gettext-tools/src/format-modula2.c
• gettext-tools/src/format-ocaml.c
• gettext-tools/src/format-pascal.c
• gettext-tools/src/format-perl-brace.c
• gettext-tools/src/format-perl.c
• gettext-tools/src/format-php.c
• gettext-tools/src/format-python-brace.c
• gettext-tools/src/format-python.c
• gettext-tools/src/format-qt-plural.c
• gettext-tools/src/format-qt.c
• gettext-tools/src/format-ruby.c
• gettext-tools/src/format-rust.c
• gettext-tools/src/format-scheme.c
• gettext-tools/src/format-sh-printf.c
• gettext-tools/src/format-sh.c
• gettext-tools/src/format-smalltalk.c
• gettext-tools/src/format-tcl.c
• gettext-tools/src/format.c
• gettext-tools/src/hostname.c
• gettext-tools/src/if-error.c
• gettext-tools/src/its.c
• gettext-tools/src/locating-rules.c
• gettext-tools/src/message.c
• gettext-tools/src/msgattrib.c
• gettext-tools/src/msgcat.c
• gettext-tools/src/msgcmp.c
• gettext-tools/src/msgcomm.c
• gettext-tools/src/msgconv.c
• gettext-tools/src/msgen.c
• gettext-tools/src/msgexec.c
• gettext-tools/src/msgfilter.c
• gettext-tools/src/msgfmt.c
• gettext-tools/src/msggrep.c
• gettext-tools/src/msginit.c
• gettext-tools/src/msgl-ascii.c
• gettext-tools/src/msgl-cat.c
• gettext-tools/src/msgl-charset.c
• gettext-tools/src/msgl-check.c
• gettext-tools/src/msgl-english.c
• gettext-tools/src/msgl-equal.c
• gettext-tools/src/msgl-fsearch.c
• gettext-tools/src/msgl-header.c
• gettext-tools/src/msgl-iconv.c
• gettext-tools/src/msgl-merge.c
• gettext-tools/src/msgl-ofn.c
• gettext-tools/src/msgmerge.c
• gettext-tools/src/msgunfmt.c
• gettext-tools/src/msguniq.c
• gettext-tools/src/open-catalog.c
• gettext-tools/src/plural-count.c
• gettext-tools/src/po-charset.c
• gettext-tools/src/po-time.c
• gettext-tools/src/read-catalog-abstract.c
• gettext-tools/src/read-catalog-file.c
• gettext-tools/src/read-catalog-special.c
• gettext-tools/src/read-catalog.c
• gettext-tools/src/read-csharp.c
• gettext-tools/src/read-desktop.c
• gettext-tools/src/read-java.c
• gettext-tools/src/read-mo.c
• gettext-tools/src/read-po-lex.c
• gettext-tools/src/read-properties.c
• gettext-tools/src/read-resources.c
• gettext-tools/src/read-stringtable.c
• gettext-tools/src/read-tcl.c
• gettext-tools/src/recode-sr-latin.c
• gettext-tools/src/search-path.c
• gettext-tools/src/str-list.c
• gettext-tools/src/urlget.c
• gettext-tools/src/write-catalog.c
• gettext-tools/src/write-csharp.c
• gettext-tools/src/write-desktop.c
• gettext-tools/src/write-java.c
• gettext-tools/src/write-mo.c
• gettext-tools/src/write-po.c
• gettext-tools/src/write-properties.c
• gettext-tools/src/write-qt.c
• gettext-tools/src/write-resources.c
• gettext-tools/src/write-stringtable.c
• gettext-tools/src/write-tcl.c
• gettext-tools/src/write-xml.c
• gettext-tools/src/x-awk.c
• gettext-tools/src/x-c.c
• gettext-tools/src/x-csharp.c
• gettext-tools/src/x-d.c
• gettext-tools/src/x-desktop.c
• gettext-tools/src/x-elisp.c
• gettext-tools/src/x-go.c
• gettext-tools/src/x-java.c
• gettext-tools/src/x-javascript.c
• gettext-tools/src/x-librep.c
• gettext-tools/src/x-lisp.c
• gettext-tools/src/x-lua.c
• gettext-tools/src/x-modula2.c
• gettext-tools/src/x-ocaml.c
• gettext-tools/src/x-perl.c
• gettext-tools/src/x-php.c
• gettext-tools/src/x-po.c
• gettext-tools/src/x-python.c
• gettext-tools/src/x-rst.c
• gettext-tools/src/x-ruby.c
• gettext-tools/src/x-rust.c
• gettext-tools/src/x-scheme.c
• gettext-tools/src/x-sh.c
• gettext-tools/src/x-smalltalk.c
• gettext-tools/src/x-tcl.c
• gettext-tools/src/x-typescript-impl.h
• gettext-tools/src/x-vala.c
• gettext-tools/src/x-ycp.c
• gettext-tools/src/xerror-handler.c
• gettext-tools/src/xg-arglist-callshape.c
• gettext-tools/src/xg-arglist-context.c
• gettext-tools/src/xg-arglist-parser.c
• gettext-tools/src/xg-check.c
• gettext-tools/src/xg-encoding.c
• gettext-tools/src/xg-message.c
• gettext-tools/src/xg-mixed-string.c
• gettext-tools/src/xgettext.c
• gnulib-local/lib/addext.c
• gnulib-local/lib/backupfile.c
• gnulib-local/lib/gettext.h
• gnulib-local/lib/markup.c
• gnulib-local/lib/xerror.c
• libtextstyle/gnulib-local/lib/file-ostream.oo.c
• libtextstyle/gnulib-local/lib/html-ostream.oo.c
• libtextstyle/gnulib-local/lib/html-styled-ostream.oo.c
• libtextstyle/gnulib-local/lib/iconv-ostream.oo.c
• libtextstyle/gnulib-local/lib/memory-ostream.oo.c
• libtextstyle/gnulib-local/lib/noop-styled-ostream.oo.c
• libtextstyle/gnulib-local/lib/ostream.oo.c
• libtextstyle/gnulib-local/lib/term-ostream.oo.c
• libtextstyle/gnulib-local/lib/term-styled-ostream.oo.c
• libtextstyle/lib/color.c
• libtextstyle/lib/misc.c