Change #247888

Comments

lib: refactor the type of funcs which have useless return and checks
Some internal functions always return CURLE_OK.

- Curl_http_proxy_get_destination() does that from bb4032a, (2 years
  ago) And the original inline code does not need to check the status.

- Curl_wildcard_init() does that from e60fe20. (8 years ago)

- Curl_initinfo() does that from a very beginning.

- Curl_pgrsSetDownloadCounter() did not have a return before 914e49b,
  ad051e1 recovered its content (2 years ago) but did not completely
  recovered the changes related to it.

- auth_digest_get_qop_values() does that from 676de7f.

This directly changes their type to void and cleaned the remaining
checks for their return value.

Closes #19386

Changed files

• lib/cf-h2-proxy.c
• lib/ftplistparser.c
• lib/ftplistparser.h
• lib/getinfo.c
• lib/getinfo.h
• lib/http_proxy.c
• lib/http_proxy.h
• lib/progress.c
• lib/progress.h
• lib/sendf.c
• lib/telnet.c
• lib/transfer.c
• lib/vauth/digest.c