Builder wget-solaris10-i386 Build #457

Results:

Failed shell_2 shell_3

SourceStamp:

BuildSlave:

Reason:

The SingleBranchScheduler scheduler named 'schedule-wget-solaris10-i386' triggered this build

Steps and Logfiles:

1. git update ( 2 secs )
   1. stdio
2. shell 'bash bootstrap' ( 3 mins, 21 secs )
   1. stdio
3. shell_1 './configure' ( 1 mins, 3 secs )
   1. stdio
   2. src/config.h
   3. config.log
4. shell_2 'gmake' failed ( 49 secs )
   1. stdio
5. shell_3 'gmake check' failed ( 13 secs )
   1. stdio
   2. tests-unit-tests.log
   3. tests-test-suite.log
   4. testenv-test-suite.log

Build Properties:

Forced Build Properties:

Responsible Users:

1. Nils

   nilsohnoyoudont@nilsand.re
2. Tim Rühsen

   tim.ruehsenohnoyoudont@gmx.de

Timing:

All Changes:

:

1. Change #125799

   Category	wget
   Changed by	Tim Rühsen <tim.ruehsenohnoyoudont@gmx.de>
   Changed at	Thu 15 Apr 2021 20:56:27
   Repository	https://gitlab.com/gnuwget/wget.git
   Project	wget
   Branch	master
   Revision	11c626efc45194e88f9d1b308beef976e8187547

   Comments

   * configure.ac: Add AM_GNU_GETTEXT_VERSION

   Changed files

   • configure.ac

2. Change #125800

   Category	wget
   Changed by	Nils <nilsohnoyoudont@nilsand.re>
   Changed at	Thu 15 Apr 2021 21:02:28
   Repository	https://gitlab.com/gnuwget/wget.git
   Project	wget
   Branch	master
   Revision	f1cccd2c454fb416e75a22b358b0a11266642007

   Comments

   Print message for no-follow attribute only if norobots respected
   * src/html-url.c (get_urls_html_fm): Remove misleading log message.
   * src/recur.c (retrieve_tree): Add log message into correct if block.
   
   Commit e39be3283836b8cb7b9ee320456eefb2a2fda173 added a message that
   said links will not be followed whenever the nofollow attribute is found
   in a page. It didn't take into account that with -e robots=off (and
   equivalents) links will still be followed.
   
   This bug has been noticed multiple times:
   * https://www.reddit.com/r/DataHoarder/comments/mprq89/wget_respects_nofollow_attribute_despite_e/
   * https://gist.github.com/simonw/27e810771137408fd7834ad153750c41#gistcomment-3648191
   * https://superuser.com/questions/1494761/wget-wont-ignore-no-follow-attributes
   
   This commits makes it so that this message is only printed when a
   nofollow link is found and the norobots convention is respected.
   
   Copyright-paperwork-exempt: Yes

   Changed files

   • src/html-url.c
   • src/recur.c

3. Change #125801

   Category	wget
   Changed by	Nils <nilsohnoyoudont@nilsand.re>
   Changed at	Thu 15 Apr 2021 21:03:56
   Repository	https://gitlab.com/gnuwget/wget.git
   Project	wget
   Branch	master
   Revision	1aada296dde933228bb1820cbf3ff1fc09a4eee5

   Comments

   Use "nofollow" instead of "no-follow" in messages
   * src/html-url.c (get_urls_html_fm): Remove misleading debug message.
   * src/recur.c (retrieve_tree): Fix no-follow -> follow in DEBUGP.
   
   The attribute in html is "nofollow" so it is more consistent to call it
   so than to hyphenate it.
   
   Copyright-paperwork-exempt: Yes

   Changed files

   • src/html-url.c
   • src/recur.c