Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Builder rsyslog-solaris10-i386 Build #1776

Results:

Failed

SourceStamp:

Projectrsyslog
Repositoryhttps://github.com/rsyslog/rsyslog.git
Branchmaster
Revision5222c21a3fd36b929bbbf29b8d21be2053766c6c
Changes3 changes

BuildSlave:

unstable10x

Reason:

The SingleBranchScheduler scheduler named 'schedule-rsyslog-solaris10-i386' triggered this build

Steps and Logfiles:

  1. git updating ( 1 mins, 2 secs )
    1. stdio
  2. shell  
    1. - no logs -
  3. shell_1  
    1. - no logs -
  4. shell_2  
    1. - no logs -
  5. shell_3  
    1. - no logs -

Build Properties:

NameValueSource
branch master Build
builddir /export/home/buildbot/slave/rsyslog-solaris10-i386 slave
buildername rsyslog-solaris10-i386 Builder
buildnumber 1776 Build
codebase Build
project rsyslog Build
repository https://github.com/rsyslog/rsyslog.git Build
revision 5222c21a3fd36b929bbbf29b8d21be2053766c6c Build
scheduler schedule-rsyslog-solaris10-i386 Scheduler
slavename unstable10x BuildSlave
workdir /export/home/buildbot/slave/rsyslog-solaris10-i386 slave (deprecated)

Forced Build Properties:

NameLabelValue

Responsible Users:

  1. Rainer Gerhards

Timing:

StartThu Sep 28 15:08:23 2023
EndThu Sep 28 15:09:26 2023
Elapsed1 mins, 2 secs

All Changes:

:

  1. Change #180980

    Category rsyslog
    Changed by Rainer Gerhards <rgerhardsohnoyoudont@adiscon.com>
    Changed at Thu 28 Sep 2023 14:11:31
    Repository https://github.com/rsyslog/rsyslog.git
    Project rsyslog
    Branch master
    Revision 144cc03d90293cc09c4c100dd941226b421709e2

    Comments

    fix startup issue on modern systemd systems
    When we startup AND are told to auto-background ourselfs, we must
    close all unneeded file descriptors. Not doing this has some
    security implications. Traditionally, we do this by iterating
    over all possible file descriptor values. This is fairly compatible,
    because we need no OS-specific method. However, modern systemd configs
    tend to not limit the number of fds, so there are potentially 2^30(*)
    fds to close. While this is OKish, it takes some time and makes
    systemd think that rsyslog did not properly start up.
    
    We have now solved this by using the /proc filesystem to obtain our
    currently open fds. This works for Linux, as well as Cygwin, NetBSD,
    FreeBDS and MacOS. Where not available,and close_range() is available
    on the (build) platform, we try to use it. If that fails as well, we
    fall back to the traditional method. In our opionion, this fallback
    is unproblematic, as on these platforms there is no systemd and in
    almost all cases a decent number of fds to close.
    
    Very special thanks go out to Brennan Kinney, who clearly described
    the issue to us on github and also provided ample ways to solve it.
    What we did is just implement what we think is the best fit from
    rsyslog's PoV.
    
    (*) Some details below on the number of potentially to close fds.
        This is directly from a github posting from Brennan Kinney.
    Just to clarify, by default since systemd v240 (2018Q4), that
    should be `1024:524288` limit. As in the soft limit is the expected
    `1024`.
    
    The problem is other software shipping misconfiguration in systemd
    services that overrides this to something silly like
    `LimitNOFILE=infinity`.
    - Which will map to the sysctl `fs.nr_open` (_a value systemd
      v240 also raises from `2^20` to 2^30`, some distro like Debian are
      known to opt-out via patch for the `fs.nr_open` change_).
    - With the biggest issue there being that the soft limit was also
      set to `infinity` instead of their software requesting to raise
      the soft limit to a higher value that the hard limit permits.
      `infinity` isn't at all sane though.
    - The known source of this misconfiguration is container software such
      as Docker and `containerd` (_which would often sync with the
      systemd `.service` config from the Docker daemon `dockerd.service`_).
    
    closes https://github.com/rsyslog/rsyslog/issues/5158

    Changed files

    • configure.ac
    • tools/rsyslogd.c
  2. Change #180981

    Category rsyslog
    Changed by Rainer Gerhards <rgerhardsohnoyoudont@adiscon.com>
    Changed at Thu 28 Sep 2023 15:01:29
    Repository https://github.com/rsyslog/rsyslog.git
    Project rsyslog
    Branch master
    Revision 2fc5da5502c1741b274c43db3c14026935287fdc

    Comments

    Merge pull request #5230 from rgerhards/i5158
    fix startup issue on modern systemd systems

    Changed files

    • no files
  3. Change #180982

    Category rsyslog
    Changed by Rainer Gerhards <rgerhardsohnoyoudont@adiscon.com>
    Changed at Thu 28 Sep 2023 15:05:26
    Repository https://github.com/rsyslog/rsyslog.git
    Project rsyslog
    Branch master
    Revision 5222c21a3fd36b929bbbf29b8d21be2053766c6c

    Comments

    maintain ChangeLog

    Changed files

    • ChangeLog