Builder rrdtool_gcc-solaris10-i386 Build #69

Results:

Failed shell_2

SourceStamp:

BuildSlave:

Reason:

scheduler

Steps and Logfiles:

1. git update ( 11 secs )
   1. stdio
2. shell './configure' ( 50 secs )
   1. stdio
3. shell_1 'gmake' ( 1 mins, 52 secs )
   1. stdio
4. shell_2 'gmake check' failed ( 51 secs )
   1. stdio
   2. test-suite.log
5. shell_3 '/opt/csw/bin/gcc -DTEST_SNPRINTF ...' ( 0 secs )
   1. stdio
6. shell_4 'src/rrd_snprintf' ( 0 secs )
   1. stdio

Build Properties:

Forced Build Properties:

Responsible Users:

1. Sebastian Schmidt

   yathohnoyoudont@yath.de
2. Tobias Oetiker

   tobiohnoyoudont@oetiker.ch

Timing:

All Changes:

:

1. Change #17560

   Category	rrdtool
   Changed by	Sebastian Schmidt <yathohnoyoudont@yath.de>
   Changed at	Mon 19 Oct 2015 15:48:50
   Repository	https://github.com/oetiker/rrdtool-1.x.git
   Project	rrdtool
   Branch	1.5
   Revision	0c3e8dbd6a3be9736d87ac64cf82956c2a5fd62e

   Comments

   Don't crash on invalid variable names in RPN
   When rpn_parse() finds [^\0,] after parsing a token, it returns NULL
   without setting an error. This causes rrd_test_error() to return false
   and subsequent code will dereference NULL (cf. rrdtool xport
   CDEF:foo=foo-bar).
   
   This commit changes the OP_VARIABLE branch in rpn_parse so that in order
   to be a variable name, sscanf needs to match the full name, causing a
   more meaningful "ERROR: don't understand 'illegal-variable-name'" error
   message in that case. Also, I made the return NULL branch set an error
   message so rrd_test_error() will succeed.

   Changed files

   • src/rrd_rpncalc.c

2. Change #17561

   Category	rrdtool
   Changed by	Tobias Oetiker <tobiohnoyoudont@oetiker.ch>
   Changed at	Tue 20 Oct 2015 10:43:29
   Repository	https://github.com/oetiker/rrdtool-1.x.git
   Project	rrdtool
   Branch	1.5
   Revision	5b4eac6c774027933d85400297f0f15a5c191dd4

   Comments

   Merge pull request #677 from yath/1.5-rpnparse-null
   Don't crash on invalid variable names in RPN

   Changed files

   • no files