Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Builder protobuf-solaris10-i386 Build #2321

Results:

Failed shell_3

SourceStamp:

Projectprotobuf
Repositoryhttps://github.com/google/protobuf.git
Branchmaster
Revision46c3651c315cf77f1bcf5ad662074f04f095a04a
Got Revision46c3651c315cf77f1bcf5ad662074f04f095a04a
Changes1 change

BuildSlave:

unstable10x

Reason:

The SingleBranchScheduler scheduler named 'schedule-protobuf-solaris10-i386' triggered this build

Steps and Logfiles:

  1. git update ( 2 secs )
    1. stdio
  2. shell 'bash ./autogen.sh' ( 26 secs )
    1. stdio
  3. shell_1 './configure' ( 15 secs )
    1. stdio
  4. shell_2 'gmake all' ( 15 mins, 19 secs )
    1. stdio
  5. shell_3 'gmake check' failed ( 0 secs )
    1. stdio
    2. test-suite.log

Build Properties:

NameValueSource
branch master Build
builddir /export/home/buildbot/slave/protobuf-solaris10-i386 slave
buildername protobuf-solaris10-i386 Builder
buildnumber 2321 Build
codebase Build
got_revision 46c3651c315cf77f1bcf5ad662074f04f095a04a Git
project protobuf Build
repository https://github.com/google/protobuf.git Build
revision 46c3651c315cf77f1bcf5ad662074f04f095a04a Build
scheduler schedule-protobuf-solaris10-i386 Scheduler
slavename unstable10x BuildSlave
workdir /export/home/buildbot/slave/protobuf-solaris10-i386 slave (deprecated)

Forced Build Properties:

NameLabelValue

Responsible Users:

  1. amirhadadi

Timing:

StartFri Mar 18 18:35:55 2022
EndFri Mar 18 18:52:00 2022
Elapsed16 mins, 4 secs

All Changes:

:

  1. Change #148587

    Category protobuf
    Changed by amirhadadi <amirhadadiohnoyoudont@hotmail.com>
    Changed at Fri 18 Mar 2022 18:28:17
    Repository https://github.com/google/protobuf.git
    Project protobuf
    Branch master
    Revision 46c3651c315cf77f1bcf5ad662074f04f095a04a

    Comments

    Implement Utf8.decodeUtf8 by using String constructor (#9415)
    * Implement Utf8.decodeUtf8 by using String constructor and a search for the replacement string "\uFFFD". This greatly simplifies the implementation, speeds it up for ascii and saves in memory allocations for non ascii strings.
    
    * Remove irrelevant comment about indexOf.
    
    * Code style changes following review.
    
    * Remove TODO + remove final per google style.
    
    * Delete decodeUtf8 from UnsafeProcessor as it inherits the intended implementation from its parent.
    
    * Move decodeUtf8 implementation from Utf8::Processor to Utf8 since it has only a single implementation which is independent of whether the processor is safe or unsafe.
    
    * Change only the logic of UnsafeProcessor to use String constructor
    This is done since some Android versions will see a performance regression if this change is applied.
    So we are making this change only for UnsafeProcessor which is not used on Android.
    
    * Remove duplicated Javadoc
    
    Co-authored-by: ahadadi <ahadadi@outbrain.com>

    Changed files

    • java/core/src/main/java/com/google/protobuf/Utf8.java