Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Builder memcached-solaris10-amd64 Build #311

Results:

Failed shell_2 shell_3

SourceStamp:

Projectmemcached
Repositorygit://github.com/memcached/memcached.git
Branchnext
Revision186834a6d6c0302e2bdae00a608f3f16deb09cf7
Got Revision186834a6d6c0302e2bdae00a608f3f16deb09cf7
Changes13 changes

BuildSlave:

unstable10x

Reason:

The SingleBranchScheduler scheduler named 'schedule-memcached-solaris10-amd64' triggered this build

Steps and Logfiles:

  1. git update ( 2 secs )
    1. stdio
  2. shell 'bash autogen.sh' ( 3 secs )
    1. stdio
  3. shell_1 './configure --enable-sasl ...' ( 6 secs )
    1. stdio
    2. config.log
  4. shell_2 'gmake' failed ( 1 secs )
    1. stdio
  5. shell_3 'gmake test' failed ( 1 secs )
    1. stdio

Build Properties:

NameValueSource
branch next Build
builddir /export/home/buildbot/slave/memcached-solaris10-amd64 slave
buildername memcached-solaris10-amd64 Builder
buildnumber 311 Build
codebase Build
got_revision 186834a6d6c0302e2bdae00a608f3f16deb09cf7 Git
project memcached Build
repository git://github.com/memcached/memcached.git Build
revision 186834a6d6c0302e2bdae00a608f3f16deb09cf7 Build
scheduler schedule-memcached-solaris10-amd64 Scheduler
slavename unstable10x BuildSlave
workdir /export/home/buildbot/slave/memcached-solaris10-amd64 slave (deprecated)

Forced Build Properties:

NameLabelValue

Responsible Users:

  1. dormando

Timing:

StartWed Feb 9 05:52:16 2022
EndWed Feb 9 05:52:32 2022
Elapsed16 secs

All Changes:

:

  1. Change #147128

    Category memcached
    Changed by dormando <dormandoohnoyoudont@rydia.net>
    Changed at Fri 04 Feb 2022 22:56:25
    Repository git://github.com/memcached/memcached.git
    Project memcached
    Branch next
    Revision 795462d86a452c90672fe279c7e7bb97026350ac

    Comments

    proxy: audit TODO/FIXME lines. mark some for v2
Marks TODO/FIXME items that can be done after MVP/V1 status is achieved.

"v2" just means "after v1". Not at all tied to a specific version or any
order.

This cuts us down from 170 items to... 80...

    Changed files

    • proto_proxy.c

  2. Change #147130

    Category memcached
    Changed by dormando <dormandoohnoyoudont@rydia.net>
    Changed at Fri 04 Feb 2022 22:56:25
    Repository git://github.com/memcached/memcached.git
    Project memcached
    Branch next
    Revision 57b1d833d72e04c2c78d9916c3be339b9616d303

    Comments

    proxy: FIXME/TODO audit of missing error handling
- check eventfd error.
- error on missing 'mcp_config_pools' function in config file.
- note lua throws top level errors on malloc failures from
  lua_newuserdatauv

    Changed files

    • proto_proxy.c

  3. Change #147132

    Category memcached
    Changed by dormando <dormandoohnoyoudont@rydia.net>
    Changed at Fri 04 Feb 2022 22:56:25
    Repository git://github.com/memcached/memcached.git
    Project memcached
    Branch next
    Revision ef7541abd519cc1b8a7adbea41a642832636c6f3

    Comments

    proxy: improve mcp_config_* VM table copying
The configuration reloader copies data between the "config" global VM
and individual worker VM's. This fixes some crashes/limitations and
improves error handling. It still has a sharp edge as the actual table
copy is unhandled.

    Changed files

    • proto_proxy.c
    • t/startfile.lua

  4. Change #147134

    Category memcached
    Changed by dormando <dormandoohnoyoudont@rydia.net>
    Changed at Fri 04 Feb 2022 22:56:25
    Repository git://github.com/memcached/memcached.git
    Project memcached
    Branch next
    Revision f352f0e062abb2ac957829352a429076d6e30d2d

    Comments

    proxy: fix re-assembly bug if \r missing
proxy does actually accept requests with "\n" and not "\r\n", so this
parser could've read past the end of the input buffer.

adding the end token to the parser would fix this better though.

    Changed files

    • proto_proxy.c

  5. Change #147136

    Category memcached
    Changed by dormando <dormandoohnoyoudont@rydia.net>
    Changed at Fri 04 Feb 2022 22:56:25
    Repository git://github.com/memcached/memcached.git
    Project memcached
    Branch next
    Revision 838fda3fdacfd16511c24c5638b8e2de49224c39

    Comments

    proxy: fix bug/crash for set commands
if a conn goes to sleep while reading set data from the network its
coroutine would be lost, and crash/corruption on next resume.

this now properly handles lifetime/cleanup of the coroutine.

    Changed files

    • memcached.c
    • memcached.h
    • proto_proxy.c
    • proto_proxy.h

  6. Change #147138

    Category memcached
    Changed by dormando <dormandoohnoyoudont@rydia.net>
    Changed at Fri 04 Feb 2022 22:56:25
    Repository git://github.com/memcached/memcached.git
    Project memcached
    Branch next
    Revision 3614f3cf495e1e2b25afde8d4e2e3c0c30bd0dac

    Comments

    proxy: add mcp.backend_failure_limit(n)
refactors the timeouts management code to be generic "tunables" and adds
the backend limit as a configuration option.

    Changed files

    • proto_proxy.c

  7. Change #147140

    Category memcached
    Changed by dormando <dormandoohnoyoudont@rydia.net>
    Changed at Fri 04 Feb 2022 22:56:25
    Repository git://github.com/memcached/memcached.git
    Project memcached
    Branch next
    Revision 245cf4c0f9d44e3891d12bc3dbf368a1b28e8627

    Comments

    proxy: counter for backend failures
think this ony counts failues related to the connect routine, and when a
backend is considered dead. Looks like I was partway through deciding
how to change that.

I'm sure it's possible for something to fail in such a way that it
connects, then immediately fails, which escapes this routine. Separate
fix for that though.

    Changed files

    • proto_proxy.c

  8. Change #147142

    Category memcached
    Changed by dormando <dormandoohnoyoudont@rydia.net>
    Changed at Fri 04 Feb 2022 22:56:25
    Repository git://github.com/memcached/memcached.git
    Project memcached
    Branch next
    Revision 26750755c18c51626173a9be6549b3725d10b41e

    Comments

    proxy: small misc fixes

    Changed files

    • proto_proxy.c

  9. Change #147144

    Category memcached
    Changed by dormando <dormandoohnoyoudont@rydia.net>
    Changed at Fri 04 Feb 2022 23:39:31
    Repository git://github.com/memcached/memcached.git
    Project memcached
    Branch next
    Revision 8da2e098e3e649712170275a7629474311118752

    Comments

    proxy: improve error handling for ascii multigets
Limited on what we can do to fully emulate the original daemon behavior,
so we end up inlining error messages. Hopefully clients can discern as
they should be looking for ^VALUE anyway.

Also removes an error message I added for blank responses. Apparently
multiget is what I had that path for, heh!

    Changed files

    • proto_proxy.c

  10. Change #147146

    Category memcached
    Changed by dormando <dormandoohnoyoudont@rydia.net>
    Changed at Sat 05 Feb 2022 01:56:46
    Repository git://github.com/memcached/memcached.git
    Project memcached
    Branch next
    Revision b6fd865985dd8285bd963dfd429d7f475d54d77f

    Comments

    proxy: more misc fixes
- fixes potential memory leaks if an error is generated while creating a
  pool object.
- misc comment updates and error handling.
- avoid crash if attempting to route commands that don't have a key.

    Changed files

    • memcached.c
    • memcached.h
    • proto_proxy.c

  11. Change #147148

    Category memcached
    Changed by dormando <dormandoohnoyoudont@rydia.net>
    Changed at Tue 08 Feb 2022 06:25:40
    Repository git://github.com/memcached/memcached.git
    Project memcached
    Branch next
    Revision 4b781973608a8f31fff314340759af936c518cd2

    Comments

    proxy: add filter and hash options to mcp.pool()
two builtin filter options (hash stop and tag), because why not :)

hash defaults caused some code reorganization. default hash dist is now
jump, because I can't think of why you'd use modulus over that.

    Changed files

    • proto_proxy.c
    • t/startfile.lua

  12. Change #147150

    Category memcached
    Changed by dormando <dormandoohnoyoudont@rydia.net>
    Changed at Wed 09 Feb 2022 03:18:13
    Repository git://github.com/memcached/memcached.git
    Project memcached
    Branch next
    Revision 2cb5f95ceea7e29b1d1eaa7dc6a66becbf1c7fe1

    Comments

    proxy: accept fractional time for timeouts
the uring bits make abstraction this to the obvious common function a
little harder, so I skipped for now.

    Changed files

    • proto_proxy.c
    • t/startfile.lua

  13. Change #147152

    Category memcached
    Changed by dormando <dormandoohnoyoudont@rydia.net>
    Changed at Wed 09 Feb 2022 04:28:00
    Repository git://github.com/memcached/memcached.git
    Project memcached
    Branch next
    Revision 186834a6d6c0302e2bdae00a608f3f16deb09cf7

    Comments

    proxy: even more TODO/FIXME cleanups
a couple punts as well. Added malloc checking for hot paths but
deferring for uncommon paths that were a bit harder.

Also hardens the request parser from some underflows/overflows.

    Changed files

    • proto_proxy.c
BuildBot (0.8.14) working for the OpenCSW Buildbot project.
Page built: Sat 08 Nov 2025 21:36:55 (CET)