Builder libpcap-solaris10-i386 Build #3162
Results:
Build successful
SourceStamp:
Project | libpcap |
Repository | https://git.tcpdump.org/libpcap |
Branch | master |
Revision | 9442f391f7d6c391f1219121a8843ad3797b26cd |
Got Revision | 9442f391f7d6c391f1219121a8843ad3797b26cd |
Changes | 40 changes |
BuildSlave:
unstable10xReason:
The SingleBranchScheduler scheduler named 'schedule-libpcap-solaris10-i386' triggered this build
Steps and Logfiles:
-
git update ( 17 secs )
-
shell Set developer mode ( 0 secs )
-
shell_1 './autogen.sh' ( 11 secs )
-
shell_2 './configure' ( 1 mins, 44 secs )
-
shell_3 'gmake' ( 38 secs )
-
shell_4 'gmake check' ( 12 mins, 35 secs )
-
shell_5 'rm -rf ...' ( 0 secs )
-
shell_6 'gmake install ...' ( 5 secs )
-
trigger triggered trigger-tcpdump-solaris10-i386 ( 8 mins, 14 secs )
- - no logs -
- tcpdump-solaris10-i386 #5893
Build Properties:
Name | Value | Source |
---|---|---|
branch | master | Build |
builddir | /export/home/buildbot/slave/libpcap-solaris10-i386 | slave |
buildername | libpcap-solaris10-i386 | Builder |
buildnumber | 3162 | Build |
codebase | Build | |
got_revision | 9442f391f7d6c391f1219121a8843ad3797b26cd | Git |
project | libpcap | Build |
repository | https://git.tcpdump.org/libpcap | Build |
revision | 9442f391f7d6c391f1219121a8843ad3797b26cd | Build |
scheduler | schedule-libpcap-solaris10-i386 | Scheduler |
slavename | unstable10x | BuildSlave |
workdir | /export/home/buildbot/slave/libpcap-solaris10-i386 | slave (deprecated) |
Forced Build Properties:
Name | Label | Value |
---|
Responsible Users:
- Denis Ovsienkodenis@ovsienko.info
- Francois-Xavier Le Baildevel.fx.lebail@orange.fr
- Guy Harrisgharris@sonic.net
- набnabijaczleweli@nabijaczleweli.xyz
Timing:
Start | Sat Oct 18 10:53:11 2025 |
End | Sat Oct 18 11:17:01 2025 |
Elapsed | 23 mins, 49 secs |
All Changes:
:
Change #244668
Category libpcap Changed by Francois-Xavier Le Bail <devel.fx.lebail @orange.fr>Changed at Sun 14 Sep 2025 20:55:26 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision b79f887ac9f429436c1b24cf234d5870062cb886 Comments
Avoid non-ASCII characters UTF-8 left single quotation mark -> straight quote ('). UTF-8 right single quotation mark -> straight quote ('). [skip ci]
Changed files
- testprogs/TESTlib.pm
Change #244672
Category libpcap Changed by наб <nabijaczleweli @nabijaczleweli.xyz>Changed at Tue 16 Sep 2025 08:09:16 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 91c707ad18146d01fd9b545a2184dd9b00642454 Comments
Define ETHERTYPE_{SLOW,LLDP} and accept them in pcap_nametoeproto() Linux says #define ETH_P_SLOW 0x8809 /* Slow Protocol. See 802.3ad 43B */ #define ETH_P_LLDP 0x88CC /* Link Layer Discovery Protocol */ SLOW carries IEEE 802.3 LACP, both defined in annex 57A of 802.3-2018: https://ieeexplore.ieee.org/stamp/stamp.jsp?tp=&arnumber=8457469 and LLDP is defined in sexion 79 of the same.
Changed files
- ethertype.h
- nametoaddr.c
Change #244677
Category libpcap Changed by Francois-Xavier Le Bail <devel.fx.lebail @orange.fr>Changed at Tue 16 Sep 2025 13:39:39 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 6d852c375726655c98b8f38b635f6eb18dff07d2 Comments
Remove definition of ETHERTYPE_PUP 1. Unused. 2. IANA states: Formerly XEROX PUP. Invalid as an Ethertype since 1983. (https://www.iana.org/assignments/ieee-802-numbers/ieee-802-numbers.xhtml) [skip ci]
Changed files
- ethertype.h
Change #244687
Category libpcap Changed by Francois-Xavier Le Bail <devel.fx.lebail @orange.fr>Changed at Tue 16 Sep 2025 13:54:57 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 733bc53c4ebe212294b55cbe8c9084afdf7f4385 Comments
Remove definition of ETHERTYPE_SPRITE 1. Unused. 2. Unknown to IANA.
Changed files
- ethertype.h
Change #244699
Category libpcap Changed by Francois-Xavier Le Bail <devel.fx.lebail @orange.fr>Changed at Tue 16 Sep 2025 18:10:41 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 98ec8d34efa6fe5f86e3915613a115b59d17efb6 Comments
Remove definition of ETHERTYPE_TRAIL Never used. [skip ci]
Changed files
- ethertype.h
Change #244706
Category libpcap Changed by Francois-Xavier Le Bail <devel.fx.lebail @orange.fr>Changed at Tue 16 Sep 2025 18:26:35 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 797ede675d1f3c4a011073fa5d3bfa8ef65e9d48 Comments
Remove some ETHERTYPE_* definitions It is a follow-up to commit e902b3e97418c4b11caa07f71d0deae8a5e726de. [skip ci]
Changed files
- ethertype.h
Change #244716
Category libpcap Changed by наб <nabijaczleweli @nabijaczleweli.xyz>Changed at Wed 17 Sep 2025 23:17:54 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 0f4db638fa36b6b9f6c6300cb8ebb0ecc45e8a5e Comments
Document slow and lldp in pcap-filter
Changed files
- pcap-filter.manmisc.in
Change #244724
Category libpcap Changed by Guy Harris <gharris @sonic.net>Changed at Wed 17 Sep 2025 23:56:32 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 56fbeb87e60818a98368f0c2f04bec796935e0bd Comments
pcap-filter: indicate what named link-layer protocols are. Add a list of protocol names for "ether proto" that gives a short description of each protocol. That renders a subsequent list of descrptions of some DEC protocols below redundant; remove it.
Changed files
- pcap-filter.manmisc.in
Change #244735
Category libpcap Changed by Francois-Xavier Le Bail <devel.fx.lebail @orange.fr>Changed at Fri 19 Sep 2025 16:50:39 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 5fc0c261918ae56e1f58fd9e02beb5123aec7fd9 Comments
pcap-filter: Indicate that lldp and slow are not keywords [skip ci]
Changed files
- pcap-filter.manmisc.in
Change #244744
Category libpcap Changed by Francois-Xavier Le Bail <devel.fx.lebail @orange.fr>Changed at Tue 23 Sep 2025 09:59:26 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 19fd783f1c296b0f2e3311811bf868a0bea59bdc Comments
pcap-filter: Fix a typo [skip ci]
Changed files
- pcap-filter.manmisc.in
Change #244752
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Thu 25 Sep 2025 14:17:42 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 9fb3149d496d5aa992586843f45d573592fd3020 Comments
TESTrun: Add reject tests for bare "loopback".
Changed files
- testprogs/TESTrun
Change #244760
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Thu 25 Sep 2025 14:21:39 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 4eb3466b7dbb4fc2a23d4e1e7546b68cb78cd3b2 Comments
Add man fixups and tests for "lldp" and "slow". [skip ci]
Changed files
- pcap-filter.manmisc.in
- testprogs/TESTrun
Change #244773
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Mon 29 Sep 2025 23:51:00 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 26310dbd5eb900437bccd75604ba122ae4ab1df0 Comments
pcap-filter(7): Refine the protocol names summary. [skip ci] Clarify the preamble: do not say which protocol names are not a keyword because there is the table just below to do exactly that, give one definition of an ID instead of two, split the long paragraph into three. For the table columns that are specific to keywords or IDs prefix the names with "K/" and "ID/" respectively to structure the summary better.
Changed files
- pcap-filter.manmisc.in
Change #244782
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Tue 30 Sep 2025 02:26:57 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 9de85e5be8258f7b4f136869cad21e8058fd7b42 Comments
TESTrun: Fix the comments for "lldp" and "slow".
Changed files
- testprogs/TESTrun
Change #244790
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Tue 30 Sep 2025 02:33:11 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 7d2729ad54e0d839b60b605a1014d4ca55afeba8 Comments
testprogs: Rename a Perl function for clarity.
Changed files
- testprogs/TESTlib.pm
- testprogs/TESTrun
Change #244802
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Tue 30 Sep 2025 03:10:33 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision a1225ec1bfbf2459a215774d90f6596489d31d73 Comments
TESTrun: Get SKF_AD_VLAN_TAG_PRESENT right. [skip appveyor] As discussed in GH#1554, HAVE_DECL_SKF_AD_VLAN_TAG_PRESENT appears in config.h only when pcap-linux.c needs to be compiled, which is a subset of all cases when the OS is Linux. Specifically, "--with-pcap=null" is one of the cases that do not define HAVE_DECL_SKF_AD_VLAN_TAG_PRESENT. At the same time, skip_config_have_decl() expects the given macro to be defined and breaks. Redo the affected skip conditions to use the recently renamed skip_config_not_def1() instead and to disregard the OS altogether. Delete the now unused skip_config_have_decl().
Changed files
- testprogs/TESTlib.pm
- testprogs/TESTrun
Change #244809
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Tue 30 Sep 2025 22:20:25 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision bec1ea2fc2888766dd41c61817d0b7ca517138c3 Comments
TESTrun: Factor a few error strings out to functions.
Changed files
- testprogs/TESTrun
Change #244819
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Tue 30 Sep 2025 22:20:25 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 7a7709117977a3a55d6db8ad457218f401fdf75b Comments
Note which port number checks are redundant. [skip ci]
Changed files
- gencode.c
Change #244828
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Sat 04 Oct 2025 15:55:54 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 8c6546fbd6669f362a24a82c210df41bcf2524c3 Comments
TESTrun: Rename a "gateway" reject test for clarity.
Changed files
- testprogs/TESTrun
Change #244837
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Sat 04 Oct 2025 16:22:55 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision aadc8f71e465dda6dda72a1691024ceb2325b9ee Comments
Fix some spelling.
Changed files
- pcap-filter.manmisc.in
- testprogs/TESTrun
Change #244846
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Sun 05 Oct 2025 12:34:42 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision ced0e875c22be4e66094729176def8580db75486 Comments
Remove all instances of the "register" specifier. Same as in tcpdump.
Changed files
- bpf_filter.c
- etherent.c
- fad-gifc.c
- fad-glifc.c
- gencode.c
- nametoaddr.c
- optimize.c
- pcap-bpf.c
- pcap-dag.c
- pcap-dlpi.c
- pcap-linux.c
- pcap-netfilter-linux.c
- pcap-npf.c
- pcap.c
- savefile.c
- sf-pcap.c
- testprogs/capturetest.c
- testprogs/filtertest.c
- testprogs/opentest.c
- testprogs/selpolltest.c
- testprogs/threadsignaltest.c
- testprogs/valgrindtest.c
- testprogs/writecaptest.c
Change #244857
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Mon 06 Oct 2025 18:41:33 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 0f18f5b0ad18234bfba4dedee9ad7092f8a2c08d Comments
TESTrun: Factor more error strings out to functions.
Changed files
- testprogs/TESTrun
Change #244862
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Tue 07 Oct 2025 12:39:21 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 7f96dd6ad5131bcef5545a139e565371bb6b452d Comments
Update a few stale comments. Show gen_mac48host_byname() in the code path. The comments about pcap_ether_hostton() do not apply since commit ad56fa2.
Changed files
- testprogs/TESTrun
Change #244869
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Tue 07 Oct 2025 12:40:39 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 6663367d9790ca08b376311f363bcaa2ef94ddae Comments
TESTrun: Improve Q_GATEWAY coverage in gen_scode(). For all MAC-48 DLTs generalise two existing EN10MB tests and introduce three more tests to cover all six varieties of ID that "gateway" rejects. For all other DLTs introduce five more tests to cover all eight varieties of ID that "gateway" rejects and run all tests in one foreach loop.
Changed files
- testprogs/TESTrun
Change #244876
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Tue 07 Oct 2025 12:40:39 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision c66122627e5e6ebdcf906876720b9ffe9f7d4a8b Comments
TESTrun: Improve Q_HOST coverage in gen_scode(). Add three new reject tests to cover more cases when a proto-qualified "host NAME" encounters a hostname that either does not resolve at all or only resolves to an address family that the protocol cannot use. Add four new reject tests to cover the current [incorrect] behaviour of "arp host NAME" and "rarp host NAME" when the hostname resolves in IPv6, regardless of whether it resolves in IPv4 (GH bug #1512). Update three existing tests for consistency and place all the tests in one place.
Changed files
- testprogs/TESTrun
Change #244883
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Tue 07 Oct 2025 12:40:39 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision f339617d70e4183995a64bc29b582d9d020c2c24 Comments
Fix "(arp|rarp) host NAME" to ignore IPv6 quietly. For these two forms of the predicate, when a hostname resolves in both IPv4 and IPv6, the IPv6 part is supposed to be irrelevant, but it causes an unexpected failure (GH bug #1512). Also, when a hostname does not resolve in IPv4 and resolves in IPv6, the error message is supposed to be correct, but it is not: $ filtertest EN10MB 'arp host eth-ipv4-ipv6.host123.libpcap.test' filtertest: 'arp' is not a valid qualifier for 'ip6 host' $ filtertest EN10MB 'rarp host eth-ipv4-ipv6.host123.libpcap.test' filtertest: 'rarp' is not a valid qualifier for 'ip6 host' $ filtertest EN10MB 'arp host eth-noipv4-ipv6.host123.libpcap.test' filtertest: 'arp' is not a valid qualifier for 'ip6 host' $ filtertest EN10MB 'rarp host eth-noipv4-ipv6.host123.libpcap.test' filtertest: 'rarp' is not a valid qualifier for 'ip6 host' In gen_scode() case Q_HOST get the IPv6 address skip condition right to fix this: $ filtertest EN10MB 'arp host eth-ipv4-ipv6.host123.libpcap.test' (000) ldh [12] (001) jeq #0x806 jt 2 jf 7 (002) ld [28] (003) jeq #0xa141e28 jt 6 jf 4 (004) ld [38] (005) jeq #0xa141e28 jt 6 jf 7 (006) ret #262144 (007) ret #0 $ filtertest EN10MB 'rarp host eth-ipv4-ipv6.host123.libpcap.test' (000) ldh [12] (001) jeq #0x8035 jt 2 jf 7 (002) ld [28] (003) jeq #0xa141e28 jt 6 jf 4 (004) ld [38] (005) jeq #0xa141e28 jt 6 jf 7 (006) ret #262144 (007) ret #0 $ filtertest EN10MB 'arp host eth-noipv4-ipv6.host123.libpcap.test' filtertest: unknown host 'eth-noipv4-ipv6.host123.libpcap.test' for specified address family $ filtertest EN10MB 'rarp host eth-noipv4-ipv6.host123.libpcap.test' filtertest: unknown host 'eth-noipv4-ipv6.host123.libpcap.test' for specified address family In pcap-filter(7) explain the address family semantics better in the description of "host NAME". Update the tests.
Changed files
- CHANGES
- gencode.c
- pcap-filter.manmisc.in
- testprogs/TESTrun
Change #244892
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Tue 07 Oct 2025 23:47:43 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 66f249110b3d92f3e56ba294cf487616954116a8 Comments
Simplify gen_gateway(). In gen_scode() case Q_GATEWAY delegate the remaining memory management and error handling downstream; now if gen_gateway() returns, it always returns a non-NULL pointer. In gen_gateway() handle all errors as early as possible; instead of testing whether ai_addr is NULL test whether ai_family is set to the AF of interest: when that's the case, ai_addr is not NULL (this is how gen_scode() implements case Q_HOST).
Changed files
- gencode.c
- testprogs/TESTrun
Change #244899
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Wed 08 Oct 2025 00:20:40 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision c64aba1f4ec2f7ab5741c04c0c8e90391ae7027b Comments
Factor get_host46_byname() out. After the previous commit much of what gen_gateway() does is the IPv4 subset of case Q_HOST in gen_scode(). Factor the common code to a new function and update various comments.
Changed files
- gencode.c
- testprogs/TESTrun
Change #244906
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Thu 09 Oct 2025 22:00:13 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 64acdea09c4ad51a608c4b0efecc44c729538c84 Comments
TESTrun: Fixup a comment.
Changed files
- testprogs/TESTrun
Change #244913
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Thu 09 Oct 2025 22:00:13 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 72370885ea68f571a77c065c283dd4ffa5a41ee8 Comments
Produce more useful error messages in gen_mcode6(). Instead of the unspecific "Mask syntax for networks only" and "invalid qualifier against IPv6 address" use a template message and quote both the qualifier and the IPv6 argument -- this way it should be easier to tell which part of a complex filter expression causes the error. Update the tests.
Changed files
- gencode.c
- testprogs/TESTrun
Change #244919
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Thu 09 Oct 2025 22:00:13 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision a9ebc72c4432b430ddddeb18e9a88504551108a2 Comments
TESTrun: Add reject tests for port_pq_to_ipproto().
Changed files
- testprogs/TESTrun
Change #244924
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Fri 10 Oct 2025 12:35:14 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 0d8bd2f67c16637c4d25d81fb24cdcebc35afce6 Comments
Fix error messages about 32-bit integer overflow. Since commit a5cac25 stoulen() takes a pointer to a string and a length of the string and uses the length to report a problem about the string. However, by that time it has already modified the length, so the error message does not match the input: $ filtertest RAW '123456789012345' filtertest: number 1234 overflows 32 bits $ filtertest RAW '12345678901234567890' filtertest: number 123456789 overflows 32 bits $ filtertest RAW '123456789012345678901234567890' filtertest: number 1234567890123456789 overflows 32 bits $ filtertest RAW '0123456701234' filtertest: number overflows 32 bits $ filtertest RAW '0x100000000' filtertest: number overflows 32 bits Consequently, if more than one number in the filter expression is out of range, it can be not immediately obvious which one it is: $ filtertest RAW '4294967296 != 4294967297' filtertest: number overflows 32 bits To fix this, in stoulen() keep a copy of the original string length and use it for the error reporting. Ibid., factor the format string out and show the base in the message. Simplify the forward declaration. Add two comments to outline the clash space between certain MAC-48 addresses and certain octal integers. Document this syntax peculiarity in the man page and add a few basic reject tests.
Changed files
- pcap-filter.manmisc.in
- scanner.l
- testprogs/TESTrun
Change #244929
Category libpcap Changed by Guy Harris <gharris @sonic.net>Changed at Fri 10 Oct 2025 21:42:39 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision a976c364c845763a1aaf725e7c30b1356b03d01a Comments
Add the size of time_t to the version string. This makes it easier to detect time_t size mismatches between libpcap and code that uses libpcap, at least with code that reports the version.
Changed files
- CHANGES
- Makefile.in
- build.sh
- pcap-bpf.c
- pcap-dag.c
- pcap-dpdk.c
- pcap-int.h
- pcap-linux.c
- pcap-npf.c
- pcap-snf.c
- testprogs/CMakeLists.txt
- testprogs/Makefile.in
- testprogs/versiontest.c
Change #244937
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Sat 11 Oct 2025 12:57:14 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 25eb0a6fc3856ccd1703aa419793e862829ad8c0 Comments
Fixup indentation in map_arphrd_to_dlt().
Changed files
- pcap-linux.c
Change #244942
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Sun 12 Oct 2025 11:37:07 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision ca885e80abb2315e802dd13c16af2499fc5c7794 Comments
In gen_ncode() say which link-layer address is the problem.
Changed files
- gencode.c
- testprogs/TESTrun
Change #244946
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Tue 14 Oct 2025 12:27:06 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 597c1f125d5b39b7add8b07cce8295000ec1b5df Comments
Fix various failures to reject invalid DECnet primitives. Even after my earlier commit 989e194 the current implementation still fails to reject some invalid forms of DECnet syntax: 'decnet net net-10-20-30-0.libpcap.test': no error 'decnet net 1.2.3.0/24': no error 'decnet net 1.2.3.0 mask 255.255.255.0': no error 'decnet net 1.2': no error Make the verification stricter to solve the remaining part of the problem: in gen_scode() and gen_mcode() handle DECnet early and reject all forms, in gen_ncode() handle DECnet early and reject all forms except "host". Improve various comments to explain the context. For a number of other "decnet" forms instead of misleading error messages (e.g., "Mask syntax for networks only") return a more useful error message: 'decnet net net-10-20-30-0.libpcap.test': 'decnet' is not a valid qualifier for 'net' 'decnet net 1.2.3.0/24': 'decnet' is not a valid qualifier for 'net' 'decnet net 1.2.3.0 mask 255.255.255.0': 'decnet' is not a valid qualifier for 'net' 'decnet net 1.2': 'decnet' is not a valid qualifier for 'net'
Changed files
- CHANGES
- gencode.c
- testprogs/TESTrun
Change #244951
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Tue 14 Oct 2025 12:30:03 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision e3ea9ae39511f93775b72ecdd33dbf998583ac83 Comments
TESTrun: Refine comments with gen_scode() code paths. Unlike gen_ncode(), gen_mcode() and gen_mcode6(), there is exactly one code path into gen_scode(), namely, through an ID in the grammar. This way, when a comment says "ID -> gen_scode()", it states the obvious, and when it says "pnum -> gen_scode()", it is wrong, so eliminate this noise to improve the signal. Add the missing gen_host46_byname() to a couple code paths.
Changed files
- testprogs/TESTrun
Change #244954
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Tue 14 Oct 2025 12:42:55 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision b29d01b9d8f4df5a78ef4a047d94c91dba3f0f55 Comments
gencode.c: Factor ERRSTR_INVALID_IPV4_ADDR out.
Changed files
- gencode.c
Change #244959
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Wed 15 Oct 2025 11:49:25 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 33574de699129ad82dcf5860ea8187a4e0939037 Comments
TESTrun: Eliminate some gaps in "host" reject tests. The existing tests could not detect the recently fixed DECnet bugs because the definitions in %pqual_features do not distinguish between different forms of the ID. Then the subsequent foreach loop that generates invalid "host" primitives does not generate any tests for protocols that support a form of "host" no matter which forms of ID are valid and which are not. Then the resulting reject tests have a number of gaps, including IPv4 IDs in DECnet primitives. To fix that, in %pqual_features replace the generic "host" with seven more specific host/net features; in the loop skip the valid permutations only and include MAC-48, ARCnet and DECnet IDs. The new test space supersedes a number of earlier reject tests, so remove these. Document the current code paths in the comments and introduce more helper functions.
Changed files
- testprogs/TESTrun
Change #244964
Category libpcap Changed by Denis Ovsienko <denis @ovsienko.info>Changed at Fri 17 Oct 2025 16:12:34 Repository https://git.tcpdump.org/libpcap Project libpcap Branch master Revision 9442f391f7d6c391f1219121a8843ad3797b26cd Comments
CHANGES: Two bug fixes have been backported to 1.10.6. [skip ci]
Changed files
- CHANGES