Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Builder libpcap-solaris10-i386 Build #3094

Results:

Build successful

SourceStamp:

Projectlibpcap
Repositoryhttps://git.tcpdump.org/libpcap
Branchmaster
Revisionc956817a339f095a72e569f68390eef61006ff0c
Got Revisionc956817a339f095a72e569f68390eef61006ff0c
Changes20 changes

BuildSlave:

unstable10x

Reason:

The SingleBranchScheduler scheduler named 'schedule-libpcap-solaris10-i386' triggered this build

Steps and Logfiles:

  1. git update ( 11 secs )
    1. stdio
  2. shell Set developer mode ( 0 secs )
    1. stdio
  3. shell_1 './autogen.sh' ( 5 secs )
    1. stdio
  4. shell_2 './configure' ( 41 secs )
    1. stdio
    2. config.log
  5. shell_3 'gmake' ( 29 secs )
    1. stdio
  6. shell_4 'rm -rf ...' ( 0 secs )
    1. stdio
  7. shell_5 'gmake install ...' ( 3 secs )
    1. stdio
  8. trigger triggered trigger-tcpdump-solaris10-i386 ( 5 mins, 21 secs )
    1. - no logs -
    2. tcpdump-solaris10-i386 #5748

Build Properties:

NameValueSource
branch master Build
builddir /export/home/buildbot/slave/libpcap-solaris10-i386 slave
buildername libpcap-solaris10-i386 Builder
buildnumber 3094 Build
codebase Build
got_revision c956817a339f095a72e569f68390eef61006ff0c Git
project libpcap Build
repository https://git.tcpdump.org/libpcap Build
revision c956817a339f095a72e569f68390eef61006ff0c Build
scheduler schedule-libpcap-solaris10-i386 Scheduler
slavename unstable10x BuildSlave
workdir /export/home/buildbot/slave/libpcap-solaris10-i386 slave (deprecated)

Forced Build Properties:

NameLabelValue

Responsible Users:

  1. Denis Ovsienko
  2. Francois-Xavier Le Bail

Timing:

StartSun Mar 16 11:13:14 2025
EndSun Mar 16 11:20:07 2025
Elapsed6 mins, 53 secs

All Changes:

:

  1. Change #223029

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Mon 24 Feb 2025 17:00:09
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision b4c0af559f440bd67b794783ff692033992cadda

    Comments

    Fix a typo in gencode.c.

    Changed files

    • gencode.c

  2. Change #223030

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Mon 24 Feb 2025 17:00:54
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 1e34010e89db0198d441685569c8d800ab8ac84f

    Comments

    Use __func__ in optimize.c.

    Changed files

    • optimize.c

  3. Change #223032

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Tue 25 Feb 2025 20:14:37
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 42ab30161767d0c1f3cf649b90170d1890b257c6

    Comments

    TESTrun: Refine the generation of apply test requests.
Add a check for the "skip" key, as is done for the other test types (the
next changes are going to require that).  Assign a variable before a
loop, not within.

    Changed files

    • testprogs/TESTrun

  4. Change #223034

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Tue 25 Feb 2025 21:24:23
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision d68b8052e762a9b74559d31e86d065a80892a348

    Comments

    TESTrun: Add filter tests for ARP, IPv4, IPv6 and RARP.
rarp_req_reply.pcapng comes from the Wireshark sample captures,
isakmp4500.pcap, pim-packet-assortment.pcap and vrrp.pcap come from
tcpdump tests.

    Changed files

    • testprogs/TESTrun
    • tests/filter/isakmp4500.pcap
    • tests/filter/pim-packet-assortment.pcap
    • tests/filter/rarp_req_reply.pcapng
    • tests/filter/vrrp.pcap

  5. Change #223036

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Tue 25 Feb 2025 21:26:31
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 2559282f3db683e03cd29d30ab5947d6e14a6500

    Comments

    Generate cleaner code for "host", "net" and "gateway".
Following the same logic as for DECnet in commit 6f8a28c earlier, take
the link-layer protocol value out of any recursion gen_hostop() and
gen_hostop6() might do, instead just call gen_linktype() beforehand
exactly once.  In gen_host6() join two equivalent cases together for
clarity.

For ARP-capable DLTs this improves SNR in the unoptimized filter
programs of:

* "arp (host|net)"
* "ip (host|net)"
* "ip6 (host|net)"
* "rarp (host|net)"
* "(host|net)" (which is a logical OR of the above four)
* "arp gateway" (which is a superset of "not arp host")
* "ip gateway" (which is a superset of "not ip host")
* "rarp gateway" (which is a superset of "not rarp host")
* "gateway" (which is a logical OR of the above three)

For DLTs with a relatively simple structure this change makes the
unoptimized filter program for most of the above primitives the same as
the optimized one.  For IEEE 802.11 and ARCnet there is now fewer
instructions and less work to do for the optimizer.

    Changed files

    • gencode.c
    • testprogs/TESTrun

  6. Change #223324

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Wed 26 Feb 2025 15:16:45
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 66941d599aa6e93754f10dd9404715aaa345ac5b

    Comments

    TESTrun: Add apply filter tests for DLT_SLIP.
Capture the current behaviour of "inbound" and "outbound" applied to
Rx, Tx and invalid packet direction.  Note how "outbound" matches a
packet with an invalid direction value (0xE7).  The .pcap files come
from tcpdump tests.

    Changed files

    • testprogs/TESTrun
    • tests/filter/slip-bad-direction.pcap
    • tests/filter/slip-compressed_sl_print-oobr.pcap
    • tests/filter/slip-sliplink_print-oobr.pcap

  7. Change #223325

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Thu 27 Feb 2025 21:34:08
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 127435bf8c1e3eb08166a6004b74d638e5afd4fb

    Comments

    Have "outbound" mean Tx only for DLT_SLIP.
In DLT_SLIP packet direction is the first and the only byte of the
link-layer header, so it ought to be trivial to test, which the
optimized filter program seems to implement:

$ ./testprogs/filtertest SLIP outbound
(000) ldb      [0]
(001) jeq      #0x0             jt 2	jf 3
(002) ret      #0
(003) ret      #262144

However, the C code in gen_inbound_outbound() looks more complicated
than the above requires: since libpcap 0.0 (June 1994) it has been a
combination of four functions, and the unoptimized filter program it
produces looks more complicated than it needs to be:

$ ./testprogs/filtertest -O SLIP outbound
(000) ld       #0x0
(001) st       M[1]
(002) ldx      M[1]
(003) ldb      [x + 0]
(004) st       M[2]
(005) ld       #0x0
(006) st       M[0]
(007) ldx      M[0]
(008) ld       M[2]
(009) sub      x
(010) jeq      #0x0             jt 11	jf 12
(011) ret      #0
(012) ret      #262144

The C code means loading 1 byte from offset 0 of the link-layer header,
testing it to be equal to 0 and reversing the result if testing for
"outbound".  The test for "inbound" correctly matches direction value 0
(received packets).  The test for "outbound" matches direction value 1
(transmitted packets), as well as any other non-zero direction value,
which is invalid in DLT_SLIP.

Replace the custom code with gen_cmp() consistently with the other cases
in the same switch block.  This makes the unoptimized and the optimized
filter programs identical, also fixes "outbound" to match Tx packets
only.  Update the affected filter tests to reflect these developments.

    Changed files

    • CHANGES
    • gencode.c
    • testprogs/TESTrun

  8. Change #223326

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Thu 27 Feb 2025 21:34:37
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision ca63110cee408812bec55d322ed500cdb3f4e58b

    Comments

    pcap-filter(7): Refine qualifiers and primitives.
In the introduction mention that an ID is not limited to a name or a
number, add "proto" to the list of type qualifiers and give an example,
mention that a proto qualifier and the "proto" type qualifier are not
the same, add more entries to the list of valid protocols, give more
examples, say that "proto" implies "ip or ip6" and "net" also implies
"ip6".

Ibid., add a paragraph to explain how the qualifiers combine (or not) in
the regular primitive syntax; in IEEE 802.11 header particulars remove
the comment about RA and TA because the current implementation does in
fact support these, remove the comment about BSSID because the list of
"wlan" primitives represents what is supported, everything else is not.
Ibid., add ARP/RARP header particulars, rearrange a couple paragraphs
to discuss one thing at a time and provide a few more examples of the
irregular primitive syntax.

For each of the primitives below merge "dst", "src" and "src or dst"
forms into one section using a uniform style and in each section give a
complete list of valid qualifiers and related details:
* "host HOSTNAMEADDR"
* "ether host ETHERNAMEADDR"
* "net NETNAMEADDR"
* "net NETADDR mask NETMASK"
* "net NETADDR/LEN"
* "port PORTNAMENUM"
* "portrange PORTNAMENUM1-PORTNAMENUM2"
* "decnet HOST"
* "link HOST" with regard to ARCnet

Update "gateway HOST" along the same lines to make it clear it matches
ARP and RARP too by default.  For "ether host ETHERNAMEADDR", "ether
broadcast" and "ether multicast" mention that Ethernet is not the only
supported network type.  For "net NETNAMEADDR" spell the CIDR notation
of every netmask.  Ibid., add a reference to "net NETADDR/LEN".  Idem
for "net NETADDR mask NETMASK", also discuss the argument syntax and
clarify that the netmask can be any 32-bit value.  For "portrange" make
it clear that the two values can be in any order and may be equal.  Add
a note about ARP and RARP to the "bugs" section.

    Changed files

    • CHANGES
    • pcap-filter.manmisc.in

  9. Change #223340

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Fri 28 Feb 2025 01:25:26
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 732df312d1d30b4e4f235c628cbff78ef7f3434a

    Comments

    TESTrun: Add missing NO_PROTOCHAIN skips. [skip ci]
Discovered by Francois-Xavier.

    Changed files

    • testprogs/TESTrun

  10. Change #224418

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Sun 09 Mar 2025 15:02:20
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 4f9dbed5e1cd362327cff692b096a142e28ea3e2

    Comments

    pcap-filter(7): Refine more prose and formatting. [skip ci]
Split the main section into six.  Fix "net NETNAMEADDR".  Move known MTP
issues to the BUGS section.  Refine the definition of an arithmetic
expression.  Say "packet data accessors" instead of "index operation"
more often and clarify the syntax.  Clarify that compound expression
syntax includes relations.  Update the "most recent keyword" example to
convey the point better.

    Changed files

    • pcap-filter.manmisc.in

  11. Change #224479

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Sun 09 Mar 2025 15:45:48
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision f901282007f8b8638a44d1db660f11ffc3ea3a6b

    Comments

    Comment buffer sizes better in pcap_nametoproto().

    Changed files

    • nametoaddr.c

  12. Change #224480

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Sun 09 Mar 2025 16:03:53
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 798e270e9d3bd8ad47e080fa8650ea3a074c386e

    Comments

    Use gen_cmp_le() directly where it fits.
The opposite of "greater than" is "less or equal".  Update two comments
to spell the edge case right (it is either > ETHERMTU or <= ETHERMTU).
This generates exactly the same filter program, hence there is no change
to the tests.

    Changed files

    • gencode.c

  13. Change #224481

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Mon 10 Mar 2025 01:07:31
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 343af1f44428998a398c0c6792b93cec1f1cd1ec

    Comments

    Fixup some SocketCAN comments in pcap-linux.c. [skip ci]

    Changed files

    • pcap-linux.c

  14. Change #224726

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Mon 10 Mar 2025 13:26:15
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 2afd5f27b4402ab0c915a33cf0045d94408ba0c2

    Comments

    Filter SocketCAN frames in userland if necessary.
On Linux little-endian hosts the first four bytes of a SocketCAN frame
are the opposite byte order at the kernel side of the socket, so a
filter program that accesses any of these bytes needs either to account
for the byte order difference (if possible) or to run in userland.
Implement this logic in fix_dlt_can_socketcan() and call it from
fix_program() if necessary.  See also GitHub bug report #1247.

    Changed files

    • CHANGES
    • pcap-linux.c

  15. Change #224727

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Tue 11 Mar 2025 19:44:48
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision a479709897b1f0df08ef7b586ab8557c7d18f94e

    Comments

    man: Document devices, interfaces and "any" better.
In pcap_create(3PCAP) and pcap_open_live(3PCAP) spell device/interface
and replace an explanation of the difference with a reference to
pcap_findalldevs(3PCAP).

In the latter man page remove the text that used to say "does not have
sufficient privileges... those devices will not appear" since libpcap
1.1.1 because it does not seem to match even what old libpcap versions
implemented (e.g. skip only if IFF_UP is not set in fad-gifc.c).  Add a
paragraph to explain the difference between listing devices and
activating a device in the current implementation.  Explain that a
capture device is a generic case of a network interface and how the
"any" pseudo-interface relates with network interfaces.  Show that a
device name can be used with pcap_create() too.

This resolves GitHub bug report #1055.

    Changed files

    • CHANGES
    • pcap_create.3pcap
    • pcap_findalldevs.3pcap
    • pcap_open_live.3pcap

  16. Change #224728

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Tue 11 Mar 2025 19:45:03
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision c4b4113befa5d01fbe3143e3ace639129d03f85d

    Comments

    TESTrun: Add a few more reject tests.

    Changed files

    • testprogs/TESTrun

  17. Change #224931

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Wed 12 Mar 2025 22:16:05
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision f8aec9d4397f23239eb383716100f26fa39e580a

    Comments

    TESTrun: Require all test labels to be unique.

    Changed files

    • testprogs/TESTlib.pm

  18. Change #224932

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Thu 13 Mar 2025 18:56:33
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision c892ee642a7098975ac66a7ec0bbaed021fc43f5

    Comments

    TESTrun: Convert test definitions from HoH to AoH.
The following is valid Perl code (although Python implements the same
semantics for its dictionaries too):

my %h = (key1 => 1, key1 => 2);

The problem here is, if the developer makes a mistake and uses the same
key to define more than one test, neither Perl interpreter nor the
duplicate label check will report an error, and at least one test will
be a silent no-op.  Make the test name a key of the second-level hash,
convert the top-level hashes into arrays, add checks for "name" in the
hash and do not sort tests within the three groups anymore -- just use
the order of the arrays.

    Changed files

    • testprogs/TESTrun

  19. Change #225055

    Category libpcap
    Changed by Francois-Xavier Le Bail <devel.fx.lebailohnoyoudont@orange.fr>
    Changed at Fri 14 Mar 2025 23:31:01
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision c3d6a8a13ece1b2a46c42f845050627ca29f2f34

    Comments

    Autoconf: Use AC_SYS_YEAR2038_RECOMMENDED when possible
On Linux, if Autoconf version >= 2.72 and GNU C Library version >= 2.34,
s/AC_SYS_LARGEFILE/AC_SYS_YEAR2038_RECOMMENDED/ to ensure time_t
is Y2038-safe.

    Changed files

    • autogen.sh

  20. Change #225064

    Category libpcap
    Changed by Francois-Xavier Le Bail <devel.fx.lebailohnoyoudont@orange.fr>
    Changed at Sat 15 Mar 2025 13:57:41
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision c956817a339f095a72e569f68390eef61006ff0c

    Comments

    Autoconf: Update autogen.sh to fix run on Solaris
Solaris /bin/sh before 11 does not support the $() command substitution
syntax.

The error was:
./autogen.sh: syntax error at line 31: `GLIBC_VERSION=$' unexpected

    Changed files

    • autogen.sh
BuildBot (0.8.14) working for the OpenCSW Buildbot project.
Page built: Mon 28 Apr 2025 17:25:57 (CEST)