Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Builder libpcap-solaris10-amd64 Build #3112

Results:

Build successful

SourceStamp:

Projectlibpcap
Repositoryhttps://git.tcpdump.org/libpcap
Branchmaster
Revisionae640ba658b26bde8857c52edbeb41328b170465
Got Revisionae640ba658b26bde8857c52edbeb41328b170465
Changes28 changes

BuildSlave:

unstable10x

Reason:

The SingleBranchScheduler scheduler named 'schedule-libpcap-solaris10-amd64' triggered this build

Steps and Logfiles:

  1. git update ( 7 secs )
    1. stdio
  2. shell Set developer mode ( 0 secs )
    1. stdio
  3. shell_1 './autogen.sh' ( 17 secs )
    1. stdio
  4. shell_2 './configure' ( 2 mins, 58 secs )
    1. stdio
    2. config.log
  5. shell_3 'gmake' ( 52 secs )
    1. stdio
  6. shell_4 'rm -rf ...' ( 0 secs )
    1. stdio
  7. shell_5 'gmake install ...' ( 13 secs )
    1. stdio
  8. trigger triggered trigger-tcpdump-solaris10-amd64 ( 15 mins, 31 secs )
    1. - no logs -
    2. tcpdump-solaris10-amd64 #5841

Build Properties:

NameValueSource
branch master Build
builddir /export/home/buildbot/slave/libpcap-solaris10-amd64 slave
buildername libpcap-solaris10-amd64 Builder
buildnumber 3112 Build
codebase Build
got_revision ae640ba658b26bde8857c52edbeb41328b170465 Git
project libpcap Build
repository https://git.tcpdump.org/libpcap Build
revision ae640ba658b26bde8857c52edbeb41328b170465 Build
scheduler schedule-libpcap-solaris10-amd64 Scheduler
slavename unstable10x BuildSlave
workdir /export/home/buildbot/slave/libpcap-solaris10-amd64 slave (deprecated)

Forced Build Properties:

NameLabelValue

Responsible Users:

  1. Denis Ovsienko

Timing:

StartFri Mar 28 14:59:21 2025
EndFri Mar 28 15:19:23 2025
Elapsed20 mins, 1 secs

All Changes:

:

  1. Change #225581

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Fri 21 Mar 2025 13:14:51
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 5f8382bb9c6ffbceae33efd05a58a92a32307b00

    Comments

    Make pcap_compile() error messages more uniform and consistent.
In the grammar say "qualifier" rather than "modifier" to match the prose
in pcap-filter(7) better (this reduces the terminology inconsistency
described in GitHub bug report #125), also spell IPv4/IPv6 for clarity.

    Changed files

    • CHANGES
    • grammar.y.in
    • testprogs/TESTrun

  2. Change #225586

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Sat 22 Mar 2025 16:46:33
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 879c3738ce3ee3f542e6f744ff0b8d479480e6a6

    Comments

    Simplify various error reporting.
In gen_linktype() instead of many bpf_error() calls and hard-coded
messages have one catch-all call at the end with one parametrised
message; move the DLT description to the end of the message.  In
gen_proto_abbrev_internal() have one catch-all call at the end with one
parametrised message.  In gen_load_internal() include the keyword in the
error message.

    Changed files

    • gencode.c

  3. Change #225592

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Sat 22 Mar 2025 16:46:50
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision c26a0aa6709490e1670edb3f0f7f2572c9f38031

    Comments

    Factor fail_kw_on_dlt() out.
Replace seven hard-coded error messages with one parametrised message.

    Changed files

    • gencode.c
    • testprogs/TESTrun

  4. Change #225599

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Sat 22 Mar 2025 16:46:50
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 9d6ee64bc2a51922de44341c815705a6462c6b94

    Comments

    Factor assert_pflog() out.
Deduplicate the code, replace six hard-coded error messages with one
parametrised message and spell the DLT name correctly.

    Changed files

    • gencode.c

  5. Change #225611

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Sat 22 Mar 2025 16:46:50
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 53db7fe35f46539241422b6a0866d5a7f772e2b3

    Comments

    Parametrise IEEE 802.11 syntax error messages.
Add helper functions to convert a dir qualifier number to string, define
a format string and replace 48 hard-coded messages with one parametrised
message.

    Changed files

    • gencode.c

  6. Change #225615

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Sat 22 Mar 2025 16:46:50
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision c1cba0f9454c8f88b77f7b6e39ef56ca3af52146

    Comments

    Parametrise invalid qualifier error messages.
Add a helper function to convert a protocol qualifier number to string,
define a format string and replace 123 hard-coded proto and dir
qualifier error messages with one parametrised message.  In the message
say "qualifier" rather than "modifier".

    Changed files

    • gencode.c
    • testprogs/TESTrun

  7. Change #225619

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Sat 22 Mar 2025 17:17:16
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision ae87d369ed5bbc93ead23305996857f4148848e8

    Comments

    Factor assert_atm() out.
Add another helper function for ATM keywords, replace 13 hard-coded
error messages with one parametrised message and spell the DLT name
correctly.

    Changed files

    • gencode.c

  8. Change #225624

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Sat 22 Mar 2025 18:20:20
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 1bebaa7e59b600601e34c8ab32c328cfd086f614

    Comments

    Factor assert_ss7() out.
Add another helper function for SS7 keywords, replace 10 hard-coded
error messages with one parametrised message and converge the check
conditions.

    Changed files

    • gencode.c
    • testprogs/TESTrun

  9. Change #225629

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Sat 22 Mar 2025 18:20:20
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 51c3abb6cf380292f8e03d3bd1bd348f5a10a2bd

    Comments

    Factor assert_maxval() out.
For ATM, GENEVE, MPLS, MTP, PPPoE, VLAN and VXLAN keywords replace 11
checks and the hard-coded error messages with a function and one
parametrised message.

    Changed files

    • gencode.c
    • testprogs/TESTrun

  10. Change #225633

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Sat 22 Mar 2025 18:20:21
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 8e3c9607a6257791ae4f1261c6f6ae8eb4e2962e

    Comments

    Factor port_pq_to_ipproto() out.
Replace four validation/mapping blocks with a function and one
parametrised message.

    Changed files

    • gencode.c

  11. Change #225637

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Sat 22 Mar 2025 18:20:21
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision e1592834ed59a7cbb988f7aa590f33c4223d7b3f

    Comments

    pcap-filter(7): Get proto-dir-type and other things right.
As discussed in GitHub issue #125, describe the kinds of qualifiers in
the same order as they appear in a regular primitive (proto-dir-type),
not the opposite way around.  Add missing parentheses, refine the "host
HOSTNAMEADDR" primitive description, mention ATM LANE where applicable,
add a note to the "lane" primitive description, call PFLOG aliases
"primitives" rather than "modifiers".

    Changed files

    • pcap-filter.manmisc.in

  12. Change #225641

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Sun 23 Mar 2025 21:42:43
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision dac2395ed3bb27d8cd1f275e49335076d698dd59

    Comments

    Add/remove some comments.

    Changed files

    • gencode.c
    • grammar.y.in

  13. Change #225645

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Sun 23 Mar 2025 21:53:16
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision c86dd4eff62e61f2f96bdb603a49aafcdc5893df

    Comments

    TESTrun: Add more filter tests.
Add undocumented accept alises for IS-IS primitives and /128 IPv6 CIDR
prefixes in an address context.  Add many reject tests to exercise
various code paths that end up in bpf_error().

    Changed files

    • testprogs/TESTrun

  14. Change #225649

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Sun 23 Mar 2025 21:53:32
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 98232604d3a3e79e91797fb53eda5d6d12a3fcf2

    Comments

    Lose the no-op dir qualifier in gen_gateway() and gen_proto().
The grammar defines "gateway" and "proto" without a dir qualifier, so an
attempt to use one is an early syntax error, so in every invocation of
these two functions dir == Q_DEFAULT and respecive checks are dead code.
For gen_protochain() this has already been done in commit 81d760f.

    Changed files

    • gencode.c

  15. Change #225653

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Mon 24 Mar 2025 21:04:21
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 46a01a2446fcb6e15f84f8b06ea0336d95bcc593

    Comments

    pcap-filter(7): Document protocol names better. [skip ci]
Add a table with a summary of all valid protocol names and related
usage.  Add a description for "isis proto NUM".  List "isis", "ppp" and
"slip" as valid proto qualifier cases, list "protochain" and "gateway"
as valid type qualifier cases, list "link", "ppp" and "slip" as valid
link-level aliases, remove "gateway" and "wlan" from the examples of
irregular primitives.  In the lists of qualifiers try to put the most
frequently used first.  When mentioning irregular primitives, remember
to say "relation" because arithmetic expressions evaluate to an integer,
not a Boolean.

    Changed files

    • pcap-filter.manmisc.in

  16. Change #225657

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Tue 25 Mar 2025 17:57:10
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 3fc5eded542c2b1b2df6faa5150128b7da827eb9

    Comments

    pcap-filter(7): Document PFLOG keywords better.
Spell DLT_PFLOG; for "reason CODE" and "action ACT" have the code point
lists match the current implementation.

    Changed files

    • pcap-filter.manmisc.in

  17. Change #225664

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Tue 25 Mar 2025 17:58:04
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 62f8a39524012fbeaefb23421ab95cda4acbadba

    Comments

    TESTrun: Add filter tests for PFLOG.

    Changed files

    • testprogs/TESTrun

  18. Change #225670

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Wed 26 Mar 2025 14:00:23
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision ebad08bada1edb6d36d6816f95394f180f8e707f

    Comments

    Require "(iso|isis) proto" values to be within valid ranges.

    Changed files

    • CHANGES
    • gencode.c
    • testprogs/TESTrun

  19. Change #225675

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Wed 26 Mar 2025 14:00:23
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision e525d0dfb11fb8c4be4d4be055de3776db8d543e

    Comments

    TESTrun: Add more filter tests for ISO and IS-IS.
Transcribe the current implementation, especially regarding DLT_C_HDLC.
The .pcap files come from tcpdump tests.

    Changed files

    • testprogs/TESTrun
    • tests/filter/ISIS_external_lsp.pcap
    • tests/filter/ISIS_p2p_adjacency.pcap

  20. Change #225678

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Wed 26 Mar 2025 14:00:23
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 9fe209c9f782c183db3849dd95f9ea0c34e5649d

    Comments

    Use the correct IS-IS PDU type offset for DLT_C_HDLC.
The very first octet of an IS-IS PDU header is "Intradomain Routeing
Protocol Discriminator".  The default case in gen_proto() reads it from
offset 0 of the link-layer payload for most DLTs and from offset 1 for
DLT_C_HDLC, which works as expected.  However, the Q_ISIS case always
uses the same offset, so IS-IS PDU type keywords fail to match packets
correctly for DLT_C_HDLC.  Copy the workaround from Q_ISO to address
that and update the tests.

    Changed files

    • CHANGES
    • gencode.c
    • testprogs/TESTrun

  21. Change #225682

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Wed 26 Mar 2025 14:00:23
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 63acfbbf1ed5a4132273778f00596f7b7539b3f4

    Comments

    Use the correct bit mask for IS-IS PDU type value.
The IS-IS PDU Type field is an unsigned integer in the least significant
5 bits, and the most significant three bits are reserved, therefore when
"isis proto" tests the field value, it must use a bit mask to ignore the
reserved bits.  This notably inflates the filter program because the
optimizer currently detects no-op duplicate loads, but does not detect
no-op duplicate (ld, and) pairs.  The apply tests do not change because
they have packets with the reserved bits set to zero.

    Changed files

    • CHANGES
    • gencode.c
    • testprogs/TESTrun

  22. Change #225685

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Thu 27 Mar 2025 00:24:34
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 9941ee1ef992fef4160c0d726ad525ccac14cae2

    Comments

    Define max() at most once.

    Changed files

    • optimize.c
    • pcap-int.h
    • pcap-linux.c

  23. Change #225688

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Thu 27 Mar 2025 00:35:44
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 2bf1b7aff16f3f07836c10df2ffc35aa753549a8

    Comments

    Simplify "portrange" port swapping.
This generates exactly the same filter program as before.

    Changed files

    • gencode.c

  24. Change #225692

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Thu 27 Mar 2025 01:16:33
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 00c81a068cecd1ecf65c6db293478f958317c6a1

    Comments

    Treat degenerate "portrange" cases the same as "port".
"portrange N1-N2", where N1 == N2, has the same effect as "port N1", so
the filter program does not have to be different.  Coalesce the tests.

    Changed files

    • gencode.c
    • testprogs/TESTrun

  25. Change #225695

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Thu 27 Mar 2025 21:36:16
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision f9b31e8068f85b2818aafc426032ba143b8f6b4b

    Comments

    TESTrun: Add filter tests for the "byte" primitive.

    Changed files

    • testprogs/TESTrun

  26. Change #225698

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Thu 27 Mar 2025 21:37:43
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 82724cc70656f382234e525befc08d90a9b896a5

    Comments

    Fix the "|" and "&" operators of the "byte" primitive.
In gen_byteop() the "=", "<" and ">" cases load the required packet byte
into the A register implicitly via gen_load_a(), but the other two cases
need to do it explicitly, otherwise A will hold the previous value and
the ALU instruction will take that as the input.

The bug was introduced in the tcpdump 2.0 release (January 1991, before
libpcap 0.0), which replaced filter.c with gencode.c.

    Changed files

    • CHANGES
    • gencode.c
    • testprogs/TESTrun

  27. Change #225701

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Thu 27 Mar 2025 21:38:13
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision 3eeca98e1b0daba1fde1e73ba003ed84838e9862

    Comments

    Require "byte" argument value to be within range.

    Changed files

    • CHANGES
    • gencode.c
    • testprogs/TESTrun

  28. Change #225705

    Category libpcap
    Changed by Denis Ovsienko <denisohnoyoudont@ovsienko.info>
    Changed at Thu 27 Mar 2025 21:38:14
    Repository https://git.tcpdump.org/libpcap
    Project libpcap
    Branch master
    Revision ae640ba658b26bde8857c52edbeb41328b170465

    Comments

    pcap-filter(7): Document the "byte" primitive.

    Changed files

    • pcap-filter.manmisc.in
BuildBot (0.8.14) working for the OpenCSW Buildbot project.
Page built: Sat 26 Apr 2025 03:07:48 (CEST)