Builder libcheck-solaris10-i386 Build #5

Results:

Build successful

SourceStamp:

BuildSlave:

Reason:

scheduler

Steps and Logfiles:

1. svn update r1183 ( 2 secs )
   1. stdio
2. shell '/opt/csw/bin/autoreconf --install' ( 24 secs )
   1. stdio
3. shell_1 './configure' ( 15 secs )
   1. stdio
4. shell_2 'gmake' ( 33 secs )
   1. stdio
5. shell_3 'gmake check' ( 6 mins, 35 secs )
   1. stdio
   2. test-suite.log

Build Properties:

Forced Build Properties:

Responsible Users:

1. brarcher

Timing:

All Changes:

:

1. Change #3261

   Category	None
   Changed by	brarcher
   Changed at	Wed 30 Jul 2014 05:15:41
   Repository	http://svn.code.sf.net/p/check/code/trunk
   Project	libcheck
   Revision	1182

   Comments

   tests: escape % before passing string to ck_abort_msg()
   
   ch_abort_msg() expects printf arguments. Passing in a constant
   string that happens to have '%' in it will not end as expected,
   as the underlying vsnprintf will attempt to format them.
   
   As some unit tests now attempt to have improper output involving
   '%' in expressions, it is now possible that the failure message
   which is expected during Check's unit tests involve '%'. As such,
   only a properly escaped string should be passed to ck_abort_msg().
   
   This change will force the string passed to ck_abort_msg() in the
   test_check_failure_msgs unit test to properly escape any '%'
   found, so that if a failure did happen the correct text is printed
   to the screen.

   Changed files

   • tests/check_check_master.c

2. Change #3262

   Category	None
   Changed by	brarcher
   Changed at	Wed 30 Jul 2014 05:15:44
   Repository	http://svn.code.sf.net/p/check/code/trunk
   Project	libcheck
   Revision	1183

   Comments

   Do not vsnprintf expression string passed to ck_abort()
   
   If ck_abort() detects a failure, the expression which was
   evaluated is passed to _ck_assert_failed to print.
   However, the previous behavior was to send the expression
   to vsnprintf(), which would expect it to be properly formatted.
   
   If the expression in ck_abort() contained % characters, such as:
      ck_abort(bar%foo == 0)
   the "%f" portion would be printed as some non-existent floating
   point number.
   
   Now, if there is no message passed (and the expression is to
   be used) simply report the expression as is. Only format
   something with vsnprintf() if there is actual data that
   expects formatting.

   Changed files

   • NEWS
   • src/check.c
   • tests/check_check_master.c
   • tests/check_check_sub.c