Builder gtar-solaris10-sparc Build #263
Results:
Failed shell shell_1 shell_2 shell_3
SourceStamp:
Project | gtar |
Repository | git://git.savannah.gnu.org/tar.git |
Branch | master |
Revision | 04b4f491a8b3e774ab3ece194f25b23ab0095e6d |
Got Revision | 04b4f491a8b3e774ab3ece194f25b23ab0095e6d |
Changes | 62 changes |
BuildSlave:
unstable10sReason:
The SingleBranchScheduler scheduler named 'schedule-gtar-solaris10-sparc' triggered this build
Steps and Logfiles:
Build Properties:
Name | Value | Source |
---|---|---|
branch | master | Build |
builddir | /export/home/buildbot-unstable10s/slave/gtar-solaris10-sparc | slave |
buildername | gtar-solaris10-sparc | Builder |
buildnumber | 263 | Build |
codebase | Build | |
got_revision | 04b4f491a8b3e774ab3ece194f25b23ab0095e6d | Git |
project | gtar | Build |
repository | git://git.savannah.gnu.org/tar.git | Build |
revision | 04b4f491a8b3e774ab3ece194f25b23ab0095e6d | Build |
scheduler | schedule-gtar-solaris10-sparc | Scheduler |
slavename | unstable10s | BuildSlave |
workdir | /export/home/buildbot-unstable10s/slave/gtar-solaris10-sparc | slave (deprecated) |
Forced Build Properties:
Name | Label | Value |
---|
Responsible Users:
- Paul Eggerteggert@cs.ucla.edu
Timing:
Start | Sat Nov 2 08:01:43 2024 |
End | Sat Nov 2 08:02:21 2024 |
Elapsed | 38 secs |
All Changes:
:
Change #213254
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 78dd7bf0bcdd125821ce91fa8f73ec967414f76e Comments
Fewer uses of size_t in buffer.c * src/buffer.c (flush_write_ptr, flush_bufmap, bufmap_locate): (struct zip_magic, available_space_after, _flush_write) (short_read, flush_archive, try_new_volume) (gnu_add_multi_volume_header, simple_flush_read) (simple_flush_write, _gnu_flush_read, _gnu_flush_write) (gnu_flush_write): Prefer idx_t to size_t when either will do, as signed types are typically safer. For a tiny value in memory, just use ‘char’.
Changed files
- src/buffer.c
- src/common.h
Change #213255
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision f9ed22de9b0603b787e47e2f8c1220d96ad323ff Comments
Fewer uses of size_t in checkpoint.c * src/checkpoint.c (copy_string_unquote, getarg) (format_checkpoint_string): Prefer idx_t to size_t. (copy_string_unquote): Simplify by using ximemdup0. (getarg): Avoid quadratic reallocation behavior by using xpalloc.
Changed files
- src/checkpoint.c
Change #213256
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 0b602280819fbebed59651618c7e070306f7c0f4 Comments
checkpoint_total_format is now const * src/checkpoint.c (checkpoint_total_format): Now const, and local to format_checkpoint_string.
Changed files
- src/checkpoint.c
Change #213257
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 7abf1420c32b2a1d89a82e5cc4186d0d7ddd87b1 Comments
Simplify checkpoint_action allocation * src/checkpoint.c: Include <flexmember.h>. (struct checkpoint_action): New member commandbuf. (checkpoint_action_tail): Now pointer to pointer, to simplify updating. All uses changed. (alloc_action): New arg quoted_string, to lessen number of separate allocations. All uses changed.
Changed files
- src/checkpoint.c
Change #213258
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 15dc3210cc47dae5a9520d214c22d88595621661 Comments
Fewer uses of size_t in compare.c * src/compare.c (read_and_process): Prefer idx_t to size_t.
Changed files
- src/compare.c
Change #213259
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 849f244a0b56bb64b80f53ba0a82faaca8a05b8f Comments
Fewer uses of size_t in create.c * src/create.c (struct exclusion_tag, to_octal, tar_copy_str) (tar_name_copy_str, to_base256, to_chars_subst, to_chars) (gid_to_chars, major_to_chars, minor_to_chars, mode_to_chars) (off_to_chars, time_to_chars, uid_to_chars, uintmax_to_chars) (string_to_chars, start_private_header, write_gnu_long_link) (split_long_name, write_ustar_long_name, simple_finish_header) (dump_dir0, ensure_slash, create_archive): Prefer idx_t to size_t.
Changed files
- src/common.h
- src/create.c
Change #213260
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 739483114da3ec83cdb97f119de78bf96c2663ba Comments
Fewer uses of size_t in delete.c * src/delete.c (write_recent_blocks, write_recent_bytes): Prefer idx_t to size_t.
Changed files
- src/delete.c
Change #213261
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 5a00343006d71f47747e439dcc7ba0c860b818ee Comments
Fewer uses of size_t in exclist.c * src/exclist.c (hg_addfn): Prefer idx_t to size_t.
Changed files
- src/exclist.c
Change #213262
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 04b92eca49b48b21a9b4bc89b564204fa0408a8e Comments
Fewer uses of size_t in extract.c * src/extract.c (struct delayed_set_stat, struct delayed_link) (delay_set_stat, apply_nonancestor_delayed_set_stat) (extract_file): Prefer idx_t to size_t. (struct delayed_set_stat): Remove unused member xattr_map_size.
Changed files
- src/extract.c
Change #213263
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision f73c927a71b89a18c2858cd63ebfc25cda762463 Comments
Fewer uses of size_t in incremen.c * src/incremen.c (struct dumpdir, dumpdir_create0, struct dumpdir_iter) (dumpdir_next, dumpdir_size, make_directory) (dirlist_replace_prefix, rebase_directory, makedumpdir) (maketagdumpdir, append_incremental_renames, read_obstack) (read_incr_db_2, get_gnu_dumpdir, try_purge_directory) (list_dumpdir): Prefer idx_t to size_t.
Changed files
- src/common.h
- src/incremen.c
Change #213264
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision dd71d3796dd1a1a4c3936a1da44d3c22c4d3daa5 Comments
Fewer uses of size_t in list.c * src/list.c (recent_long_name_blocks, recent_long_link_blocks) (read_header, from_header, gid_from_header, major_from_header) (minor_from_header, mode_from_header, off_from_header) (time_from_header, uid_from_header, uintmax_from_header) (tartime): Prefer idx_t to size_t.
Changed files
- src/common.h
- src/list.c
Change #213265
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision b73127edc482aadbabe0b072f1b3d03c22ddd2cc Comments
Fewer uses of size_t in misc.c * src/misc.c (assign_string_n, quote_copy_string) (normalize_filename, replace_prefix, remove_any_file) (blocking_read, wd_alloc, wdcache_count, chdir_arg, chdir_do) (read_diag_details, struct namebuf, namebuf_name): Prefer idx_t to size_t.
Changed files
- src/common.h
- src/misc.c
Change #213266
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 5704e5795a637e28e26dcb2ce5a2f6ec298dc163 Comments
Fewer uses of size_t in names.c * src/names.c (name_buffer_length, read_name_from_file) (copy_name, all_names_found, add_hierarchy_to_namelist) (rebase_child_list, make_file_name, stripped_prefix_len): Prefer idx_t to size_t.
Changed files
- src/common.h
- src/names.c
Change #213267
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 9afbe6961c19d10aaba2291c2278d54207a01fc3 Comments
Pacify GCC in info_attach_exclist * src/exclist.c (info_attach_exclist): Remove unnecessary test for whether dir and ex are null. GCC complains about the first one in some cases. Use C99-style decls.
Changed files
- src/exclist.c
Change #213268
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision fae968bd2d0387497e8bd038e55110e4d9553ffa Comments
Diagnose sys_exec_info_script failures * src/system.c (sys_exec_info_script): Diagnose failures in getline, fclose. Don’t worry about freeing memory as caller will immediately exit anyway.
Changed files
- src/system.c
Change #213269
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 61a978f6d498db9151de801c88c6d01eef7bb7d9 Comments
Remove name_term It’s never actually called. * src/names.c (name_term): Remove. All uses removed.
Changed files
- src/common.h
- src/names.c
- src/tar.c
Change #213270
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision d127dac10e2316ee85d3232bc4955cba46543ded Comments
Remove xattrs_clear_setup It’s never actually called. * src/xattrs.c (clear_mask_map, xattrs_clear_setup): Remove. All uses removed.
Changed files
- src/tar.c
- src/xattrs.c
- src/xattrs.h
Change #213271
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 2ce5791124c491a9e467cd408375d6289172d08f Comments
Simplify add_hierarchy_to_namelist allocation * src/names.c (add_hierarchy_to_namelist): Use xpalloc rather than a complicated homebrew heuristic.
Changed files
- src/names.c
Change #213272
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision e5139500807f95cb64eb3d4a176fbde3a0cc8365 Comments
Simplify name_buffer initialization * src/names.c (name_init): Remove no-longer-needed initialization of name_buffer, name_buffer_length. It was confusing anyway, since it caused name_buffer_length to not equal the length of name_buffer.
Changed files
- src/names.c
Change #213273
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 7c0feaefd0355fb99a46858d2d66d42966a0f6c5 Comments
Adjust better to Gnulib signed-int read changes The 2024-08-09 Gnulib changes that caused some modules prefer signed types to size_t means that Tar should follow suit. * src/buffer.c (short_read): * src/system.c (sys_child_open_for_compress) (sys_child_open_for_uncompress): rmtread and safe_read return ptrdiff_t not idx_t; don’t rely on implementation defined conversion. * src/misc.c (blocking_read): Never return a negative number. Return idx_t, not ptrdiff_t, with the same convention for EOF and error as the new full_read. All callers changed. * src/sparse.c (sparse_dump_region, check_sparse_region) (check_data_region): * src/update.c (append_file): full_read no longer returns SAFE_READ_ERROR for I/O error; instead it returns the number of bytes successfully read, and sets errno. Adjust to this. * src/system.c (sys_child_open_for_uncompress): Rewrite to avoid need for goto and label.
Changed files
- src/buffer.c
- src/common.h
- src/compare.c
- src/create.c
- src/misc.c
- src/sparse.c
- src/system.c
- src/update.c
Change #213274
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 5f4a4164b7ed9a9d58a9cecb23973ae875d14c42 Comments
Fewer uses of size_t in sparse.c * src/sparse.c (struct tar_sparse_optab, dump_zeros) (tar_sparse_dump_region, tar_sparse_extract_region) (zero_block_p, sparse_add_map, sparse_dump_region) (sparse_extract_region, sparse_dump_file, sparse_extract_file) (check_data_region, sparse_diff_file, oldgnu_get_sparse_info) (oldgnu_store_sparse_info, oldgnu_dump_header) (star_get_sparse_info, pax_dump_header_0): Prefer idx_t to size_t.
Changed files
- src/sparse.c
Change #213275
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 317e4d6a3c834fc6209dacff73d5954b13f5338c Comments
Fewer uses of size_t in suffix.c * src/suffix.c (struct compression_suffix) (find_compression_suffix, set_compression_program_by_suffix) (strip_compression_suffix): Prefer idx_t to size_t.
Changed files
- src/suffix.c
Change #213276
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 23582f3445083a3a1830a241dd5cd51a9e8a302e Comments
Streamline compression suffix detection * src/suffix.c (struct compression_suffix): Use arrays rather than pointers that need relocation. All uses changed. (compression_suffixes): Now const. Omit trailing null entry; all uses changed. (find_compression_suffix): Simplify length calculations. No longer any need to call strlen.
Changed files
- src/suffix.c
Change #213277
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 6df7a7243409d56d7acdeb60d1a819e1012f542c Comments
Prefer idx_t to size_t in system.c * src/buffer.c (_flush_write): Return idx_t, not ssize_t, to accommodate system.c changes. All uses changed. (_gnu_flush_write): Output correct errno value after write error. Simplify multi-volume mode. * src/system.c (sys_write_archive_buffer) (sys_child_open_for_compress, sys_exec_setmtime_script): Prefer idx_t to size_t.
Changed files
- src/buffer.c
- src/common.h
- src/system.c
Change #213278
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 303ac16ec01107af6952bee4ccf0d646079a860e Comments
Prefer idx_t to size_t in tar.c * src/tar.c (strip_name_components, archive_names) (allocated_archive_names, tar_list_quoting_styles) (expand_pax_option, parse_opt): Prefer idx_t to size_t. (decode_options): Use a static word rather than going to to the bother of dynamically allocating an array. (main): Do not preallocate array. Do not call ‘free’ on a pointer that now might be to static storage.
Changed files
- src/common.h
- src/tar.c
Change #213279
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 17ad155fb29680765cec60aa2936a24386f4153d Comments
Prefer idx_t to size_t in xattrs.c * src/xattrs.c (xattr_map_free, xattr_map_add) (xheader_xattr_add, xattr_map_copy, struct xattrs_mask_map) (fixup_extra_acl_fields, xattrs_acls_cleanup, acls_get_text) (xattrs__acls_get_a, xattrs__acls_get_d, acls_one_line) (mask_map_realloc, xattrs_xattrs_get, xattrs__fd_set) (xattrs_matches_mask, xattrs_xattrs_set, xattrs_print_char) (xattrs_print): Prefer idx_t to size_t.
Changed files
- src/tar.h
- src/xattrs.c
Change #213280
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision e0f9b0fdeafcbe0a80cd22002001220d9047b5a7 Comments
Prefer idx_t to size_t in transform.c * src/transform.c (struct replace_segm, struct transform) (add_literal_segment, add_backref_segment, run_case_conv) (_single_transform_name_to_obstack): Prefer idx_t to size_t.
Changed files
- src/transform.c
Change #213281
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 08a917444403cc58313462b27a1b5d0a790f8bf7 Comments
Remove unused static vars in unlink.c * src/unlink.c (unlink_count, deferred_unlink_delay): Remove. All uses removed.
Changed files
- src/unlink.c
Change #213282
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision c61a2bee73c8012ecd90ecfab9d9e3cb3a2e0aa6 Comments
Omit unnecessary initialization in dunlink_alloc * src/unlink.c (dunlink_alloc): Remove unnecessary assignment to p->next.
Changed files
- src/unlink.c
Change #213283
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 025f19e6bdf1b4f8db536008dc6de7523f9c6607 Comments
Prefer intmax_t to size_t in xheader.c * src/common.h (INTMAX_STRSIZE_BOUND): New constant. (SYSINT_BUFSIZE): Use it. * src/xheader.c (global_header_count, xheader_format_name): Prefer intmax_t to size_t, as the values are not sizes.
Changed files
- src/common.h
- src/xheader.c
Change #213284
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 7b278044a7d26d2d62aa6a48d0dbe504cc6e9000 Comments
Prefer idx_t to size_t in xheader.c * src/xheader.c (x_obstack_grow, x_obstack_blank) (xheader_format_name, xheader_ghdr_name, xheader_write) (struct xhdr_tab, locate_handler, decode_record, decx, decg) (xheader_read, xattr_encode_keyword, xheader_print_n) (xheader_string_end, dummy_decoder, atime_decoder, gid_decoder) (gname_decoder, linkpath_decoder, ctime_decoder, mtime_decoder) (path_decoder, sparse_path_decoder, size_decoder, uid_decoder) (uname_decoder, sparse_size_decoder, sparse_numblocks_decoder) (sparse_offset_coder, sparse_offset_decoder) (sparse_numbytes_coder, sparse_numbytes_decoder) (sparse_map_decoder, dumpdir_decoder, volume_label_decoder) (volume_size_decoder, volume_offset_decoder) (volume_filename_decoder, xattr_selinux_decoder) (xattr_acls_a_decoder, xattr_acls_d_decoder, xattr_coder) (xattr_decoder, sparse_major_decoder, sparse_minor_decoder): Prefer idx_t to size_t.
Changed files
- src/xheader.c
Change #213285
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision c2ce0b7e13ce4c41c9c3a26dd037783af89e5121 Comments
Prefer idx_t to size_t in tar.h * src/tar.h (struct xheader, struct tar_stat_info): Prefer idx_t to size_t. All uses changed.
Changed files
- src/sparse.c
- src/tar.h
Change #213286
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision c0ef66da920d842bbcec6fe57bea7bc0fc22f45d Comments
Prefer idx_t to size_t in common.h * src/common.h (struct name): Prefer idx_t to size_t. (volume_label_count): Remove; unused.
Changed files
- src/common.h
Change #213287
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision d68c37b6407f265068c4335571e5be0f99e50ae6 Comments
Prefer off_t to uintmax_t for continued_file_* * src/buffer.c (continued_file_size, continued_file_offset): Now off_t, not uintmax_t. All uses changed. * src/common.h (UINTMAX_FROM_HEADER): * src/list.c (uintmax_from_header): Remove; unused. * src/list.c (simple_print_header): * src/xheader.c (volume_size_decoder, volume_offset_decoder): Treat offset as off_t, not uintmax_t.
Changed files
- src/buffer.c
- src/common.h
- src/list.c
- src/xheader.c
Change #213288
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 6f5718a35f2be669848c624e99f862b1adacda16 Comments
Check for setenv failures when running scripts * src/system.c (dec_to_env): Use umaxtostr for speed, since convenience isn’t needed here. (sys_exec_info_script, sys_exec_checkpoint_script): Check for setenv failure.
Changed files
- src/system.c
Change #213289
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 989842ff0d804aeee852cd53d541c5f5b0b7f223 Comments
Remove unnecessary casts Some of these date back to pre-C89. * src/buffer.c (backspace_output): * src/create.c (to_base256, gid_to_chars, major_to_chars) (minor_to_chars, off_to_chars, time_to_chars, uid_to_chars): * src/list.c (from_header, tartime): * src/map.c (owner_map_translate, group_map_translate): * src/system.c (sys_truncate): * src/utf8.c (utf8_init): * src/xattrs.c (acls_one_line): * src/xheader.c (xheader_string_end): Remove casts. * src/create.c (uintmax_to_chars): Remove. All uses removed. (simple_finish_header): Use to_octal.
Changed files
- src/buffer.c
- src/create.c
- src/incremen.c
- src/list.c
- src/map.c
- src/system.c
- src/tar.c
- src/utf8.c
- src/xattrs.c
- src/xheader.c
Change #213290
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision d9da9389638dca8b0a94cf2b3458084928d5e267 Comments
Prefer intmax_t for occurrence counts * src/common.h (struct name): * src/tar.c (occurrence_option, parse_opt): Use intmax_t, not uintmax_t, for occurrence counts.
Changed files
- src/common.h
- src/tar.c
Change #213291
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision a3ba452f40c5eeaab08fddf1110f6899758a432c Comments
Fewer uses of uintmax_t in xheader.c * src/tar.h (struct xheader): * src/xheader.c (xheader_string_end): Use idx_t, not uintmax_t, for string length. * src/xheader.c (xheader_string_add): Avoid duplicate calls to strlen. (xheader_string_end): Remove by-hand check for size overflow; it’s not possible, as this is measuring allocated storage.
Changed files
- src/tar.h
- src/xheader.c
Change #213292
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 2339c9106b830a3a8ba53e143dd49ecab8b18d58 Comments
Fix checkpoint_flush_actions width typo * src/checkpoint.c (checkpoint_flush_actions): long → intmax_t.
Changed files
- src/checkpoint.c
Change #213293
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 0aa69501d3d41b009ffa1be36fa718849b8a7a6e Comments
Remove major, minor signedness assumption * src/common.h (uintmax): Remove; no longer used. * src/list.c (simple_print_header): Don’t assume major and minor agree in signedness.
Changed files
- src/common.h
- src/list.c
Change #213294
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 5a7185ae314ca104c095d5a4e515189cde784e77 Comments
Prefer other types to int in tar.c Use types that are more specific than ‘int’, if that is easy. * src/tar.c (after_date_option, xattrs_option, check_links_option) (confirm, confirm_file_EOF, set_xattr_option, optloc_eq) (get_date_or_file): Prefer bool to int. (tar_list_quoting_styles, tar_set_quoting_style, parse_opt): Prefer idx_t to int. (optloc_lookup, option_set_in_cl): Prefer enum option_class to int. (decode_signal): Avoid some pointer reallocation. (sort_mode_flag, hole_detection_types, set_old_files_option) (is_subcommand_class): Prefer enum to int. (parse_opt) [DEVICE_PREFIX]: Remove unused var. Simplify creation of device name. (find_argp_option_key, find_argp_option): Prefer char to int. (enum subcommand_class): Now named. (subcommand_class): Now char, not int. (decode_options): Check for unlikely int overflow.
Changed files
- src/common.h
- src/create.c
- src/extract.c
- src/tar.c
- src/xattrs.c
Change #213295
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision a337cd35a0c461bd3c434dcf39aee29a99b35a39 Comments
Prefer other types to int in buffer.c This increases the volume number maximum from 2**31 - 1 to 2**63 - 1. * src/buffer.c (record_index, inhibit_map, new_volume): Prefer bool to int for booleans. * src/buffer.c (volno, global_volno): * src/system.c (sys_exec_info_script): Prefer intmax_t to int. * src/buffer.c (increase_volume_number): Omit by-hand check for overflow that relied on undefined behavior. (new_volume): Check for that overflow here instead, without relying on undefined behavior. (print_stats): Avoid undefined behavior if printf sums overflow, and reliably treat printf error like overflow. * src/common.h (add_printf): New inline function.
Changed files
- src/buffer.c
- src/common.h
- src/system.c
Change #213296
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 3357683933d2df86657b018d0176ce42e4148d55 Comments
Prefer other types to int in checkpoint.c * src/checkpoint.c (checkpoint_state): Now enum, not int. (tty_cleanup): Now bool, not int.
Changed files
- src/checkpoint.c
Change #213297
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 5a41310e579a951212d6f65524538e63a1fae4e7 Comments
Prefer other types to int in compare.c * src/compare.c (get_stat_data, verify_volume): Use bool for booleans. (verify_volume): Count headers with intmax_t, not int.
Changed files
- src/compare.c
Change #213298
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 967f5f52f748bdae27fe2e56d8f4653966d95a50 Comments
Pacify gcc -Wmissing-variable-declarations * src/buffer.c (start_offset): Now static.
Changed files
- src/buffer.c
Change #213299
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision bde3e8d6638c6792a33be8c5784777dc9ee62274 Comments
Prefer int to idx_t for some small sizes * src/create.c (max_octal_val, to_octal, tar_copy_str) (tar_name_copy_str, to_base256, to_chars_subst, to_chars) (gid_to_chars, major_to_chars, minor_to_chars, mode_to_chars) (off_to_chars, time_to_chars, uid_to_chars, string_to_chars) (split_long_name, write_ustar_long_name, simple_finish_header): * src/list.c (from_header, gid_from_header, major_from_header) (minor_from_header, mode_from_header, off_from_header) (time_from_header, uid_from_header): Prefer int to idx_t where either will do because the buffer sizes are known to be small, as this can be a performance win on 32-bit platforms. Also, in a few cases the values were negative, whereas idx_t is supposed to be nonnegative.
Changed files
- src/common.h
- src/create.c
- src/list.c
Change #213300
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 6e873de72757d4671608ff1da6fc6242daa8b372 Comments
Check for checkpoint string overflow It’s very unlikely, but would lead to undefined behavior. * src/checkpoint.c (format_checkpoint_string): Accept and return intmax_t, not idx_t. All callers changed. Check for integer overflow by using add_printf. If overflow occurs, don’t bother with extending width.
Changed files
- src/checkpoint.c
Change #213301
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 3b0d006830ba5f1835a84fe5c81661ff82974821 Comments
dumpdir_cmp signature * src/compare.c (dumpdir_cmp): Return char, not int.
Changed files
- src/compare.c
Change #213302
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision f8a679e942149ed29797b77266913cef6ee30f64 Comments
Be a bit more consistent about comparing to zero * src/buffer.c (xclose, archive_is_dev, close_archive) (write_fatal_details, init_volume_number) (closeout_volume_number, new_volume, try_new_volume): * src/checkpoint.c (format_checkpoint_string): * src/compare.c (process_rawdata, diff_file, diff_dumpdir): * src/create.c (create_archive, restore_parent_fd, dump_file0): * src/delete.c (delete_archive_members): * src/exclist.c (cvs_addfn): * src/extract.c (set_mode, mark_after_links, delay_set_stat) (repair_delayed_set_stat, make_directories, file_newer_p) (maybe_recoverable, apply_nonancestor_delayed_set_stat) (extract_dir, open_output_file, find_delayed_link_source) (create_placeholder_file, extract_symlink, extract_node) (extract_fifo, apply_delayed_link): * src/incremen.c (update_parent_directory, scan_directory) (read_obstack, read_incr_db_2, write_directory_file) (try_purge_directory): * src/map.c (map_read): * src/misc.c (maybe_backup_file, undo_last_backup, chdir_do) (tar_savedir): * src/names.c (handle_file_selection_option, add_file_id) (handle_option, read_next_name, add_hierarchy_to_namelist) (collect_and_sort_names): * src/system.c (run_decompress_program, dec_to_env, time_to_env) (oct_to_env, str_to_env, chr_to_env, sys_exec_setmtime_script): * src/tar.c (get_date_or_file, parse_default_options) (decode_options, main): * src/unlink.c (flush_deferred_unlinks): * src/update.c (append_file): * src/xattrs.c (xattrs__acls_set, xattrs_xattrs_set): Prefer < 0 when looking at syscalls; prefer != 0 to nothing when testing an integer in a boolean context. This is for style, not substance; for example, it’s easier to read ‘if (wordsplit (...) != WRDSE_OK) ...’ than ‘if (wordsplit (...)) ...’ if you don’t already know that wordsplit returns an enum rather than bool. * src/names.c (add_file_id, read_next_name, regex_usage_warning): * src/transform.c (parse_xform_flags): Return bool not int, possibly inverting sense so that true means OK. All callers changed. * src/tar.c (main): Report errno info if stdopen fails.
Changed files
- src/buffer.c
- src/checkpoint.c
- src/compare.c
- src/create.c
- src/delete.c
- src/exclist.c
- src/extract.c
- src/incremen.c
- src/map.c
- src/misc.c
- src/names.c
- src/system.c
- src/tar.c
- src/transform.c
- src/unlink.c
- src/update.c
- src/xattrs.c
Change #213303
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision fd401e1d299a0db4471510efe9fb0b0af81db8aa Comments
Prefer other types to int in delete.c * src/delete.c (write_record): Arg is bool, not int. All callers changed.
Changed files
- src/delete.c
Change #213304
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 112ead79312ea308e58414b74623f101b8c06f0b Comments
Prefer other types to int in extract.c * src/extract.c (fd_chmod, extract_chdir, open_output_file) (extract_file, extract_link, extract_symlink, extract_node) (extract_fifo, tar_extractor_t, pepare_to_extract): Prefer char to int for typeflag, since it’s a char. All uses changed. (fd_chmod): Use clearer code for errno. (extract_dir, extract_file, create_placeholder_file, extract_link) (extract_symlink, extract_node, extract_fifo, tar_extractor_t): Return bool true for success, false for failure. All uses changed. (open_output_file): Prefer bool for boolean. (prepare_to_extract): Simplify by returning the extractor a null pointer, rather than storing through a pointer to an extractor.
Changed files
- src/extract.c
Change #213305
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 7eb4dbaff1aa5335da3b6e0c06aa1a0ea47826e0 Comments
Prefer other types to int in incremen.c * src/incremen.c (struct dumpdir_iter, dumpdir_first) (read_incr_db_01, dumpdir_ok, list_dumpdir): Prefer bool to int for booleans. All uses changed. (read_incr_db_01): Don’t assume getline returns <= INT_MAX. (dumpdir_ok): Prefer char to int for chars.
Changed files
- src/incremen.c
Change #213306
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 91ad4ea343798fd27aefb7a44fc8ddff9ef8f761 Comments
Fix some uses of int in list.c * src/list.c (decode_xform): Last arg is now int, not a void * pointer to that int. All uses changed. (enforce_one_top_level): Don’t assume string length fits in int. (transform_stat_info): Prefer char to int for typeflag. All uses changed. (decode_header): Prefer bool for booleans. All uses changed. (ugswidth): Now idx_t, not int, since in theory it could exceed INT_MAX. All uses changed. (simple_print_header, print_for_mkdir): Don’t assume printf length fits in int, and similarly for length of user or group name. * src/transform.c (transform_name_fp): Last arg is now int, not void *. All uses changed.
Changed files
- src/common.h
- src/compare.c
- src/list.c
- src/transform.c
- src/update.c
Change #213307
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 53a369109216ea44c931c1a136146dc45954bfc7 Comments
Prefer other types to int in map.c * src/map.c (map_read): Prefer bool for booleans. (owner_map_translate, group_map_translate): Return void, not int, as nobody uses the return value.
Changed files
- src/common.h
- src/map.c
Change #213308
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision f96aff3ce92fc1afd1e4ce742dd0ebf729eb293e Comments
Prefer other types to int in misc.c * src/misc.c (quote_copy_string, tar_savedir): Use bool for booleans. All uses changed. (quote_copy_string): Use char for chars. (unquote_string): Return void, since nobody uses return value. (unquote_string): Check for overflow in escapes like \777. (wdcache): Now array of idx_t not int, since in theory it might contain values greater than INT_MAX. All uses changed.
Changed files
- src/common.h
- src/incremen.c
- src/misc.c
- src/update.c
Change #213309
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 41143ee46fae751c6a855cfc97c3f615b0715b18 Comments
Prefer other types to int in names.c * src/names.c (uname_to_uid, gname_to_gid, handle_option) (make_file_name): Prefer bool for boolean. (struct name_elt, read_name_from_file): Prefer char for char. (handle_option): Invert sense of return value, for clarity. All uses changed. (merge_sort_sll, merge_sort, collect_and_sort_names): Don’t assume list length fits in int. Use intptr_t not idx_t, since the bound is the size of all memory rather than one array.
Changed files
- src/names.c
Change #213310
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision ef95115f61b898d1f63a63e3a6d6427c5c3526d4 Comments
Prefer other types to int in sparse.c * src/sparse.c (oldgnu_get_sparse_info, star_get_sparse_info): Prefer char for char.
Changed files
- src/sparse.c
Change #213311
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 04c1b85872b14ab70b4015c413f1839e9730304a Comments
Prefer other types to int in system.c * src/system.c (is_regular_file, sys_exec_setmtime_script): Prefer bool for boolean. (sys_exec_command): Prefer char for char.
Changed files
- src/common.h
- src/create.c
- src/system.c
Change #213312
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 6993486ed8f14992cc228021b7e96a7a576e827c Comments
Avoid unlikely verbose_option overflow * src/tar.c (parse_opt, decode_options): Avoid undefined behavior if verbose_option overflows.
Changed files
- src/tar.c
Change #213313
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision f4ac66226a745cb8c14a7ce01e5e06deb037c199 Comments
Prefer other types to int in transform.c * src/transform.c (add_char_segment, parse_xform_flags) (parse_transform_expr): Prefer char for char. (parse_transform_expr): Don’t assume strlen (expr) <= INT_MAX.
Changed files
- src/transform.c
Change #213314
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision e531f8c66cf77e5e53204c868fb1c19443a6bb22 Comments
Prever other types to int in warning.c * src/warning.c (set_warning_option): Prefer bool for boolean.
Changed files
- src/warning.c
Change #213315
Category gtar Changed by Paul Eggert <eggert @cs.ucla.edu>Changed at Sat 02 Nov 2024 07:47:23 Repository git://git.savannah.gnu.org/tar.git Project gtar Branch master Revision 04b4f491a8b3e774ab3ece194f25b23ab0095e6d Comments
Prefer other types to int in xattrs.c * src/xattrs.c (xattrs__acls_set) [HAVE_POSIX_ACLS]: Prefer acl_type_t to int for ACL types. (acls_get_text, xattrs_acls_get, xattrs_acls_set) (xattrs_xattrs_get, xattrs_selinux_get, xattrs_selinux_set) (xattrs_xattrs_set): Prefer bool for booleans.
Changed files
- src/extract.c
- src/xattrs.c
- src/xattrs.h