Builder diffutils-solaris10-sparc Build #184

Results:

Failed shell_3

SourceStamp:

BuildSlave:

Reason:

The SingleBranchScheduler scheduler named 'schedule-diffutils-solaris10-sparc' triggered this build

Steps and Logfiles:

1. git update ( 11 secs )
   1. stdio
2. shell 'bash bootstrap' ( 53 mins, 5 secs )
   1. stdio
3. shell_1 './configure --disable-gcc-warnings' ( 13 mins, 50 secs )
   1. stdio
   2. config.log
4. shell_2 'gmake all' ( 5 mins, 21 secs )
   1. stdio
5. shell_3 'gmake check' failed ( 11 mins, 1 secs )
   1. stdio
   2. gnulib-tests_test-suite.log
   3. tests_test-suite.log

Build Properties:

Forced Build Properties:

Responsible Users:

1. Paul Eggert

   eggertohnoyoudont@cs.ucla.edu

Timing:

All Changes:

:

1. Change #200018

   Category	diffutils
   Changed by	Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
   Changed at	Thu 20 Jun 2024 05:42:53
   Repository	git://git.savannah.gnu.org/diffutils.git
   Project	diffutils
   Branch	master
   Revision	54c8930ca50953b995951ed185593a2831f5d335

   Comments

   maint: update .gitignore to add lib/stdbit.h

   Changed files

   • .gitignore

2. Change #200019

   Category	diffutils
   Changed by	Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
   Changed at	Thu 20 Jun 2024 05:42:53
   Repository	git://git.savannah.gnu.org/diffutils.git
   Project	diffutils
   Branch	master
   Revision	da0c15f381f59e73dfc5e98403cad86fd707ee54

   Comments

   diff: avoid memory leak with --color-palette
   Problem found indirectly by Coverity, reported by Wasser Mai
   (Bug#71535).  Although the Coverity report was wrong, there was a
   different potential memory leak nearby.  Fix the problem by
   modifying the string in place, avoiding the need to call malloc.
   * src/util.c (color_ext_list, struct color_ext_type):
   Remove.  Not needed, as the list wasn’t used.
   All uses removed.
   (get_funky_string): Omit last argument output_count, as it’s
   easily calculated by caller.  This lets us call this function
   when we don’t care about the count.
   (color_palette): Now char *, not char const *, since we
   now update through it.
   (set_color_palette): Likewise.
   (parse_diff_color): Process color palette into itself, to avoid
   unnecessary malloc and free calls.  This pacifies Coverity, saves
   a bit of space in the normal case, and avoids a memory leak in
   some cases.  Do not process the palette twice, as its memory
   has been modified and this function had no effect on the
   color indicators the second time.

   Changed files

   • src/diff.h
   • src/util.c