Builder diffutils-solaris10-i386 Build #152

Results:

Failed shell_3

SourceStamp:

BuildSlave:

Reason:

The SingleBranchScheduler scheduler named 'schedule-diffutils-solaris10-i386' triggered this build

Steps and Logfiles:

1. git update ( 1 secs )
   1. stdio
2. shell 'bash bootstrap' ( 3 mins, 48 secs )
   1. stdio
3. shell_1 './configure --disable-gcc-warnings' ( 50 secs )
   1. stdio
   2. config.log
4. shell_2 'gmake all' ( 30 secs )
   1. stdio
5. shell_3 'gmake check' failed ( 8 secs )
   1. stdio
   2. gnulib-tests_test-suite.log
   3. tests_test-suite.log

Build Properties:

Forced Build Properties:

Responsible Users:

1. Paul Eggert

   eggertohnoyoudont@cs.ucla.edu

Timing:

All Changes:

:

1. Change #177609

   Category	diffutils
   Changed by	Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
   Changed at	Sun 06 Aug 2023 09:30:03
   Repository	git://git.savannah.gnu.org/diffutils.git
   Project	diffutils
   Branch	master
   Revision	6f357cfa9fca07a309d9ee324f0273723150b027

   Comments

   diff: fix some behavior on unreadable input
   This fixes a bug I recently introduced.
   * src/diff.c (compare_files): Set and use openerr to avoid
   the need for a doomed second attempt at openat.
   Don’t insist on openat succeeding before trying fstatat.
   Unless openat fails with ENOENT, ENOTDIR, ELOOP, EOVERFLOW, ENAMETOOLONG
   it’s possible for it to fail even when fstatat would succeed.
   ENOTDIR also means the file does not exist.
   However, do not worry about EBADF as that is no longer possible
   now that diff uses xstdopen.  When checking whether a file should
   be considered to be nonexistent, do not require the other file
   desc to be UNOPENED or STDIN_FILENO; all that is needed is
   for the other file to not have an ENOENT or ENOTDIR failure.
   * src/diff.h (struct file_data): New member openerr.
   (OPEN_FAILED): New constant.
   * tests/new-file: Add a regression test to catch the bug
   fixed by the above.
   
   diff: fix recent -N regression
   * src/diff.c (compare_files): Fix recent regression, by
   looking at cmp.file[1 - f].err rather than cmp.file[1 - f].desc.
   Also, do not bother checking for EBADF, as that’s no longer
   possible now that diff uses xstdopen.

   Changed files

   • src/diff.c
   • src/diff.h
   • tests/new-file