Builder diffutils-solaris10-i386 Build #151

Results:

Failed shell_3

SourceStamp:

BuildSlave:

Reason:

The SingleBranchScheduler scheduler named 'schedule-diffutils-solaris10-i386' triggered this build

Steps and Logfiles:

1. git update ( 2 secs )
   1. stdio
2. shell 'bash bootstrap' ( 3 mins, 34 secs )
   1. stdio
3. shell_1 './configure --disable-gcc-warnings' ( 46 secs )
   1. stdio
   2. config.log
4. shell_2 'gmake all' ( 29 secs )
   1. stdio
5. shell_3 'gmake check' failed ( 8 secs )
   1. stdio
   2. gnulib-tests_test-suite.log
   3. tests_test-suite.log

Build Properties:

Forced Build Properties:

Responsible Users:

1. Paul Eggert

   eggertohnoyoudont@cs.ucla.edu

Timing:

All Changes:

:

1. Change #177594

   Category	diffutils
   Changed by	Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
   Changed at	Sat 05 Aug 2023 20:01:41
   Repository	git://git.savannah.gnu.org/diffutils.git
   Project	diffutils
   Branch	master
   Revision	ce65fcbeec251c952df2788a8b6c4131c46e7cea

   Comments

   diff: avoid a race when opening files
   * src/diff.c (O_PATHSEARCH): New constant.
   (compare_files): Prefer openat+fstat to fstatat+openat,
   as it avoids a race and should be a bit faster.

   Changed files

   • src/diff.c

2. Change #177595

   Category	diffutils
   Changed by	Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
   Changed at	Sat 05 Aug 2023 20:01:41
   Repository	git://git.savannah.gnu.org/diffutils.git
   Project	diffutils
   Branch	master
   Revision	c3d652956b9652d2ede4f507dfb6264dbd823080

   Comments

   diff: tune errno handling
   * src/diff.c (errno_encode): Add dassert to help debugging,
   and help the compiler when not debugging.

   Changed files

   • src/diff.c

3. Change #177597

   Category	diffutils
   Changed by	Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
   Changed at	Sat 05 Aug 2023 20:01:41
   Repository	git://git.savannah.gnu.org/diffutils.git
   Project	diffutils
   Branch	master
   Revision	634a0bd2ba7c690871dd0d1080c796ea97c1278b

   Comments

   diff: simplify diff_dirs
   * src/dir.c (diff_dirs): Simplify and help the compiler a bit.

   Changed files

   • src/dir.c

4. Change #177598

   Category	diffutils
   Changed by	Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
   Changed at	Sat 05 Aug 2023 20:01:41
   Repository	git://git.savannah.gnu.org/diffutils.git
   Project	diffutils
   Branch	master
   Revision	8efc1a0ec7e11ebb43d31e5baa2e5b22c60a81c6

   Comments

   diff: simplify diff_dirs API
   * src/diff.c (compare_files):
   Now extern, not static,	so that diff_dirs can call it.
   * src/dir.c (diff_dirs): Remove arg HANDLE_FILE, since it was
   always compare_files.  Just call compare_files directly.
   All uses changed.

   Changed files

   • src/diff.c
   • src/diff.h
   • src/dir.c

5. Change #177599

   Category	diffutils
   Changed by	Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
   Changed at	Sat 05 Aug 2023 20:01:41
   Repository	git://git.savannah.gnu.org/diffutils.git
   Project	diffutils
   Branch	master
   Revision	b0215c89b86abe1bc8b46cda54e2f995a8b2ce38

   Comments

   diff: tiny tweak to compare_files performance
   * src/diff.c (compare_files): Compare ints, not strings.

   Changed files

   • src/diff.c

6. Change #177600

   Category	diffutils
   Changed by	Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
   Changed at	Sat 05 Aug 2023 20:01:41
   Repository	git://git.savannah.gnu.org/diffutils.git
   Project	diffutils
   Branch	master
   Revision	7bf02ff2ccffd168d507b162524ce5e6437fa4df

   Comments

   maint: use O_CLOEXEC
   * src/cmp.c (main):
   * src/diff.c (compare_files):
   * src/dir.c (dir_read):
   Use O_CLOEXEC when opening files that need not be shared with
   child processes.

   Changed files

   • src/cmp.c
   • src/diff.c
   • src/dir.c

7. Change #177601

   Category	diffutils
   Changed by	Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
   Changed at	Sat 05 Aug 2023 20:01:41
   Repository	git://git.savannah.gnu.org/diffutils.git
   Project	diffutils
   Branch	master
   Revision	e85572e5d14330cf88fd91ccf179617afe950235

   Comments

   maint: use O_CLOEXEC on streams
   * bootstrap.conf (gnulib_modules): Add fopen-gnu, for the "e" flag.
   * src/diff3.c (main):
   * src/sdiff.c (main, edit):
   Use the "e" flag.

   Changed files

   • bootstrap.conf
   • src/diff3.c
   • src/sdiff.c

8. Change #177602

   Category	diffutils
   Changed by	Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
   Changed at	Sat 05 Aug 2023 20:01:41
   Repository	git://git.savannah.gnu.org/diffutils.git
   Project	diffutils
   Branch	master
   Revision	71fd20c2228dc74214b936ed83ebe98c45d2fb15

   Comments

   diff: prefer openat+fstat more often
   This closes some more races, by using openat+fstat instead
   of fstatat+openat which can get confused by some other process
   renaming files in the meantime.  Not all races are closed of course.
   * bootstrap.conf (gnulib_modules): Add d-type.
   * src/diff.c (errno_encode, errno_decode): Remove, as file
   descriptors are no longer portmanteau variables.  All uses removed.
   (detype_from_mode): New function.
   (dir_p): Use detype, not stat.st_mode.
   (compare_files): New args DETYPE0 and DETYPE1.  All uses changed.
   Update detype and err as new info arrives.
   Adjust to desc's new use (no longer encodes errno).
   Do not ignore lseek failures on regular files.
   Prefer openat+fstat to fstatat+openat when detype shows that it's safe,
   and avoid both fstat and fstatat if detype suffices.
   Use ‘error’ with errno value rather than setting error
   and then calling perror_with_name.  Coalesce two of these
   error diagnostics into one by moving an error check before
   the diagnostic is output.  Coalesce two calls to diff_dirs.
   Print file type based on detype if available,
   in case neither fstat nor fstatat was called.
   * src/diff.h (enum detype): New type.
   (struct file_data): New slots err, detype.
   (NONEXISTENT, UNOPENED): Renumber so that -1 stands for open failed.
   * src/dir.c (HAVE_STRUCT_DIRENT_D_TYPE): Default to false.
   (dir_read): Return to caller the d_type, if available.
    	(diff_dirs): Pass detype to compare_files.

   Changed files

   • NEWS
   • bootstrap.conf
   • doc/diffutils.texi
   • src/diff.c
   • src/diff.h
   • src/dir.c

9. Change #177603

   Category	diffutils
   Changed by	Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
   Changed at	Sat 05 Aug 2023 20:01:41
   Repository	git://git.savannah.gnu.org/diffutils.git
   Project	diffutils
   Branch	master
   Revision	b90d1aba743d87eb62daf08f3ac0db654a7bc71b

   Comments

   diff: minor errno performance tweak
   * src/diff.c (get_errno): New function.
   (compare_files): Use it.

   Changed files

   • src/diff.c