Builder curl-unthreaded-solaris11-i386 Build #4675

Results:

Build successful

SourceStamp:

BuildSlave:

Reason:

The SingleBranchScheduler scheduler named 'schedule-curl-unthreaded-solaris11-i386' triggered this build

Steps and Logfiles:

1. git update ( 9 secs )
   1. stdio
2. Runtest './tests/testcurl.pl --nogitpull ...' ( 1 hrs, 7 mins, 34 secs )
   1. stdio
   2. resultlog
3. Mail result 'cat resultlog ...' ( 0 secs )
   1. stdio

Build Properties:

Forced Build Properties:

Responsible Users:

1. Viktor Szakats

   commitohnoyoudont@vsz.me

Timing:

All Changes:

:

1. Change #258932

   Category	curl
   Changed by	Viktor Szakats <commitohnoyoudont@vsz.me>
   Changed at	Wed 25 Feb 2026 17:28:35
   Repository	https://github.com/curl/curl.git
   Project	curl
   Branch	master
   Revision	39542f09935aba0b7130c20b6aae0be5cd6ff709

   Comments

   cmake: add native clang-tidy support for tests, with concatenated sources
   Tests are build in "unity"-style, by including sources into an umbrella
   C files (similar to how CMake unity works). This does not play well with
   clang-tidy, which seems to unconditionally ignore C sources included
   like this. To fix it, curl's CMake implements a manual clang-tidy
   support for tests, which  compiles sources one-by-one, while also making
   sure sources compile cleanly standalone (e.g. all sources need to
   include `first.h`). The manual clang-tidy implementation is fragile, and
   performance, in particular when targeting Windows, is abysmal.
   
   This patch introduces an alternate solution, enabled by the
   `_CURL_TESTS_CONCAT=ON` option. In this mode, umbrella sources include
   the actual sources instead of `#including` them. Allowing to use CMake's
   built-in clang-tidy support to compile them, with clang-tidy actually
   checking the sources. Making the manual clang-tidy support unnecessary.
   In the Windows CI job it results in a 4x performance improvement (4m ->
   1m), making it practical to run clang-tidy on tests on Windows, in CI.
   
   The main downside is that clang-tidy doesn't understand the `#line`
   directive. Meaning issues found show the wrong filename and line number
   next to them. It's not impossible to locate errors this way, but also
   not convenient.
   
   Minor/potential downside is that the concatenated source needs to be
   reassembled each time an original source is updated. This may result in
   more copying on the disk when used in local development. The largest
   source is 1.4MB, so probably not a show-stopper on most machines.
   
   Another is the complexity of maintaining two methods in parallel, which
   may be necessary till clang-tidy understands `#line`:
   https://github.com/llvm/llvm-project/issues/62405
   
   This solution may in theory also enable adding clang-tidy support for
   tests in autotools, though I haven't tried.
   
   Targeted for curl CI for now, and used in a GHA/windows job. 100%
   experimental, not recommended outside these.
   
   Closes #20667

   Changed files

   • .github/workflows/windows.yml
   • scripts/mk-unity.pl
   • tests/libtest/CMakeLists.txt
   • tests/server/CMakeLists.txt
   • tests/tunit/CMakeLists.txt
   • tests/unit/CMakeLists.txt