Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Builder curl-threaded-solaris10-i386 Build #4249

Results:

Failed runtest

SourceStamp:

Projectcurl
Repositoryhttps://github.com/curl/curl.git
Branchmaster
Revision26eddf002f0d9e957ff21865bddfbdf25b4521f5
Got Revision26eddf002f0d9e957ff21865bddfbdf25b4521f5
Changes12 changes

BuildSlave:

unstable10x

Reason:

The SingleBranchScheduler scheduler named 'schedule-curl-threaded-solaris10-i386' triggered this build

Steps and Logfiles:

  1. git update ( 12 secs )
    1. stdio
  2. Runtest './tests/testcurl.pl --nogitpull ...' failed ( 5 hrs, 34 secs )
    1. stdio
    2. resultlog
  3. Mail result 'cat resultlog ...' ( 1 secs )
    1. stdio

Build Properties:

NameValueSource
branch master Build
builddir /export/home/buildbot/slave/curl-threaded-solaris10-i386 slave
buildername curl-threaded-solaris10-i386 Builder
buildnumber 4249 Build
codebase Build
got_revision 26eddf002f0d9e957ff21865bddfbdf25b4521f5 Git
osplatform I386 SetPropertyFromCommand Step
osrelease 10 SetPropertyFromCommand Step
project curl Build
repository https://github.com/curl/curl.git Build
revision 26eddf002f0d9e957ff21865bddfbdf25b4521f5 Build
scheduler schedule-curl-threaded-solaris10-i386 Scheduler
slavename unstable10x BuildSlave
workdir /export/home/buildbot/slave/curl-threaded-solaris10-i386 slave (deprecated)

Forced Build Properties:

NameLabelValue

Responsible Users:

  1. Viktor Szakats

Timing:

StartThu Feb 26 06:48:10 2026
EndThu Feb 26 21:57:37 2026
Elapsed15 hrs, 9 mins, 26 secs

All Changes:

:

  1. Change #258927

    Category curl
    Changed by Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at Wed 25 Feb 2026 15:43:23
    Repository https://github.com/curl/curl.git
    Project curl
    Branch master
    Revision 3b9d8412c09ed8d38e94b8273af9d05fb163c47c

    Comments

    clang-tidy: add more missing parentheses in macro values
Reported when running `HeaderFilterRegex: '.*'` in CI.

Also replace an underscored symbol with a regular one in macro
definition.

Cherry-picked from #20720

Closes #20721

    Changed files

    • lib/vquic/vquic_int.h
    • lib/vtls/vtls.h

  2. Change #258932

    Category curl
    Changed by Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at Wed 25 Feb 2026 17:28:35
    Repository https://github.com/curl/curl.git
    Project curl
    Branch master
    Revision 39542f09935aba0b7130c20b6aae0be5cd6ff709

    Comments

    cmake: add native clang-tidy support for tests, with concatenated sources
Tests are build in "unity"-style, by including sources into an umbrella
C files (similar to how CMake unity works). This does not play well with
clang-tidy, which seems to unconditionally ignore C sources included
like this. To fix it, curl's CMake implements a manual clang-tidy
support for tests, which  compiles sources one-by-one, while also making
sure sources compile cleanly standalone (e.g. all sources need to
include `first.h`). The manual clang-tidy implementation is fragile, and
performance, in particular when targeting Windows, is abysmal.

This patch introduces an alternate solution, enabled by the
`_CURL_TESTS_CONCAT=ON` option. In this mode, umbrella sources include
the actual sources instead of `#including` them. Allowing to use CMake's
built-in clang-tidy support to compile them, with clang-tidy actually
checking the sources. Making the manual clang-tidy support unnecessary.
In the Windows CI job it results in a 4x performance improvement (4m ->
1m), making it practical to run clang-tidy on tests on Windows, in CI.

The main downside is that clang-tidy doesn't understand the `#line`
directive. Meaning issues found show the wrong filename and line number
next to them. It's not impossible to locate errors this way, but also
not convenient.

Minor/potential downside is that the concatenated source needs to be
reassembled each time an original source is updated. This may result in
more copying on the disk when used in local development. The largest
source is 1.4MB, so probably not a show-stopper on most machines.

Another is the complexity of maintaining two methods in parallel, which
may be necessary till clang-tidy understands `#line`:
https://github.com/llvm/llvm-project/issues/62405

This solution may in theory also enable adding clang-tidy support for
tests in autotools, though I haven't tried.

Targeted for curl CI for now, and used in a GHA/windows job. 100%
experimental, not recommended outside these.

Closes #20667

    Changed files

    • .github/workflows/windows.yml
    • scripts/mk-unity.pl
    • tests/libtest/CMakeLists.txt
    • tests/server/CMakeLists.txt
    • tests/tunit/CMakeLists.txt
    • tests/unit/CMakeLists.txt

  3. Change #258951

    Category curl
    Changed by Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at Wed 25 Feb 2026 22:11:05
    Repository https://github.com/curl/curl.git
    Project curl
    Branch master
    Revision 725c5609aef19ba53373a49386cd979006b590d6

    Comments

    clang-tidy: avoid/silence `bugprone-not-null-terminated-result`
Prefer `sizeof()` over `strlen()`, static const variables over macros.
Add a couple of `NOLINT`s to silence false positives.

Also sync similar code patterns between libtests.

Cherry-picked from #20720

Closes #20723

    Changed files

    • tests/libtest/lib1520.c
    • tests/libtest/lib1525.c
    • tests/libtest/lib1526.c
    • tests/libtest/lib1527.c
    • tests/libtest/lib1531.c
    • tests/libtest/lib1576.c
    • tests/libtest/lib1662.c
    • tests/libtest/lib510.c
    • tests/libtest/lib547.c
    • tests/libtest/lib555.c
    • tests/libtest/lib579.c
    • tests/libtest/lib757.c
    • tests/server/mqttd.c
    • tests/server/rtspd.c

  4. Change #258953

    Category curl
    Changed by Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at Wed 25 Feb 2026 22:29:26
    Repository https://github.com/curl/curl.git
    Project curl
    Branch master
    Revision 3137f725cd3babf69ef4cad4721f32356db3a6ea

    Comments

    cmake: fix passing system header directories to clang-tidy for tests
Pass system directories with `-isystem` to avoid clang-tidy parsing
3rd-party and system headers with `HeaderFilterRegex: '.*' enabled.

Also:
- drop rule exception no longer necessary.
- sync normal vs. system header path order with compiler invocation.
- tidy up `set()` syntax.
- clear a temporary variable.

Bug: https://github.com/curl/curl/pull/20670#issuecomment-3940840176
Follow-up to e088e104549421914da9170eeead72a43d42c028 #17705
Cherry-picked from: #20720

Closes #20724

    Changed files

    • .clang-tidy.yml
    • CMake/Macros.cmake

  5. Change #258958

    Category curl
    Changed by Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at Wed 25 Feb 2026 22:57:02
    Repository https://github.com/curl/curl.git
    Project curl
    Branch master
    Revision aae361242f30eafacf46085ed731b1524bfd3be9

    Comments

    cmake: replace internal option with a new `testbins` target
To allow building test binaries without test certs, replacing
`_CURL_SKIP_BUILD_CERTS` internal option with a build target that is
similar to `testdeps`, but without building the test certificates.

To make building test binaries a little bit faster, with less noisy
output, and without having to reconfigure the build.

Closes #20708

    Changed files

    • docs/INSTALL-CMAKE.md
    • tests/CMakeLists.txt
    • tests/certs/CMakeLists.txt
    • tests/libtest/CMakeLists.txt
    • tests/server/CMakeLists.txt
    • tests/tunit/CMakeLists.txt
    • tests/unit/CMakeLists.txt

  6. Change #258966

    Category curl
    Changed by Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at Thu 26 Feb 2026 01:36:16
    Repository https://github.com/curl/curl.git
    Project curl
    Branch master
    Revision b56e103d4d223a722a00cd76846cbbff191f7d90

    Comments

    build: do not include wolfSSL header in `curl_setup.h`
To fix building tests/server with cmake and both wolfSSL and OpenSSL
enabled (MultiSSL).

tests/server do not have libcurl dependency header paths setup because
it does not use libcurl. The code however includes `curl_setup.h`, which
tried including `wolfssl/version.h` before this patch to verify if the
wolfSSL coexist feature is available. Without a header path, it failed:
```
In file included from bld/tests/server/servers.c:3:
In file included from tests/server/first.h:40:
lib/curl_setup.h:737:12: fatal error: 'wolfssl/version.h' file not found
  737 | #  include <wolfssl/version.h>
      |            ^~~~~~~~~~~~~~~~~~~
1 error generated.
```
Ref: https://github.com/curl/curl/actions/runs/22410066319/job/64880787424#step:46:76

Fix by moving the include and version check to `vtls/wolfssl.c`.

Also: add an early version check to cmake.

Follow-up to 16f073ef49f94412000218c9f6ad04e3fd7e4d01 #16973
Cherry-picked from #20720

Closes #20726

    Changed files

    • CMakeLists.txt
    • lib/curl_setup.h
    • lib/vtls/wolfssl.c

  7. Change #258972

    Category curl
    Changed by Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at Thu 26 Feb 2026 02:44:39
    Repository https://github.com/curl/curl.git
    Project curl
    Branch master
    Revision 2239879b746c2c1c8dd087cffbef974ec2c780f8

    Comments

    cmake: minor fixes to test targets after prev
- run tests-clang-tidy when building testbins.
- drop redundant build-certs dependency for test targets.
  Already present via testdeps.

Follow-up to aae361242f30eafacf46085ed731b1524bfd3be9 #20708

Closes #20727

    Changed files

    • tests/CMakeLists.txt

  8. Change #258975

    Category curl
    Changed by Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at Thu 26 Feb 2026 03:09:16
    Repository https://github.com/curl/curl.git
    Project curl
    Branch master
    Revision d110504e84016d3031a3ad1fa3421f22e2d0aaec

    Comments

    build: add missing `GENERATEDCERTS` files
Also alpha sort lists, while here.

Follow-up to 2cf19c245eff8ff84e53d6edc27d36bf25439d1b #17493

Closes #20728

    Changed files

    • tests/certs/Makefile.inc

  9. Change #258985

    Category curl
    Changed by Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at Thu 26 Feb 2026 04:19:18
    Repository https://github.com/curl/curl.git
    Project curl
    Branch master
    Revision d38bf7949d3acf5b484187fd3e81e0bd33b56715

    Comments

    tests/server: fix to clear the complete `srvr_sockaddr_union_t` variable
Reported by clang-tidy (seen on Linux with v18, v19, v20, not on macOS):
```
tests/server/dnsd.c:552:14: error: 1st function call argument is an uninitialized value [clang-analyzer-core.CallAndMessage]
tests/server/dnsd.c:556:14: error: 1st function call argument is an uninitialized value [clang-analyzer-core.CallAndMessage]
tests/server/rtspd.c:1183:14: error: 1st function call argument is an uninitialized value [clang-analyzer-core.CallAndMessage]
tests/server/rtspd.c:1187:14: error: 1st function call argument is an uninitialized value [clang-analyzer-core.CallAndMessage]
tests/server/sws.c:2235:14: error: 1st function call argument is an uninitialized value [clang-analyzer-core.CallAndMessage]
tests/server/sws.c:2239:14: error: 1st function call argument is an uninitialized value [clang-analyzer-core.CallAndMessage]
tests/server/tftpd.c:1188:14: error: 1st function call argument is an uninitialized value [clang-analyzer-core.CallAndMessage]
tests/server/tftpd.c:1192:14: error: 1st function call argument is an uninitialized value [clang-analyzer-core.CallAndMessage]
tests/server/util.c:860:21: error: 1st function call argument is an uninitialized value [clang-analyzer-core.CallAndMessage]
tests/server/util.c:864:21: error: 1st function call argument is an uninitialized value [clang-analyzer-core.CallAndMessage]
```
Ref: https://github.com/curl/curl/actions/runs/22424827575/job/64930560425?pr=20725

Cherry-picked from #20725

Closes #20730

    Changed files

    • tests/server/dnsd.c
    • tests/server/rtspd.c
    • tests/server/sws.c
    • tests/server/tftpd.c
    • tests/server/util.c

  10. Change #258986

    Category curl
    Changed by Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at Thu 26 Feb 2026 04:19:18
    Repository https://github.com/curl/curl.git
    Project curl
    Branch master
    Revision b1f853a3849d0e8116ae4e2aedfb9ca65f92282d

    Comments

    unit3205: suppress two clang-tidy false positives
Silencing:
```
tests/unit/unit3205.c:565:32: error: the result from calling 'memcpy' is not null-terminated [bugprone-not-null-terminated-result]
  565 |         expect = (const char *)memcpy(alt, "DHE-", 4);
      |                                ^~~~~~            ~~~
      |                                strcpy
tests/unit/unit3205.c:569:32: error: the result from calling 'memcpy' is not null-terminated [bugprone-not-null-terminated-result]
  569 |         expect = (const char *)memcpy(alt + 4, "DHE-", 4) - 4;
      |                                ^~~~~~                ~~~
      |                                strcpy
```
Ref: https://github.com/curl/curl/actions/runs/22425366818/job/64932197466?pr=20725

Cherry-picked from #20725

Closes #20731

    Changed files

    • tests/unit/unit3205.c

  11. Change #259000

    Category curl
    Changed by Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at Thu 26 Feb 2026 05:08:30
    Repository https://github.com/curl/curl.git
    Project curl
    Branch master
    Revision 137e87ca721e0aec387273964cb8a9872c85f22a

    Comments

    clang-tidy: enable scanning headers
By setting `HeaderFilterRegex: '.*'`.

Closes #20720

    Changed files

    • .clang-tidy.yml

  12. Change #259001

    Category curl
    Changed by Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at Thu 26 Feb 2026 05:08:30
    Repository https://github.com/curl/curl.git
    Project curl
    Branch master
    Revision 26eddf002f0d9e957ff21865bddfbdf25b4521f5

    Comments

    GHA/linux: switch clang-tidy job to cmake for 2x speed, bump to v20, enable for tests
Checking lib and src under 3m15s versus 7m15s.

Downside: autotools clang-tidy support is no longer CI-tested.

The reason for the slowness is invoking a single clang-tidy command with
all source files, and clang-tidy checking them in a single thread,
sequentially. clang-tidy offers a `run-clang-tidy` Python script for
parallel  processing, which may help with this. However at this point
it's more practical to use cmake, which also supports verifying the
whole codebase, not only lib and src.

Also:
- bump clang-tidy to the latest available, v20 (from v18).
- enable running clang-tidy on tests. Takes under 2 minutes.

Also tried `_CURL_TESTS_CONCAT=ON`, it brings down the build tests step
from 1m47s to 54s, saving 1 minute. Skipped using it for now.

Closes #20725

    Changed files

    • .github/workflows/linux.yml
BuildBot (0.8.14) working for the OpenCSW Buildbot project.
Page built: Sat 28 Feb 2026 09:56:16 (CET)