Builder curl-pr-unthreaded-solaris10-i386 Build #3637

Results:

Build successful

SourceStamp:

BuildSlave:

Reason:

The AnyBranchScheduler scheduler named 'schedule-curl-pr' triggered this build

Steps and Logfiles:

1. git update ( 29 secs )
   1. stdio
2. Runtest './tests/testcurl.pl --nogitpull ...' ( 1 hrs, 16 mins, 17 secs )
   1. stdio
   2. resultlog

Build Properties:

Forced Build Properties:

Responsible Users:

1. Daniel Stenberg

   danielohnoyoudont@haxx.se
2. Stefan Eissing

   stefanohnoyoudont@eissing.org
3. Viktor Szakats

   commitohnoyoudont@vsz.me

Timing:

All Changes:

:

1. Change #224839

   Category	None
   Changed by	Stefan Eissing <stefanohnoyoudont@eissing.org>
   Changed at	Wed 12 Mar 2025 23:15:14
   Repository	https://github.com/curl/curl
   Project	curl/curl
   Branch	master
   Revision	886569e2db200c31073895a2626d20e0712e5207

   Comments

   curl: fix --cert parameter clearing
   
   Blank the argument *after* it has been copied.
   
   Reported-by: Jan Macku
   Fixes #16686
   Closes #16688

   Changed files

   • src/tool_getparam.c

2. Change #224840

   Category	None
   Changed by	Daniel Stenberg <danielohnoyoudont@haxx.se>
   Changed at	Wed 12 Mar 2025 23:16:46
   Repository	https://github.com/curl/curl
   Project	curl/curl
   Branch	master
   Revision	0bb8465b1e529f4ac1f764baa56117ea1fd73fe4

   Comments

   multi: call protocol handler done() if PROTOCONNECT or later
   
   The protocol handlers' done() function would previous get called
   unconditionally in multi_done(), no matter how far the easy handle's
   state machine has transitioned.
   
   This caused problems in IMAP which in imap_connect() initializes things
   that the imap_done() function assumes has occured. I think that seems
   like a correct assumption and we should rather make sure that the done()
   function is only called if we have reached the PROTOCONNECT state.
   
   This problem was found using OSS-Fuzz.
   
   Assisted-by: Catena cyber
   
   Closes #16681

   Changed files

   • lib/multi.c

3. Change #224846

   Category	None
   Changed by	Daniel Stenberg <danielohnoyoudont@haxx.se>
   Changed at	Wed 12 Mar 2025 23:41:40
   Repository	https://github.com/curl/curl
   Project	curl/curl
   Branch	master
   Revision	45ce0847f35189d878476b8d3dc1098a88a6d4ae

   Comments

   runtests: enable the --libcurl feature by default
   
   Follow-up to a14eb26a585e67309066ac8a2
   Reported-by: Viktor Szakats
   Fixes #16693
   Closes #16694

   Changed files

   • tests/runtests.pl

4. Change #224849

   Category	None
   Changed by	Viktor Szakats <commitohnoyoudont@vsz.me>
   Changed at	Thu 13 Mar 2025 00:03:15
   Repository	https://github.com/curl/curl
   Project	curl/curl
   Branch	master
   Revision	ee73d553edf181c1f2673e61d1754365d98380c6

   Comments

   build: replace Curl_ prefix with curlx_ for functions used in servers
   
   Closes #16689

   Changed files

   • lib/altsvc.c
   • lib/asyn-ares.c
   • lib/cf-socket.c
   • lib/connect.c
   • lib/curl_addrinfo.c
   • lib/curl_setup.h
   • lib/ftp.c
   • lib/hostip.c
   • lib/hostip6.c
   • lib/if2ip.c
   • lib/inet_ntop.c
   • lib/inet_ntop.h
   • lib/inet_pton.c
   • lib/inet_pton.h
   • lib/noproxy.c
   • lib/smb.c
   • lib/socks.c
   • lib/strerror.c
   • lib/strerror.h
   • lib/urlapi.c
   • lib/vtls/gtls.c
   • lib/vtls/openssl.c
   • lib/vtls/schannel_verify.c
   • lib/vtls/vtls.c
   • tests/libtest/lib1960.c
   • tests/server/getpart.c
   • tests/server/rtspd.c
   • tests/server/sockfilt.c
   • tests/server/socksd.c
   • tests/server/sws.c
   • tests/server/tftpd.c
   • tests/server/util.c

5. Change #224850

   Category	None
   Changed by	Viktor Szakats <commitohnoyoudont@vsz.me>
   Changed at	Thu 13 Mar 2025 00:03:15
   Repository	https://github.com/curl/curl
   Project	curl/curl
   Branch	master
   Revision	07f984a776118e90c1e80c56c17b1eea23e347b9

   Comments

   ntlm: merge ntlm.h into ntlm.c
   
   It's the only user since dropping NTLM_WB support.
   
   Follow-up to 50def7c881ba560ab6e0235990e8f07fa69f4bc8 #13249
   
   Closes #16690

   Changed files

   • lib/Makefile.inc
   • lib/vauth/ntlm.c
   • lib/vauth/ntlm.h

6. Change #224851

   Category	None
   Changed by	Viktor Szakats <commitohnoyoudont@vsz.me>
   Changed at	Thu 13 Mar 2025 00:03:15
   Repository	https://github.com/curl/curl
   Project	curl/curl
   Branch	master
   Revision	c0a70c564d5d60fca5fda093b1fb45063aff2386

   Comments

   base64: drop `BUILDING_CURL` macro, always include in tests/server
   
   Before this patch, building tests/server (or curl with winbuild) was
   broken in rare builds when many features were explicitly disabled.
   
   Fix it by enabling base64 functions unconditionally when building
   for anything other than libcurl.
   
   Closes #16691

   Changed files

   • lib/base64.c
   • src/CMakeLists.txt
   • src/Makefile.am

7. Change #224852

   Category	None
   Changed by	Viktor Szakats <commitohnoyoudont@vsz.me>
   Changed at	Thu 13 Mar 2025 00:03:25
   Repository	https://github.com/curl/curl
   Project	curl/curl
   Branch	master
   Revision	51d8213579c6e92f16912742a25d9567d4a52903

   Comments

   core: stop redefining `E*` macros on Windows, map `EACCES`, related fixes
   
   Before this patch, standard `E*` errno codes were redefined on Windows,
   onto matching winsock2 `WSA*` error codes, which have different values.
   This broke uses where using the `E*` value in non-socket context, or
   other places expecting a POSIX `errno`, e.g. file I/O, threads, IDN or
   interfacing with dependencies.
   
   Fix it by introducing a curl-specific `SOCKE*` set of macros that map to
   `WSA*` on Windows and standard POSIX codes on other platforms. Then
   verify and update the code to use `SOCKE*` or `E*` macro depending on
   context.
   
   - Add `SOCKE*` macros that map to either winsock2 or POSIX error codes.
     And use them with `SOCKERRNO` or in contexts requiring
     platform-dependent socket error codes.
   
     This fixes `E*` uses which were supposed be POSIX values, not `WSA*`
     socket errors, on Windows:
     - lib/curl_multibyte.c
     - lib/curl_threads.c
     - lib/idn.c
     - lib/vtls/gtls.c
     - lib/vtls/rustls.c
     - src/tool_cb_wrt.c
     - src/tool_dirhie.c
   
   - Ban `E*` codes having a `SOCKE*` mapping, via checksrc.
     Authored-by: Daniel Stenberg
   
   - Add exceptions for `E*` codes used in file I/O, or other contexts
     requiring POSIX error codes.
   
   Also:
   - ftp: fix missing `SOCKEACCES` mapping for Windows.
   - add `SOCKENOMEM` for `Curl_getaddrinfo()` via `asyn-thread.c`.
   - tests/server/sockfilt: fix to set `SOCKERRNO` in local `select()`
     override on Windows.
   - lib/inet_ntop: fix to return `WSAEINVAL` on Windows, where `ENOSPC` is
     used on other platforms. To simulate Windows' built-in `inet_ntop()`,
     as tested on a Win10 machine.
     Note:
     - WINE returns `STATUS_INVALID_PARAMETER` = `0xC000000D`.
     - Microsoft documentation says it returns `WSA_INVALID_PARAMETER`
       (= `ERROR_INVALID_PARAMETER`) 87:
       https://learn.microsoft.com/windows/win32/api/ws2tcpip/nf-ws2tcpip-inet_ntop#return-value
   - lib/inet_ntop: drop redundant `CURL_SETERRNO(ENOSPC)`.
     `inet_ntop4()` already sets it before returning `NULL`.
   - replace stray `WSAEWOULDBLOCK` with `USE_WINSOCK` macro to detect
     winsock2.
   - move existing `SOCKE*` mappings from `tests/server` to
     `curl_setup_once.h`.
   - add missing `EINTR`, `EINVAL` constants for WinCE.
   
   Follow-up to abf80aae384319ef9b19ffbd0d69a1fbe7421f1f #16612
   Follow-up to d69425ed7d0918aceddd96048b146a9df85638ec #16615
   Bug: https://github.com/curl/curl/pull/16553#issuecomment-2704679377
   
   Closes #16621

   Changed files

   • CMake/CurlTests.c
   • docs/examples/.checksrc
   • lib/amigaos.c
   • lib/asyn-thread.c
   • lib/cf-socket.c
   • lib/connect.c
   • lib/curl_multibyte.c
   • lib/curl_setup.h
   • lib/curl_setup_once.h
   • lib/curl_threads.c
   • lib/ftp.c
   • lib/idn.c
   • lib/inet_ntop.c
   • lib/inet_pton.c
   • lib/memdebug.c
   • lib/multi.c
   • lib/openldap.c
   • lib/select.c
   • lib/select.h
   • lib/socketpair.c
   • lib/telnet.c
   • lib/vquic/vquic.c
   • lib/vtls/gtls.c
   • lib/vtls/rustls.c
   • packages/OS400/ccsidcurl.c
   • packages/OS400/os400sys.c
   • scripts/checksrc.pl
   • src/tool_cb_wrt.c
   • src/tool_dirhie.c
   • src/tool_operate.c
   • tests/libtest/first.c
   • tests/server/rtspd.c
   • tests/server/sockfilt.c
   • tests/server/sws.c
   • tests/server/util.c
   • tests/server/util.h