Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Builder curl-pr-unthreaded-solaris10-i386 Build #3591

Results:

Build successful

SourceStamp:

Projectcurl/curl
Repositoryhttps://github.com/curl/curl
Branchmaster
Revision27d24690a46138a949a555da3d5487e98fa7f5e9
Got Revision27d24690a46138a949a555da3d5487e98fa7f5e9
Changes17 changes

BuildSlave:

unstable10x

Reason:

The AnyBranchScheduler scheduler named 'schedule-curl-pr' triggered this build

Steps and Logfiles:

  1. git update ( 8 secs )
    1. stdio
  2. Runtest './tests/testcurl.pl --nogitpull ...' ( 1 hrs, 13 mins, 51 secs )
    1. stdio
    2. resultlog

Build Properties:

NameValueSource
branch master Build
builddir /export/home/buildbot/slave/curl-pr-unthreaded-solaris10-i386 slave
buildername curl-pr-unthreaded-solaris10-i386 Builder
buildnumber 3591 Build
codebase Build
got_revision 27d24690a46138a949a555da3d5487e98fa7f5e9 Git
osplatform I386 SetPropertyFromCommand Step
osrelease 10 SetPropertyFromCommand Step
project curl/curl Build
repository https://github.com/curl/curl Build
revision 27d24690a46138a949a555da3d5487e98fa7f5e9 Build
scheduler schedule-curl-pr Scheduler
slavename unstable10x BuildSlave
workdir /export/home/buildbot/slave/curl-pr-unthreaded-solaris10-i386 slave (deprecated)

Forced Build Properties:

NameLabelValue

Responsible Users:

  1. Daniel Stenberg
  2. Harry Sintonen
  3. Stefan Eissing
  4. Viktor Szakats

Timing:

StartFri Mar 7 16:00:17 2025
EndFri Mar 7 20:53:26 2025
Elapsed4 hrs, 53 mins, 9 secs

All Changes:

:

  1. Change #224111

    Category None
    Changed by Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at Thu 06 Mar 2025 20:09:25
    Repository https://github.com/curl/curl
    Project curl/curl
    Branch master
    Revision 8537a5b0bcf4565551774c2b2375c49767e405a7

    Comments

    windows: do not use winsock2 `inet_ntop()`/`inet_pton()`
    
    Disable these winsock2 functions on Windows to use the curl wrappers
    and preserve `WSAGetLastError()` aka `SOCKERRNO` error codes.
    
    curl sources uses `inet_pton()` and `inet_ntop()` via its own `Curl_`
    prefixed wrappers. These wrappers promise to not overwrite
    `WSAGetLastError()` aka `SOCKERRNO` error codes when calling them.
    But, for Windows builds with these built-in winsock2 functions detected
    (meaning all supported Windows versions, except Windows CE),
    the wrappers were 1-to-1 mapped to the winsock2 functions, which broke
    this promise.
    
    https://github.com/curl/curl/blob/b06c12b7248592cf001e621d7cd8dc78a827212b/lib/inet_ntop.c#L188-L190
    https://github.com/curl/curl/blob/b06c12b7248592cf001e621d7cd8dc78a827212b/lib/inet_pton.c#L66-L70
    
    These promises are old (a1d598399146984c99baa46db148e87c75261033) and
    may not be valid anymore. In this case, the callers would have to be
    updated to use `SOCKERRNO` to retrieve any error, instead of using
    `errno` as they do now.
    
    https://learn.microsoft.com/windows/win32/api/ws2tcpip/nf-ws2tcpip-inet_ntop
    https://learn.microsoft.com/windows/win32/api/ws2tcpip/nf-ws2tcpip-inet_pton
    
    Closes #16577

    Changed files

    • CMake/win32-cache.cmake
    • CMakeLists.txt
    • configure.ac
    • lib/inet_ntop.h
    • lib/inet_pton.h
  2. Change #224112

    Category None
    Changed by Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at Thu 06 Mar 2025 20:09:29
    Repository https://github.com/curl/curl
    Project curl/curl
    Branch master
    Revision 9463769f2e2dba9eeff554a88e5df5195d2c774b

    Comments

    tests: reformat error messages to avoid tripping MSBuild
    
    Change the format of error messages sent to stderr from tests and test
    servers. As a workaround to avoid triggering Visual Studio's MSBuild
    tool's built-in regexp matcher, and making it mark builds failed for
    reasons we don't want them to hard fail.
    
    Roughly, the pattern to avoid is the word "error" (case-insensitive)
    in the same line with a colon `:`.
    
    It affected GHA/windows MSVC CI jobs, causing flakiness:
    ```
    CUSTOMBUILD : fopen() failed with error : 13 Permission denied [D:\a\curl\curl\bld\tests\test-ci.vcxproj]
      Error opening file: log/4/smtp_sockfilt.log
    [...]
    CUSTOMBUILD : fopen() failed with error : 13 Permission denied [D:\a\curl\curl\bld\tests\test-ci.vcxproj]
      Error opening file: log/8/imap_sockfilt.log
      Msg not logged: 00:18:10.656000 > 178 bytes data, server => client
    [...]
      TESTDONE: 1629 tests out of 1634 reported OK: 99%
      Building Custom Rule D:/a/curl/curl/tests/CMakeLists.txt
    C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VC\v170\Microsoft.CppCommon.targets(254,5): error MSB8066: Custom build for 'D:\a\curl\curl\bld\CMakeFiles\621f80ddbb0fa48179f056ca77842ff0\test-ci.rule;D:\a\curl\curl\tests\CMakeLists.txt' exited with code -1. [D:\a\curl\curl\bld\tests\test-ci.vcxproj]
    Error: Process completed with exit code 1.
    ```
    Ref: https://github.com/curl/curl/actions/runs/13643149623/job/38137076210?pr=16490#step:14:3125
    Ref: https://github.com/curl/curl/actions/runs/13688765792/job/38277961720?pr=16582#step:14:1717
    
    The `IgnoreStandardErrorWarningFormat="true"` MSBuild Exec option
    controls this behavior:
    https://learn.microsoft.com/visualstudio/msbuild/exec-task#parameters
    I couldn't figure out a way to apply it to CMake builds.
    
    MSBuid pattern matching rules:
    https://github.com/dotnet/msbuild/blob/353c0f3d37957cc98bfa6a76b568d70d12193fc3/src/Shared/CanonicalError.cs
    https://learn.microsoft.com/visualstudio/msbuild/msbuild-diagnostic-format-for-tasks
    
    Note: There may be further error messages output from runtests scripts,
    that use this format, which are not explicitly fatal. They may need
    future fixes.
    
    Thanks-to: Dion Williams
    Ref: https://github.com/curl/curl/discussions/14854#discussioncomment-12382190
    Ref: https://github.com/curl/curl/discussions/14854#discussioncomment-12395224
    
    Closes #16583

    Changed files

    • tests/libtest/lib1523.c
    • tests/libtest/lib505.c
    • tests/libtest/lib525.c
    • tests/libtest/lib530.c
    • tests/libtest/lib541.c
    • tests/libtest/lib582.c
    • tests/libtest/lib591.c
    • tests/server/mqttd.c
    • tests/server/rtspd.c
    • tests/server/sockfilt.c
    • tests/server/socksd.c
    • tests/server/sws.c
    • tests/server/tftpd.c
    • tests/server/util.c
  3. Change #224117

    Category None
    Changed by Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at Thu 06 Mar 2025 20:33:43
    Repository https://github.com/curl/curl
    Project curl/curl
    Branch master
    Revision 2d94439eaa8da4fe11f99872a8b44087f74f88b0

    Comments

    sectransp: add support for HTTP/2 in gcc builds
    
    Before this patch `--http2` did not work in gcc builds with Secure
    Transport, because ALPN relied on a compiler supporting the
    `HAVE_BUILTIN_AVAILABLE` aka `__builtin_available()` feature. This
    is clang-specific and missing from gcc (as of gcc v14).
    
    Add support for ALPN and HTTP/2 when this compiler feature is missing.
    
    Also drop test exceptions from GHA/macos in CI.
    
    Follow-up to 092f6815c808489f1cea3df8449e16dff2c35e6b
    Ref: c349bd668c91f2484ae21c0f361ddf497143093c #14097 (issue 15.)
    Ref: #4314
    
    Closes #16581

    Changed files

    • .github/workflows/macos.yml
    • lib/vtls/sectransp.c
  4. Change #224131

    Category None
    Changed by Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at Thu 06 Mar 2025 23:47:27
    Repository https://github.com/curl/curl
    Project curl/curl
    Branch master
    Revision 3a8920e5edaead8304a818594f54485a5564f976

    Comments

    GHA/windows: drop `handle64.exe`
    
    To test its effect on stability/flakiness of Windows jobs.
    
    Ref: https://github.com/curl/curl/pull/16484#issuecomment-2705016375
    Cherry-picked from #16484
    Closes #16600

    Changed files

    • .github/workflows/windows.yml
  5. Change #224137

    Category None
    Changed by Harry Sintonen <sintonenohnoyoudont@iki.fi>
    Changed at Fri 07 Mar 2025 00:06:17
    Repository https://github.com/curl/curl
    Project curl/curl
    Branch master
    Revision f1662ae97b37c509dbd3ad46d2ac7cc64806e250

    Comments

    doh: improve HTTPS RR svcparams parsing
    
    Fixed a heap read overflow when parsing the HTTP RR svcparams. Also the
    code failed to enforce the requirements of SvcParamKey order specified
    in section 2.2 of the RFC 9460.
    
    Closes #16598

    Changed files

    • lib/doh.c
  6. Change #224150

    Category None
    Changed by Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at Fri 07 Mar 2025 02:19:28
    Repository https://github.com/curl/curl
    Project curl/curl
    Branch master
    Revision 914790336664da0451e2f57906373a7707bd7cc3

    Comments

    GHA/macos: add initial pytest support
    
    Add support for running pytest in GHA/macos jobs.
    
    Experimental, with caveats:
    - slow.
    - `httpd` often fails to start.
    - 10-15 tests (depending on C compiler) fail consistently:
      02_20, 02_33, 02_34, 03_01, 03_03, 05_04, 07_42.
    - Homebrew build of vsftpd misses TLS support.
    - `nghttpx` temporarily disabled for pytest.
    
    You can test pytest by adding `install_steps: pytest` to a job.
    
    Closes #16518

    Changed files

    • .github/workflows/macos.yml
  7. Change #224156

    Category None
    Changed by Daniel Stenberg <danielohnoyoudont@haxx.se>
    Changed at Fri 07 Mar 2025 08:58:46
    Repository https://github.com/curl/curl
    Project curl/curl
    Branch master
    Revision 1503555836a4ecc3020999a975ddab2d5e96e4a3

    Comments

    src: cleanup ISBLANK vs ISSPACE
    
    - use ISBLANK() where only spaces and tabs should match
    - change while(x && ISBLANK(X)) => while(ISBLANK(x))
    
    Closes #16589

    Changed files

    • src/tool_formparse.c
    • src/tool_getparam.c
    • src/tool_parsecfg.c
    • src/tool_urlglob.c
    • src/var.c
  8. Change #224168

    Category None
    Changed by Stefan Eissing <stefanohnoyoudont@eissing.org>
    Changed at Fri 07 Mar 2025 11:14:37
    Repository https://github.com/curl/curl
    Project curl/curl
    Branch master
    Revision 0d1e43af8dccd18b84b46f7bc7a5d57a2bc1ff11

    Comments

    ngtcp2: do not iterate over multi handles
    
    There was on place left iterating over `multi->process` list which was
    unnecessary. Remove that.
    
    Closes #16606

    Changed files

    • lib/vquic/curl_ngtcp2.c
  9. Change #224169

    Category None
    Changed by Daniel Stenberg <danielohnoyoudont@haxx.se>
    Changed at Fri 07 Mar 2025 11:16:24
    Repository https://github.com/curl/curl
    Project curl/curl
    Branch master
    Revision f4831daa9b2a97e8a2921d6b62cc4dfdd0d8646e

    Comments

    url: call protocol handler's disconnect in Curl_conn_free
    
    For the case when the connection struct is all setup, the protocol
    handler allocates data in its setup_connection function, but the
    connection struct is discarded again before used further because a
    connection reuse is prefered. Then the handler's disconnect function was
    not previously called, which then would lead to a memory leak.
    
    I added test case 698 that reproduces the leak and the fix.
    
    Reported-by: Philippe Antoine
    Closes #16604

    Changed files

    • lib/url.c
    • tests/data/Makefile.am
    • tests/data/test698
  10. Change #224182

    Category None
    Changed by Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at Fri 07 Mar 2025 13:48:07
    Repository https://github.com/curl/curl
    Project curl/curl
    Branch master
    Revision 3b501976a9adcf20218ffb96d9041806432227e4

    Comments

    build: cmake multi-pkg-config detection improvements (brotli, ldap, mbedtls)
    
    Apply downstream patch from the vcpkg project:
    
    - cmake/FindBrotli: streamline detecting multiple pkg-config modules.
      Add `libbrotlicommon` to `Requires.private` in `libcurl.pc`.
    
    Apply the above idea to the rest of multi-module dependencies:
    
    - cmake/FindMbedTLS: streamline detecting multiple pkg-config modules
      Add `mbedx509`, `mbedcrypto` to `Requires.private` in `libcurl.pc`.
    
    - cmake/FindLDAP: streamline detecting multiple pkg-config modules
    
    And sync these changes with autotools, and add `libbrotlicommon`,
    `mbedx509`, `mbedcrypto` to `Requires.private`.
    
    Co-authored-by: Kai Pastor
    Ref: https://github.com/microsoft/vcpkg/pull/43819
    
    Closes #16479

    Changed files

    • CMake/FindBrotli.cmake
    • CMake/FindLDAP.cmake
    • CMake/FindMbedTLS.cmake
    • configure.ac
    • m4/curl-mbedtls.m4
  11. Change #224183

    Category None
    Changed by Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at Fri 07 Mar 2025 13:48:07
    Repository https://github.com/curl/curl
    Project curl/curl
    Branch master
    Revision 0ead361904266a1590e361a0dbef16aef8cc7617

    Comments

    cmake: `CURL_LIBDIRS` improvements (upstreamed from vcpkg)
    
    Apply downstream patches from the vcpkg project:
    
    - cmake: remove duplicates from `CURL_LIBDIRS`.
    
    - cmake: set `CURL_LIBDIRS` as `INTERFACE_LINK_DIRECTORIES` for static
      libcurl.
      To support CMake <3.13, change downstream patch from:
      ```cmake
      target_link_directories(${LIB_STATIC} INTERFACE ${CURL_LIBDIRS})
      ```
      to:
      ```cmake
      set_target_properties(${LIB_STATIC} PROPERTIES [...] INTERFACE_LINK_DIRECTORIES "${CURL_LIBDIRS}")
      ```
    
    Co-authored-by: Kai Pastor
    Ref: https://github.com/microsoft/vcpkg/pull/43819
    
    Closes #16610

    Changed files

    • CMakeLists.txt
    • lib/CMakeLists.txt
  12. Change #224184

    Category None
    Changed by Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at Fri 07 Mar 2025 13:48:07
    Repository https://github.com/curl/curl
    Project curl/curl
    Branch master
    Revision 07f99b72d5527ef0ffd38f203dbeb6624a47096a

    Comments

    wolfssl: fix unused variable warning
    
    E.g. when building against msys2-mingw wolfssl:
    https://packages.msys2.org/base/mingw-w64-wolfssl
    
    ```
    lib/vtls/wolfssl.c: In function 'wssl_verify_pinned':
    lib/vtls/wolfssl.c:1534:20: error: unused variable 'wssl' [-Werror=unused-variable]
       struct wssl_ctx *wssl = (struct wssl_ctx *)connssl->backend;
                        ^~~~
    ```
    Ref: https://github.com/curl/curl/actions/runs/13713131802/job/38353245932#step:10:78
    
    Building with the MSYS2 wolfssl is broken due to further issues.
    
    Closes #16608

    Changed files

    • lib/vtls/wolfssl.c
  13. Change #224185

    Category None
    Changed by Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at Fri 07 Mar 2025 13:48:07
    Repository https://github.com/curl/curl
    Project curl/curl
    Branch master
    Revision bc55b435afbb94c9c0e4b138d5375702c451a2ea

    Comments

    tests/server: round of tidy-ups (part 2)
    
    General tidy-ups, to identify and reduce duplications and potential
    issues, while also making the server modules compile as a single binary.
    
    - ensure unique symbols and no shadowing across server sources, by
      renaming variables.
    - move globals common to multiple servers into shared `util` module.
    - drop constants with a single use.
    - undef macro before re-using them across server sources.
    - move common functions into shared `util` module.
    - drop redundant static declarations.
    - disable IPv6 code when built without IPv6.
    - start syncing the 3 almost identical copies of `sockdaemon` function.
    - drop unused `timeval.h` header.
    - drop `poll()` from `wait_ms()`, for macOS, following an earlier core
      update.
      Follow-up to c72cefea0fadaf4114a0036c86005ee5739ec30a #15096
    
    Follow-up to 9213e4e497d575d2bc2c9265d40da6c5549f526d #16525
    Cherry-picked from #15000
    Closes #16609

    Changed files

    • tests/server/mqttd.c
    • tests/server/resolve.c
    • tests/server/rtspd.c
    • tests/server/sockfilt.c
    • tests/server/socksd.c
    • tests/server/sws.c
    • tests/server/tftpd.c
    • tests/server/util.c
    • tests/server/util.h
  14. Change #224192

    Category None
    Changed by Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at Fri 07 Mar 2025 14:28:27
    Repository https://github.com/curl/curl
    Project curl/curl
    Branch master
    Revision 7cc4a23ee4d8d80b6415cb22e2f32f8c98f8a9b6

    Comments

    GHA/windows: ignore flaky 2310 with MSVC again
    
    Follow-up to 1bd5ac998bbc943dbf812b2824ad0f532201734c #16570

    Changed files

    • .github/workflows/windows.yml
  15. Change #224197

    Category None
    Changed by Stefan Eissing <stefanohnoyoudont@eissing.org>
    Changed at Fri 07 Mar 2025 14:54:25
    Repository https://github.com/curl/curl
    Project curl/curl
    Branch master
    Revision 469c037fcfd0cc07435a38262ab96d1a63e84adc

    Comments

    openssl-quic: do not iterate over multi handles
    
    Iterate over the filters stream hash instead, lookup easy handles
    at the multi when needed.
    
    This also limits to pollset array sizes to the number of streams
    on the connection and not the total number of transfers in the multi.
    
    Closes #16611

    Changed files

    • lib/vquic/curl_osslq.c
    • tests/http/test_14_auth.py
  16. Change #224210

    Category None
    Changed by Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at Fri 07 Mar 2025 15:43:00
    Repository https://github.com/curl/curl
    Project curl/curl
    Branch master
    Revision a7c8d2f9bcd882cbe8bd96e1e4da9a36af8950bc

    Comments

    vtls: fix compiler warnings seen with gcc 7.3.0 and mbedTLS
    
    Seen with downloaded mingw 7.3.0 when built against MSYS2 mbedTLS 3.6.2:
    ```
    lib/vtls/cipher_suite.c: In function 'cs_zip_to_str':
    lib/vtls/cipher_suite.c:789:16: error: conversion to 'uint8_t {aka unsigned char}' from 'int' may alter its value [-Werror=conversion]
       indexes[1] = ((zip[0] << 4) & 0x3F) | zip[1] >> 4;
                    ^
    lib/vtls/cipher_suite.c:790:16: error: conversion to 'uint8_t {aka unsigned char}' from 'int' may alter its value [-Werror=conversion]
       indexes[2] = ((zip[1] << 2) & 0x3F) | zip[2] >> 6;
                    ^
    lib/vtls/cipher_suite.c:793:16: error: conversion to 'uint8_t {aka unsigned char}' from 'int' may alter its value [-Werror=conversion]
       indexes[5] = ((zip[3] << 4) & 0x3F) | zip[4] >> 4;
                    ^
    lib/vtls/cipher_suite.c:794:16: error: conversion to 'uint8_t {aka unsigned char}' from 'int' may alter its value [-Werror=conversion]
       indexes[6] = ((zip[4] << 2) & 0x3F) | zip[5] >> 6;
                    ^
    ```
    Ref: https://github.com/curl/curl/actions/runs/13719756989/job/38372409927?pr=16429#step:10:21
    
    Cherry-picked from #16429
    Closes #16614

    Changed files

    • lib/vtls/cipher_suite.c
  17. Change #224213

    Category None
    Changed by Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at Fri 07 Mar 2025 15:54:59
    Repository https://github.com/curl/curl
    Project curl/curl
    Branch master
    Revision 27d24690a46138a949a555da3d5487e98fa7f5e9

    Comments

    GHA/windows: msys/mingw improvements
    
    - enable zstd in Cygwin and MSYS jobs.
    - dl-mingw: use Ninja in the 9.5.0 (winlibs-mingw) job.
      The download package is shipping with it. Saves 15s build time.
      Keep testing GNU Makefiles with the two mingw-builds jobs.
    - dl-mingw: split `env` prop to `env` and `ver` to aid integrating with
      MSYS2.
    - dl-mingw: install MSYS2 with options to make it quick (<20s).
      It allows to use MSYS2 dependency packages with the downloaded
      toolchains. It also makes configuration cleaner. Install libpsl.
    - dl-mingw: enable mbedTLS in the 7.3.0 job.
      (OpenSSL took a long time to install, wolfSSL misses features.)
    
    Assisted-by: Jeremy Drake
    
    Closes #16429

    Changed files

    • .github/workflows/windows.yml