Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Builder curl-ares-solaris11-i386 Build #3887

Results:

Build successful

SourceStamp:

Projectcurl
Repositoryhttps://github.com/curl/curl.git
Branchmaster
Revision0b091328773c64e23f5c4739da74527093c6a5ab
Got Revision0b091328773c64e23f5c4739da74527093c6a5ab
Changes1 change

BuildSlave:

unstable11x

Reason:

The SingleBranchScheduler scheduler named 'schedule-curl-ares-solaris11-i386' triggered this build

Steps and Logfiles:

  1. git update ( 11 secs )
    1. stdio
  2. Runtest './tests/testcurl.pl --nogitpull ...' ( 50 mins, 29 secs )
    1. stdio
    2. resultlog
  3. Mail result 'cat resultlog ...' ( 0 secs )
    1. stdio

Build Properties:

NameValueSource
branch master Build
builddir /export/home/buildbot/slave/curl-ares-solaris11-i386 slave
buildername curl-ares-solaris11-i386 Builder
buildnumber 3887 Build
codebase Build
got_revision 0b091328773c64e23f5c4739da74527093c6a5ab Git
osplatform I386 SetPropertyFromCommand Step
osrelease 11 SetPropertyFromCommand Step
project curl Build
repository https://github.com/curl/curl.git Build
revision 0b091328773c64e23f5c4739da74527093c6a5ab Build
scheduler schedule-curl-ares-solaris11-i386 Scheduler
slavename unstable11x BuildSlave
workdir /export/home/buildbot/slave/curl-ares-solaris11-i386 slave (deprecated)

Forced Build Properties:

NameLabelValue

Responsible Users:

  1. Stefan Eissing

Timing:

StartFri Sep 5 13:35:57 2025
EndFri Sep 5 15:18:09 2025
Elapsed1 hrs, 42 mins, 11 secs

All Changes:

:

  1. Change #244497

    Category curl
    Changed by Stefan Eissing <stefanohnoyoudont@eissing.org>
    Changed at Fri 05 Sep 2025 13:17:39
    Repository https://github.com/curl/curl.git
    Project curl
    Branch master
    Revision 0b091328773c64e23f5c4739da74527093c6a5ab

    Comments

    websocket: handling of PONG frames
    The auto PONG frames were inserted into the connection at the time
    a PING had been decoded, irregardless if an upstream frame was just
    in the middle of being assembled.
    
    Add PONG frames only to the buffer if there is no frame currently
    assemebled and, if it is, set the control frame aside. This control
    frame is then added on the first opportunity of a "clean" send buffer.
    
    There is only a single control frame set aside at a time. This means
    a double PING will, when the PONG cannot be sent right away, only
    send the last PONG.
    
    I imagine this is fine. We want to prevent the endless buffering of
    PONG frames on a connection where the server sends but does no receives.
    
    Reported-by: Calvin Ruocco
    Fixes #16706
    Closes #18479

    Changed files

    • lib/ws.c