Builder curl-ares-solaris10-i386 Build #3494

Results:

Failed runtest

SourceStamp:

Project	curl
Repository	https://github.com/curl/curl.git
Branch	master
Revision	70779199f3cb163c3199d109a544187b6507d839
Got Revision	70779199f3cb163c3199d109a544187b6507d839
Changes	13 changes

BuildSlave:

unstable10x

Reason:

The SingleBranchScheduler scheduler named 'schedule-curl-ares-solaris10-i386' triggered this build

Steps and Logfiles:

git update ( 8 secs )
1. stdio
Runtest './tests/testcurl.pl --nogitpull ...' failed ( 2 hrs, 55 mins, 18 secs )
1. stdio
2. resultlog
Mail result 'cat resultlog ...' ( 2 secs )
1. stdio

Build Properties:

Name	Value	Source
branch	master	Build
builddir	/export/home/buildbot/slave/curl-ares-solaris10-i386	slave
buildername	curl-ares-solaris10-i386	Builder
buildnumber	3494	Build
codebase		Build
got_revision	70779199f3cb163c3199d109a544187b6507d839	Git
osplatform	I386	SetPropertyFromCommand Step
osrelease	10	SetPropertyFromCommand Step
project	curl	Build
repository	https://github.com/curl/curl.git	Build
revision	70779199f3cb163c3199d109a544187b6507d839	Build
scheduler	schedule-curl-ares-solaris10-i386	Scheduler
slavename	unstable10x	BuildSlave
workdir	/export/home/buildbot/slave/curl-ares-solaris10-i386	slave (deprecated)

Forced Build Properties:

Name	Label	Value

Responsible Users:

Daniel Stenberg
danielohnoyoudont@haxx.se
DoI
5291556+denandzohnoyoudont@users.noreply.github.com
Ethan Alker
ealker1ohnoyoudont@gmail.com
Fabrício Canedo
fabriciocanedo0311ohnoyoudont@gmail.com
Joel Depooter
joel.depooterohnoyoudont@safe.com
Stefan Eissing
stefanohnoyoudont@eissing.org
Viktor Szakats
commitohnoyoudont@vsz.me

Timing:

Start	Sat Jun 21 18:47:12 2025
End	Sun Jun 22 03:30:12 2025
Elapsed	8 hrs, 42 mins, 59 secs

All Changes:

:

Change #237202

Category	curl
Changed by	Ethan Alker <ealker1ohnoyoudont@gmail.com>
Changed at	Sat 21 Jun 2025 10:26:41
Repository	https://github.com/curl/curl.git
Project	curl
Branch	master
Revision	73ad54f7b0c6e2c6daece680733a05f9e67494c2

Comments

docs: fix docs for CURLOPT_PREQUOTE after #17616
Closes #17690

Changed files

docs/TODO
docs/cmdline-opts/quote.md
docs/libcurl/opts/CURLOPT_PREQUOTE.md

Change #237205

Category	curl
Changed by	Fabrício Canedo <fabriciocanedo0311ohnoyoudont@gmail.com>
Changed at	Sat 21 Jun 2025 10:29:49
Repository	https://github.com/curl/curl.git
Project	curl
Branch	master
Revision	612c5a8a2e966d66cbf282465be7128abede1370

Comments

docs: fix broken link in INSTALL.md
In INSTALL.md file, the link that points to CURL-DISABLE was broken,
so I fixed this issue changing the link from only "CURL-DISABLE.md" to
"https://github.com/curl/curl/blob/master/docs/CURL-DISABLE.md".

Fixes https://github.com/curl/curl-www/issues/427
Closes #17654

Changed files

docs/INSTALL.md

Change #237206

Category	curl
Changed by	Fabrício Canedo <fabriciocanedo0311ohnoyoudont@gmail.com>
Changed at	Sat 21 Jun 2025 10:32:06
Repository	https://github.com/curl/curl.git
Project	curl
Branch	master
Revision	17f8b1db5c3e5ac95e1ab72563701626818899d0

Comments

docs: fix broken link in CODE_REVIEW.md
In CODE_REVIEW.md file, the link that points to CONTRIBUTE was broken,
so I fixed this issue changing the link from only "CONTRIBUTE.md" to
"https://curl.se/dev/contribute.html".

Closes #17656

Changed files

docs/CODE_REVIEW.md

Change #237207

Category	curl
Changed by	Stefan Eissing <stefanohnoyoudont@eissing.org>
Changed at	Sat 21 Jun 2025 10:34:02
Repository	https://github.com/curl/curl.git
Project	curl
Branch	master
Revision	b7c676d13f0988bde9bb0e4c3cfc688072cdb2e0

Comments

vtls: change send/recv signatures of tls backends
Similar to connection filter changes, return a CURLcode and the
read/written amount as size_t *.

Closes #17593

Changed files

lib/vtls/gtls.c
lib/vtls/mbedtls.c
lib/vtls/openssl.c
lib/vtls/rustls.c
lib/vtls/schannel.c
lib/vtls/vtls.c
lib/vtls/vtls_int.h
lib/vtls/wolfssl.c

Change #237211

Category	curl
Changed by	Viktor Szakats <commitohnoyoudont@vsz.me>
Changed at	Sat 21 Jun 2025 10:43:32
Repository	https://github.com/curl/curl.git
Project	curl
Branch	master
Revision	ccb65643b6a6570f79432bb18418367ecba458ad

Comments

cmake: omit clang-tidy on internal libs curlu and curltool
Skip clang-tidy while compiling curlu and curltool internal libraries.
To save about 1 minute per run. These libraries compile the lib and src
sources a second time, with the `UNITTESTS` macro enabled, which makes
tiny difference, for internal use. I figure it's not worth the extra CI
(and local) time because finding extra issues in these passes is
unlikely, and if found, not critical.

autotools also doesn't check curlu and curltool with clang-tidy.

Ref: https://github.com/curl/curl/pull/17680#issuecomment-2991730158
Ref: https://stackoverflow.com/questions/61867616/ignore-certain-files-when-using-clang-tidy
Ref: https://cmake.org/cmake/help/latest/prop_tgt/LANG_CLANG_TIDY.html

Follow-up to fabfa8e4024473035b3e5c3c30c330be726d9bb4 #15825

Closes #17693

Changed files

lib/CMakeLists.txt
src/CMakeLists.txt

Change #237212

Category	curl
Changed by	Viktor Szakats <commitohnoyoudont@vsz.me>
Changed at	Sat 21 Jun 2025 10:49:05
Repository	https://github.com/curl/curl.git
Project	curl
Branch	master
Revision	7d8fa8276d4df7a89056ef4bfd1fee47efd56aa6

Comments

tests: drop `BUNDLE_SRC` variable
Derive it from `$BUNDLE` instead. autotools seems to be already relying
on `$BUNDLE_SRC` being equal to `$BUNDLE.c`. (I haven't realized this
before aaebb45f58b3f62876a68c17c71ac37d98f1b3bb.)

Also drop redundant `nodist_<target>_SOURCE` lines in tunits and units.

Follow-up to aaebb45f58b3f62876a68c17c71ac37d98f1b3bb #17688
Follow-up to 2c27a67daa1b76859c18d63e4e1f528db05b5e13 #17590

Closes #17692

Changed files

tests/client/CMakeLists.txt
tests/client/Makefile.am
tests/client/Makefile.inc
tests/libtest/CMakeLists.txt
tests/libtest/Makefile.am
tests/libtest/Makefile.inc
tests/server/CMakeLists.txt
tests/server/Makefile.am
tests/server/Makefile.inc
tests/tunit/CMakeLists.txt
tests/tunit/Makefile.am
tests/tunit/Makefile.inc
tests/unit/CMakeLists.txt
tests/unit/Makefile.am
tests/unit/Makefile.inc

Change #237213

Category	curl
Changed by	Joel Depooter <joel.depooterohnoyoudont@safe.com>
Changed at	Sat 21 Jun 2025 10:51:11
Repository	https://github.com/curl/curl.git
Project	curl
Branch	master
Revision	e3d9675924325bda60ff44510ada012d47962cde

Comments

libssh: fix incorrect return value in myssh_in_AUTH_PKEY_INIT
In the unlikely case that no SSH auth methods are supported, the
previous code would return 0 from myssh_in_AUTH_PKEY_INIT. However,
following the code path, it seems like it should be returning SSH_ERROR,
as set in myssh_to_ERROR (through myssh_to_GSSAPI_AUTH,
myssh_to_KEY_AUTH and myssh_to_PASSWD_AUTH).

In actuality, this is unlikely to occur, as the similar code in
myssh_in_AUTHLIST would have already returned an error in this scenario.
However setting a return value and then ignoring it is a bit fishy and
should be documented if this is intended.

I believe this used to return an error, but was changed in the recent
re-factoring of this code.

Closes #17691

Changed files

lib/vssh/libssh.c

Change #237216

Category	curl
Changed by	Daniel Stenberg <danielohnoyoudont@haxx.se>
Changed at	Sat 21 Jun 2025 10:52:15
Repository	https://github.com/curl/curl.git
Project	curl
Branch	master
Revision	84b62696d93695cd936b33c7917186df240ee291

Comments

top-complexity: lower max allowed complexity threshold to 90
Down from 100. Also make it show all functions with complexity > 65
(down from 70).

Closes #17689

Changed files

scripts/top-complexity

Change #237222

Category	curl
Changed by	DoI <5291556+denandzohnoyoudont@users.noreply.github.com>
Changed at	Sat 21 Jun 2025 11:04:29
Repository	https://github.com/curl/curl.git
Project	curl
Branch	master
Revision	9a2663322c330ff11275abafd612e9c99407a94a

Comments

curl: implement non-blocking STDIN read on Windows
Implements a seperate read thread for STDIN on Windows when curl is run
with -T/--upload-file .

This uses a similar technique to the nmap/ncat project, spawning a
seperate thread which creates a loop-back bound socket, sending STDIN
into this socket, and reading from the other end of said TCP socket in a
non-blocking way in the rest of curl.

Fixes #17451
Closes #17572

Changed files

src/tool_cb_rea.c
src/tool_doswin.c
src/tool_doswin.h
src/tool_operate.c

Change #237223

Category	curl
Changed by	Daniel Stenberg <danielohnoyoudont@haxx.se>
Changed at	Sat 21 Jun 2025 11:10:05
Repository	https://github.com/curl/curl.git
Project	curl
Branch	master
Revision	97a0ce8f89399497e5c4a49b9daaa6125666d90f

Comments

RELEASE-NOTES: synced

Changed files

RELEASE-NOTES

Change #237229

Category	curl
Changed by	Viktor Szakats <commitohnoyoudont@vsz.me>
Changed at	Sat 21 Jun 2025 11:51:01
Repository	https://github.com/curl/curl.git
Project	curl
Branch	master
Revision	7aa8d1eea1fe60b26e88abe2c672f70bf30f63cc

Comments

build: tidy up `Makefile.inc` use in lib and src
- cmake: use `CURL_RCFILES` instead of literal.
- cmake: use `LIB_RCFILES` instead of literal.
- cmake: fix comments.
- autotools: use `CURL_RCFILES` in `EXTRA_DIST`.
- autotools: use `LIB_RCFILES` in `EXTRA_DIST`.
- autotools: fix comments.
- autotools: fix indentation.

Closes #17694

Changed files

lib/CMakeLists.txt
lib/Makefile.am
src/CMakeLists.txt
src/Makefile.am

Change #237253

Category	curl
Changed by	Stefan Eissing <stefanohnoyoudont@eissing.org>
Changed at	Sat 21 Jun 2025 17:19:11
Repository	https://github.com/curl/curl.git
Project	curl
Branch	master
Revision	779937f8400910924154afafb85dedbe95b7dffa

Comments

multi: add dirty bitset
Add a bitset `dirty` to the multi handle. The presence of a transfer int
he "dirty" set means: this transfer has something to do ASAP.

"dirty" is set by multiplexing protocols like HTTP/2 and 3 when
encountering response data for another transfer than the current one.
"dirty" is set by protocols that want to be called.

Implementation:

* just an additional `uint_bset` in the multi handle
* `Curl_multi_mark_dirty()` to add a transfer to the dirty set.
* `multi_runsingle()` clears the dirty bit of the transfer at
   start. Without new dirty marks, this empties the set after
   al dirty transfers have been run.
* `multi_timeout()` immediately gives the current time and
   timeout_ms == 0 when dirty transfers are present.
* multi_event: marks all transfers tracked for a socket as dirty.
  Then marks all expired transfers as dirty. Then it runs
  all dirty transfers.

With this mechanism:

* Most uses of `EXPIRE_RUN_NOW` are replaced by `Curl_multi_mark_dirty()`
* `Curl_multi_mark_dirty()` is cheaper than querying if a transfer is
  already dirty or set for timeout. There is no need to check, just do it.
* `data->state.select_bits` is eliminated. We need no longer to
  simulate a poll event to make a transfer run.

Closes #17662

Changed files

lib/cf-h2-proxy.c
lib/connect.c
lib/doh.c
lib/easy.c
lib/http2.c
lib/imap.c
lib/multi.c
lib/multi_ev.c
lib/multi_ev.h
lib/multihandle.h
lib/multiif.h
lib/transfer.c
lib/urldata.h
lib/vquic/curl_msh3.c
lib/vquic/curl_ngtcp2.c
lib/vquic/curl_osslq.c
lib/vquic/curl_quiche.c
lib/vssh/libssh.c
lib/vssh/libssh2.c
lib/vssh/wolfssh.c

Change #237257

Category	curl
Changed by	Stefan Eissing <stefanohnoyoudont@eissing.org>
Changed at	Sat 21 Jun 2025 17:20:44
Repository	https://github.com/curl/curl.git
Project	curl
Branch	master
Revision	70779199f3cb163c3199d109a544187b6507d839

Comments

cf: replace the method get_host with query
Connection filters had a method `get_host()` which had not really been
documented. Since then, the cf had the `query()` method added. Replace
the separate get_host with query.

Add `CF_QUERY_HOST_PORT` as query to connection filters to retrieve
which remote hostname and port the filter (or its sub-filter) is talking
to. The query is implemented by HTTP and SOCKS filters, all others pass
it through.

Add `Curl_conn_get_current_host()` to retrieve the remote host and port
for a connection. During connect, this will return the host the
connection is talking to right now. Before/After connect, this will
return `conn->host.name`.

This is used by SASL authentication.

Closes #17419

Changed files

lib/cf-h1-proxy.c
lib/cf-h2-proxy.c
lib/cf-haproxy.c
lib/cf-https-connect.c
lib/cf-socket.c
lib/cfilters.c
lib/cfilters.h
lib/connect.c
lib/curl_sasl.c
lib/http2.c
lib/http_proxy.c
lib/http_proxy.h
lib/socks.c
lib/vquic/curl_msh3.c
lib/vquic/curl_ngtcp2.c
lib/vquic/curl_osslq.c
lib/vquic/curl_quiche.c
lib/vtls/vtls.c
tests/unit/unit2600.c