Builder curl-ares-solaris10-i386 Build #2345

Results:

Build successful

SourceStamp:

BuildSlave:

Reason:

The SingleBranchScheduler scheduler named 'schedule-curl-ares-solaris10-i386' triggered this build

Steps and Logfiles:

1. git update ( 2 secs )
   1. stdio
2. Runtest './tests/testcurl.pl --nogitpull ...' ( 23 mins, 44 secs )
   1. stdio
   2. resultlog
3. Mail result 'cat resultlog ...' ( 0 secs )
   1. stdio

Build Properties:

Forced Build Properties:

Responsible Users:

1. Pavel P

   pavlov.pavelohnoyoudont@gmail.com

Timing:

All Changes:

:

1. Change #196593

   Category	curl
   Changed by	Pavel P <pavlov.pavelohnoyoudont@gmail.com>
   Changed at	Tue 07 May 2024 20:54:11
   Repository	https://github.com/curl/curl.git
   Project	curl
   Branch	master
   Revision	428579f5d136fd473e97fe089c42ffee55b72a8f

   Comments

   asyn-thread: fix curl_global_cleanup crash in Windows
   - Make sure that asynchronous resolves handled by Winsock are stopped
     before WSACleanup is called.
   
   This is implemented by ensuring that when Curl_resolver_kill is called
   (eg via multi_done) it will cancel the Winsock asynchronous resolve and
   wait for the cancellation to complete. Winsock runs the asynchronous
   completion routine immediately when a resolve is canceled.
   
   Prior to this change it was possible that during curl_global_cleanup
   "a DNS resolver thread created by GetAddrInfoExW did not terminate yet,
   however curl is already shutting down, deinitializing Winsock with
   WSACleanup() leading to an access violation."
   
   Background:
   
   If libcurl is built with the asynchronous threaded resolver option for
   Windows then it resolves in one of two ways. For Windows 8.1 and later,
   libcurl resolves by using the Winsock asynchronous resolver which does
   its own thread management. For older versions of Windows, libcurl
   resolves by creating a separate thread that calls getaddrinfo. This
   change only affects the former and it's already handled for the latter.
   
   Reported-by: Ch40zz@users.noreply.github.com
   
   Fixes https://github.com/curl/curl/issues/13509
   Closes https://github.com/curl/curl/pull/13518

   Changed files

   • lib/asyn-thread.c
   • lib/curl_threads.c