Builder collectd-60-solaris10-sparc Build #74

Results:

Build successful

SourceStamp:

BuildSlave:

Reason:

The AnyBranchScheduler scheduler named 'schedule-collectd-60' triggered this build

Steps and Logfiles:

1. git update ( 1 mins, 2 secs )
   1. stdio
2. setproperty property 'ciflags' set ( 0 secs )
   1. stdio
   2. property changes
3. shell '/opt/csw/bin/bash ./build.sh' ( 10 mins, 11 secs )
   1. stdio
4. shell_1 './configure --prefix=/opt/csw ...' ( 5 mins, 26 secs )
   1. stdio
   2. config.log
5. shell_2 'gmake -k ...' ( 15 mins, 42 secs )
   1. stdio
6. shell_3 'gmake check' ( 15 mins, 4 secs )
   1. stdio
   2. test-suite.log

Build Properties:

Forced Build Properties:

Responsible Users:

1. Florian Forster

   octoohnoyoudont@collectd.org

Timing:

All Changes:

:

1. Change #188688

   Category	None
   Changed by	Florian Forster <octoohnoyoudont@collectd.org>
   Changed at	Mon 15 Jan 2024 08:40:06
   Repository	https://github.com/collectd/collectd
   Project	collectd/collectd
   Branch	collectd-6.0
   Revision	7de6192d5f827f0204cbf8c45ca921c3ed298cc8

   Comments

   common: Reserve a null byte when calling `strncpy`.
   
   While `sstrncpy` guarantees a null terminated string, some compilers don't get
   the memo and complain about the buffer size being equal to the size provided to
   *strncpy(3)*. This *is* a potential source of error with *strncpy(3)*, because
   if the source string is longer than the buffer, the buffer is not null
   terminated. That is the precise reason `sstrncpy` exists in the first place.
   
   Make these compilers happy by decreasing the size passed to *strncpy(3)* by
   one.

   Changed files

   • src/utils/common/common.c

2. Change #188691

   Category	None
   Changed by	Florian Forster <octoohnoyoudont@collectd.org>
   Changed at	Mon 15 Jan 2024 08:40:06
   Repository	https://github.com/collectd/collectd
   Project	collectd/collectd
   Branch	collectd-6.0
   Revision	d25f08fa2981a143aeb9087f387c291984f49c7c

   Comments

   common: Overhaul the `sstrncpy` implementation.
   
   Properly check all arguments and behave in a sane manner, i.e. don't crash.
   
   I went back and forth a few times on whether to return `NULL` or `dest` when `n == 0`.
   
   *   On the one hand, `n == 0` is not really an error and a situation that could
       naturally occur, e.g. when you're implementing code that appends to the end
       of a string.
   *   On the other hand, if we return `NULL` when `n` is zero we can guarantee
       that we will either return `NULL` or a null terminated string.
   
   Ultimately I decided to go with the stronger guarantee, i.e.
   
   ```c
   if (n == 0) {
     return NULL;
   }
   ```

   Changed files

   • src/utils/common/common.c
   • src/utils/common/common.h
   • src/utils/common/common_test.c

3. Change #188694

   Category	None
   Changed by	Florian Forster <octoohnoyoudont@collectd.org>
   Changed at	Mon 15 Jan 2024 11:35:20
   Repository	https://github.com/collectd/collectd
   Project	collectd/collectd
   Branch	collectd-6.0
   Revision	96c08e34b6a5885863fc31b208d1eb512eb18efd

   Comments

   Merge pull request #4233 from octo/6/strncpy
   
   [collectd 6] feat: Improve `sstrncpy` semantic.

   Changed files

   • src/utils/common/common.c
   • src/utils/common/common.h
   • src/utils/common/common_test.c