Builder collectd-60-solaris10-i386 Build #51

Results:

Build successful

SourceStamp:

BuildSlave:

Reason:

The AnyBranchScheduler scheduler named 'schedule-collectd-60' triggered this build

Steps and Logfiles:

1. git update ( 2 secs )
   1. stdio
2. setproperty property 'ciflags' set ( 0 secs )
   1. stdio
   2. property changes
3. shell '/opt/csw/bin/bash ./build.sh' ( 27 secs )
   1. stdio
4. shell_1 './configure --prefix=/opt/csw ...' ( 29 secs )
   1. stdio
   2. config.log
5. shell_2 'gmake -k ...' ( 1 mins, 41 secs )
   1. stdio
6. shell_3 'gmake check' ( 12 secs )
   1. stdio
   2. test-suite.log

Build Properties:

Forced Build Properties:

Responsible Users:

1. Florian Forster

   octoohnoyoudont@collectd.org
2. Leonard Göhrs

   l.goehrsohnoyoudont@pengutronix.de

Timing:

All Changes:

:

1. Change #186214

   Category	None
   Changed by	Leonard Göhrs <l.goehrsohnoyoudont@pengutronix.de>
   Changed at	Tue 12 Dec 2023 10:51:32
   Repository	https://github.com/collectd/collectd
   Project	collectd/collectd
   Branch	collectd-6.0
   Revision	88f388e7d2d61c3ed10a8f84a1ef81ec6353d144

   Comments

   src/write_http.c: use reference counting to decide when to free user_data
   
   The teardown code for the wh_callback_t struct previously relied on
   the order in which the different callback functions are de-initialized
   to be known and to never change.
   
   This is prone to failure and is indeed currently broken, leading to a
   segmentation fault on collectd exit.
   
   Fix this by counting the active references to the user data and freeing
   it once it reaches zero.
   
   Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>

   Changed files

   • src/write_http.c

2. Change #186215

   Category	None
   Changed by	Florian Forster <octoohnoyoudont@collectd.org>
   Changed at	Tue 12 Dec 2023 10:51:32
   Repository	https://github.com/collectd/collectd
   Project	collectd/collectd
   Branch	collectd-6.0
   Revision	abb68f59613ae2eaee590f5a5f05de6bb9218ba1

   Comments

   write_stackdriver plugin: Implement reference counting.

   Changed files

   • src/write_stackdriver.c

3. Change #186216

   Category	None
   Changed by	Florian Forster <octoohnoyoudont@collectd.org>
   Changed at	Tue 12 Dec 2023 10:51:32
   Repository	https://github.com/collectd/collectd
   Project	collectd/collectd
   Branch	collectd-6.0
   Revision	30f7e7f461a524f61608776c7d9b370a52f11e70

   Comments

   write_riemann plugin: use reference counting to when freeing user data.
   
   While reference counting was present previously, it had problems:
   
   *   The reference passed to `plugin_register_flush()` was not counted.
   *   If a flush plugin was registered, `free_func` was set to NULL but
       the reference passed to `plugin_register_notification()` was still
       counted, meaning in that case the counter never went to zero.
   *   Mutexes must be unlocked when calling `pthread_mutex_destroy()`.
   *   The code limped on after an error, returning a failure eventually.
       This is unnecessarily complex control flow that has been simplified.

   Changed files

   • src/write_riemann.c

4. Change #186217

   Category	None
   Changed by	Florian Forster <octoohnoyoudont@collectd.org>
   Changed at	Tue 12 Dec 2023 10:51:32
   Repository	https://github.com/collectd/collectd
   Project	collectd/collectd
   Branch	collectd-6.0
   Revision	649043348cade0320d7b6127c9b0c3fd27633115

   Comments

   write_syslog plugin: Implement reference counting.

   Changed files

   • src/write_syslog.c

5. Change #186218

   Category	None
   Changed by	Florian Forster <octoohnoyoudont@collectd.org>
   Changed at	Tue 12 Dec 2023 10:51:32
   Repository	https://github.com/collectd/collectd
   Project	collectd/collectd
   Branch	collectd-6.0
   Revision	1c214afd4a064ed91eddafd58875054a92372ef1

   Comments

   write_tsdb plugin: Implement reference counting.

   Changed files

   • src/write_tsdb.c

6. Change #186219

   Category	None
   Changed by	Florian Forster <octoohnoyoudont@collectd.org>
   Changed at	Tue 12 Dec 2023 10:51:32
   Repository	https://github.com/collectd/collectd
   Project	collectd/collectd
   Branch	collectd-6.0
   Revision	48d6a5ef5943b9b07312fc9c66e8eb5f7eb892fd

   Comments

   write_http plugin: Unify coding style.
   
   A few plugins implement reference counting. Ensure that they use locks
   etc. consistently.

   Changed files

   • src/write_http.c

7. Change #186220

   Category	None
   Changed by	Florian Forster <octoohnoyoudont@collectd.org>
   Changed at	Tue 12 Dec 2023 10:51:32
   Repository	https://github.com/collectd/collectd
   Project	collectd/collectd
   Branch	collectd-6.0
   Revision	7ad6899d3736c52960fbe6a5b0fda5b81759f83c

   Comments

   write_riemann plugin: Unify reference counting code with other plugins.

   Changed files

   • src/write_riemann.c

8. Change #186221

   Category	None
   Changed by	Florian Forster <octoohnoyoudont@collectd.org>
   Changed at	Tue 12 Dec 2023 10:55:49
   Repository	https://github.com/collectd/collectd
   Project	collectd/collectd
   Branch	collectd-6.0
   Revision	488a1f58e05621213a0315556489dc601f62acf0

   Comments

   Merge pull request #4176 from octo/6/write_http
   
   [collectd 6] add reference counting to plugins that register multiple callbacks with the same `user_data_t`.

   Changed files

   • src/write_http.c
   • src/write_riemann.c
   • src/write_stackdriver.c
   • src/write_syslog.c
   • src/write_tsdb.c