Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Builder collectd-60-solaris10-i386 Build #47

Results:

Build successful

SourceStamp:

Projectcollectd/collectd
Repositoryhttps://github.com/collectd/collectd
Branchcollectd-6.0
Revision4237e9e0b55a67374e1f926b52744b7db889d360
Got Revision4237e9e0b55a67374e1f926b52744b7db889d360
Changes26 changes

BuildSlave:

unstable10x

Reason:

The AnyBranchScheduler scheduler named 'schedule-collectd-60' triggered this build

Steps and Logfiles:

  1. git update ( 2 secs )
    1. stdio
  2. setproperty property 'ciflags' set ( 0 secs )
    1. stdio
    2. property changes
  3. shell '/opt/csw/bin/bash ./build.sh' ( 27 secs )
    1. stdio
  4. shell_1 './configure --prefix=/opt/csw ...' ( 32 secs )
    1. stdio
    2. config.log
  5. shell_2 'gmake -k ...' ( 1 mins, 38 secs )
    1. stdio
  6. shell_3 'gmake check' ( 13 secs )
    1. stdio
    2. test-suite.log

Build Properties:

NameValueSource
branch collectd-6.0 Build
builddir /export/home/buildbot/slave/collectd-60-solaris10-i386 slave
buildername collectd-60-solaris10-i386 Builder
buildnumber 47 Build
ciflags --disable-aggregation --disable-check_uptime --disable-csv --disable-java --disable-lua --disable-match_empty_counter --disable-match_hashed --disable-match_regex --disable-match_timediff --disable-match_value --disable-network --disable-perl --disable-postgresql --disable-target_notification --disable-target_replace --disable-target_scale --disable-target_set --disable-target_v5upgrade --disable-threshold --disable-write_graphite --disable-write_kafka --disable-write_mongodb --disable-write_pro .. [property value too long] SetPropertyFromCommand Step
codebase Build
got_revision 4237e9e0b55a67374e1f926b52744b7db889d360 Git
project collectd/collectd Build
repository https://github.com/collectd/collectd Build
revision 4237e9e0b55a67374e1f926b52744b7db889d360 Build
scheduler schedule-collectd-60 Scheduler
slavename unstable10x BuildSlave
workdir /export/home/buildbot/slave/collectd-60-solaris10-i386 slave (deprecated)

Forced Build Properties:

NameLabelValue

Responsible Users:

  1. Florian Forster
  2. Florian Forster
  3. Jim Klimov

Timing:

StartFri Dec 1 10:51:46 2023
EndFri Dec 1 10:54:42 2023
Elapsed2 mins, 55 secs

All Changes:

:

  1. Change #185565

    Category None
    Changed by Florian Forster <octoohnoyoudont@collectd.org>
    Changed at Wed 29 Nov 2023 21:56:19
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision adf0963f8325efbbfc5684df712942bc754a25b9

    Comments

    configure: ensure there is a `plugin_foo` variable for each plugin.

    Changed files

    • configure.ac

  2. Change #185566

    Category None
    Changed by Florian Forster <octoohnoyoudont@collectd.org>
    Changed at Wed 29 Nov 2023 21:56:19
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision 174d70ed0f7c98afe8b8dd1c21e012215346fcd7

    Comments

    configure: disable all plugins not yet supporting collectd 6.

This should allow us (and users) to just run `./configure` without
further flags, lowering the barrier to entry. It also allows us to
remove these configure flags from the CI configuration.

    Changed files

    • configure.ac

  3. Change #185567

    Category None
    Changed by Florian Forster <octoohnoyoudont@collectd.org>
    Changed at Wed 29 Nov 2023 21:56:19
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision e91583f6dfa3704ae512a38ff703b2fb1765875c

    Comments

    Import workflow definitions from `main`.

    Changed files

    • .cirrus.yml
    • .github/workflows/build.yml
    • .github/workflows/distcheck.yml

  4. Change #185568

    Category None
    Changed by Florian Forster <octoohnoyoudont@collectd.org>
    Changed at Wed 29 Nov 2023 21:56:19
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision 02f01f582effa51497590edca358cb17eb0ce01a

    Comments

    curl_stats: fix compatibility with new versions of cURL.

Use integer based keys for metrics if available.

cURL ≥ 7.55.0 provides additional keys that allow getting certain
metrics as integers rather than doubles, e.g. content length. In some
newer versions of cURL, the original keys (using doubles) are marked as
deprecated.

ChangeLog: cURL, cURL-JSON, cURL-XML, Write HTTP plugins: fix compatibility with new versions of cURL.

    Changed files

    • src/utils/curl_stats/curl_stats.c

  5. Change #185569

    Category None
    Changed by Florian Forster <octoohnoyoudont@collectd.org>
    Changed at Wed 29 Nov 2023 21:56:19
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision 49b3da0bc9928b34414297f12c02376d9a193271

    Comments

    gmond plugin: Import `<ganglia.h>`.

`<gm_protocol.h>` has been removed in new versions of libganglia.

    Changed files

    • configure.ac
    • src/gmond.c

  6. Change #185570

    Category None
    Changed by Florian Forster <octoohnoyoudont@collectd.org>
    Changed at Wed 29 Nov 2023 21:56:20
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision 3032dde118a3c5a586d051508d35a99514939c34

    Comments

    gmond plugin: Look for RPC headers in /usr/include/tirpc.

glibc removed the SunRPC headers, and the replacement headers are in a
different location. Try and look for them there.

    Changed files

    • configure.ac

  7. Change #185571

    Category None
    Changed by Florian Forster <octoohnoyoudont@collectd.org>
    Changed at Wed 29 Nov 2023 21:56:20
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision f95e356a303cfc56cb4b7033a9865d1e3e817d47

    Comments

    gmond plugin: Improve `mc_handle_metadata_msg()`.

This function was not properly formatted. While there:

* Handle the error instead of indenting the successful flow.
* Declare variables late.
* Initialize variables when declaring them.

    Changed files

    • src/gmond.c

  8. Change #185572

    Category None
    Changed by Florian Forster <octoohnoyoudont@collectd.org>
    Changed at Wed 29 Nov 2023 21:56:20
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision 782de83be4c0658a5f64f030f33a397f01efbf4c

    Comments

    cpu plugin: Fix potential buffer overflow.

```
In function 'cpu_commit_without_aggregation',
    inlined from 'cpu_commit' at src/cpu.c:563:5,
    inlined from 'cpu_read' at src/cpu.c:925:3:
src/cpu.c:534:50: note: directive argument in the range [0, 18446744073709551614]
  534 |       snprintf(cpu_num_str, sizeof(cpu_num_str), "%zu", cpu_num);
      |                                                  ^~~~~
src/cpu.c:534:7: note: 'snprintf' output between 2 and 21 bytes into a destination of size 16
  534 |       snprintf(cpu_num_str, sizeof(cpu_num_str), "%zu", cpu_num);
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

    Changed files

    • src/cpu.c

  9. Change #185573

    Category None
    Changed by Florian Forster <octoohnoyoudont@collectd.org>
    Changed at Wed 29 Nov 2023 21:56:20
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision 63d3efd2fce649465f6112a55a6659a44d252676

    Comments

    capabilities plugin: remove warning about "leaking" a pointer to a local variable.

```
src/capabilities.c: In function 'cap_http_handler':
src/capabilities.c:209:23: error: storing the address of local variable '({anonymous})' in '*connection_state' [-Werror=dangling-pointer=]
  209 |     *connection_state = &(int){44};
      |     ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
src/capabilities.c:209:31: note: '({anonymous})' declared here
  209 |     *connection_state = &(int){44};
      |                               ^
src/capabilities.c:209:31: note: 'connection_state' declared here
```

    Changed files

    • src/capabilities.c

  10. Change #185574

    Category None
    Changed by Jim Klimov <jimklimov+nutohnoyoudont@gmail.com>
    Changed at Wed 29 Nov 2023 21:56:20
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision 3e8355963221c9ab6a2f69f21404ca107a145123

    Comments

    configure.ac, src/nut.c: detect int types required by NUT API we build against

Either use the stricter int types required by NUT headers since v2.8.0 release,
or the relaxed (arch-dependent) types required by older NUT releases - depending
on which NUT API version the collectd is building against at the moment.

Inspired by discussion at https://github.com/networkupstools/nut/issues/1638

    Changed files

    • configure.ac
    • src/nut.c

  11. Change #185575

    Category None
    Changed by Jim Klimov <jimklimov+nutohnoyoudont@gmail.com>
    Changed at Wed 29 Nov 2023 21:56:20
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision 630939177be14beb801a3533b50c3dc7248f9525

    Comments

    configure.ac: if neither UPSCONN{,_t} type was found, refuse to build NUT plugin

NOTE: src/nut.c also has pragmas to error out in this situation,
but that handling is compiler-dependent and happens too late in
the checkout/configure/build loop.

Presumably this inability to find the type in the earlier-found header file
is also triggered by build environment "inconsistencies" like lack of basic
types in the libc implementation (maybe highlighting the need for additional
headers or macros for the platform).

    Changed files

    • configure.ac

  12. Change #185576

    Category None
    Changed by Florian Forster <octoohnoyoudont@collectd.org>
    Changed at Wed 29 Nov 2023 21:56:20
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision 9cf0485e5726bc04dea6af8c705f033c2d74dfdb

    Comments

    NUT plugin: import `<time.h>` before `<upsclient.h>`.

    Changed files

    • configure.ac

  13. Change #185577

    Category None
    Changed by Florian Forster <octoohnoyoudont@collectd.org>
    Changed at Wed 29 Nov 2023 21:56:20
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision 1eb2aab3d0105664b9d58254e12b6124e6838190

    Comments

    Add Valgrind suppression for libvirt memory leak.

    Changed files

    • src/valgrind.suppress

  14. Change #185578

    Category None
    Changed by Florian Forster <octoohnoyoudont@collectd.org>
    Changed at Wed 29 Nov 2023 21:56:21
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision c4455ddca49df2466c3e1abb898e6c7c0544d0eb

    Comments

    Netlink plugin: complete initialize structs used for testing.

Valgrind complains about a conditional jump based on uninitialized
memory:

```
==66438== Conditional jump or move depends on uninitialised value(s)
==66438==    at 0x10CA06: vf_info_submit (in /__w/collectd/collectd/test_plugin_netlink)
==66438==    by 0x1110F2: test_vf_submit_test (in /__w/collectd/collectd/test_plugin_netlink)
==66438==    by 0x112EAC: main (in /__w/collectd/collectd/test_plugin_netlink)
```

This is likely caused by the `vf_stats_t` being only partially
initialized. Using a struct initializer is not only cleaner, it also
ensures the remainder of the struct is initialized to zero.

    Changed files

    • src/netlink_test.c

  15. Change #185579

    Category None
    Changed by Florian Forster <octoohnoyoudont@collectd.org>
    Changed at Wed 29 Nov 2023 21:56:21
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision a0eec8136de277fcede430e03ad4ad02fe39de8d

    Comments

    SMART plugin: initialize struct passed to `ioctl(2)`.

Valgrind is complaining about a conditional jump based on uninitialized
memory:

```
==66462== Conditional jump or move depends on uninitialised value(s)
==66462==    at 0x10C500: smart_read_nvme_intel_disk (in /__w/collectd/collectd/test_plugin_smart)
==66462==    by 0x10D366: test_x (in /__w/collectd/collectd/test_plugin_smart)
==66462==    by 0x10D638: main (in /__w/collectd/collectd/test_plugin_smart)
```

This may be due to the `struct nvme_additional_smart_log` being
uninitialized when it's being passed to `ioctl(2)`.

This there, this removed an unnecessary level of indentation.

    Changed files

    • src/smart.c

  16. Change #185580

    Category None
    Changed by Florian Forster <octoohnoyoudont@collectd.org>
    Changed at Wed 29 Nov 2023 21:56:21
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision d5eeca856ceece386a9143993bc29d98925f6489

    Comments

    procevent plugin: remove use of a nested flexible array member.

The previous code used an ad-hoc struct to construct or parse a Netlink
message. This relied on allocating a field _after_ the struct with the
flexible array member, which is prohibited by the C standard, leading to
compiler warnings.

    Changed files

    • src/procevent.c

  17. Change #185581

    Category None
    Changed by Florian Forster <octoohnoyoudont@collectd.org>
    Changed at Wed 29 Nov 2023 21:56:21
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision 669934d1b0571b79f71000c8f55aada175116bc3

    Comments

    procevent plugin: ensure the ring buffer length is not zero.

The manpage documents a default of 10, which was not implemented. This
change brings the implementation in line with the documentation.

    Changed files

    • src/procevent.c

  18. Change #185582

    Category None
    Changed by Florian Forster <octoohnoyoudont@collectd.org>
    Changed at Wed 29 Nov 2023 21:56:21
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision 21d5703f996c622cf101144c963e894d9121a0ad

    Comments

    procevent plugin: report errors in human readable form.

    Changed files

    • src/procevent.c

  19. Change #185583

    Category None
    Changed by Florian Forster <ffohnoyoudont@octo.it>
    Changed at Wed 29 Nov 2023 21:56:21
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision 17de0c10b84214102c0526f33133ad726fba2adb

    Comments

    procevent plugin: Reference buffer sizing guideline.

Co-authored-by: Eero Tamminen <eero.t.tamminen@intel.com>

    Changed files

    • src/procevent.c

  20. Change #185584

    Category None
    Changed by Florian Forster <octoohnoyoudont@collectd.org>
    Changed at Wed 29 Nov 2023 21:56:21
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision 88b5d3e62151010cbcdffe72ced3167c2de4e254

    Comments

    procevent plugin: Consistently mention the unit in log message.

Co-authored-by: Eero Tamminen <eero.t.tamminen@intel.com>

    Changed files

    • src/procevent.c

  21. Change #185585

    Category None
    Changed by Florian Forster <octoohnoyoudont@collectd.org>
    Changed at Wed 29 Nov 2023 21:56:22
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision fc378172e245b2c246e37adb914eb8bb724da3f4

    Comments

    capabilities plugin: Make state tracking clearer in the MDH handler.

    Changed files

    • src/capabilities.c

  22. Change #185586

    Category None
    Changed by Florian Forster <octoohnoyoudont@collectd.org>
    Changed at Wed 29 Nov 2023 21:56:22
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision 2a07399db82d183dd5f076072bad6df816da708d

    Comments

    configure.ac: De-cuplicate `plugin_foo` definitions.

Apparently we defined a bunch of `plugin_foo` variables that were never
used. The generated list from the arguments to `AC_PLUGIN` now appear as
duplicates. This removes the previously unused definitions and leaves
the generated ones.

    Changed files

    • configure.ac

  23. Change #185587

    Category None
    Changed by Florian Forster <octoohnoyoudont@collectd.org>
    Changed at Wed 29 Nov 2023 21:56:22
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision 7a05a319d29de724629e11105242955a7bbfe304

    Comments

    mdevents plugin: Re-enable the `compile_regex` test.

    Changed files

    • src/mdevents_test.c

  24. Change #185588

    Category None
    Changed by Florian Forster <octoohnoyoudont@collectd.org>
    Changed at Wed 29 Nov 2023 21:56:22
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision e65cfc0480cc0a7dae2514a0dcae3a0a65868134

    Comments

    Intel RDT plugin: use `pqos_mon_start_pids2()` if available.

Newer versions of the pqos library deprecate the previous function, so
we have to migrate even though it makes memory management quite ugly.

ChangeLog: Intel RDT plugin: support for PQOS ≥5.0.0 has been added.

    Changed files

    • src/intel_rdt.c

  25. Change #185589

    Category None
    Changed by Florian Forster <octoohnoyoudont@collectd.org>
    Changed at Wed 29 Nov 2023 21:56:22
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision 056b05c531886f75b494224c75d2dc6d9acb7c39

    Comments

    Intel RDT plugin: use `pqos_mon_start_cores()` if available.

    Changed files

    • src/intel_rdt.c

  26. Change #185590

    Category None
    Changed by Florian Forster <octoohnoyoudont@collectd.org>
    Changed at Fri 01 Dec 2023 10:50:39
    Repository https://github.com/collectd/collectd
    Project collectd/collectd
    Branch collectd-6.0
    Revision 4237e9e0b55a67374e1f926b52744b7db889d360

    Comments

    Merge pull request #4174 from octo/workflows6

[collectd 6.0] Fix the build

    Changed files

    • .cirrus.yml
    • .github/workflows/build.yml
    • .github/workflows/distcheck.yml
    • configure.ac
    • src/capabilities.c
    • src/cpu.c
    • src/gmond.c
    • src/intel_rdt.c
    • src/mdevents_test.c
    • src/netlink_test.c
    • src/nut.c
    • src/procevent.c
    • src/smart.c
    • src/utils/curl_stats/curl_stats.c
    • src/valgrind.suppress
BuildBot (0.8.14) working for the OpenCSW Buildbot project.
Page built: Tue 01 Jul 2025 01:04:56 (CEST)